From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE9B3C6786E for ; Fri, 26 Oct 2018 07:59:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BFF812082E for ; Fri, 26 Oct 2018 07:59:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BFF812082E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lemonage.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726493AbeJZQfQ (ORCPT ); Fri, 26 Oct 2018 12:35:16 -0400 Received: from smtp1-3.goneo.de ([85.220.129.32]:54945 "EHLO smtp1-3.goneo.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726354AbeJZQfP (ORCPT ); Fri, 26 Oct 2018 12:35:15 -0400 Received: from localhost (localhost [127.0.0.1]) by smtp1.goneo.de (Postfix) with ESMTP id 5F33E2424BA; Fri, 26 Oct 2018 09:59:12 +0200 (CEST) X-Virus-Scanned: by goneo Received: from smtp1.goneo.de ([127.0.0.1]) by localhost (smtp1.goneo.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yOcVcVLkoBRa; Fri, 26 Oct 2018 09:59:11 +0200 (CEST) Received: from lem-wkst-02.lemonage (hq.lemonage.de [87.138.178.34]) by smtp1.goneo.de (Postfix) with ESMTPSA id 46C9F24253E; Fri, 26 Oct 2018 09:59:11 +0200 (CEST) Date: Fri, 26 Oct 2018 09:59:06 +0200 From: Lars Poeschel To: Rob Herring Cc: devicetree@vger.kernel.org, Mark Rutland , open list Subject: Re: [PATCH v3 2/5] nfc: pn532_uart: Add NXP PN532 to devicetree docs Message-ID: <20181026075906.GA28338@lem-wkst-02.lemonage> References: <20181025132937.24405-1-poeschel@lemonage.de> <20181025132937.24405-2-poeschel@lemonage.de> <20181025215445.GA16550@bogus> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181025215445.GA16550@bogus> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 25, 2018 at 04:54:45PM -0500, Rob Herring wrote: > On Thu, Oct 25, 2018 at 03:29:33PM +0200, Lars Poeschel wrote: > > Add a simple binding doc for the pn532. > > > > Signed-off-by: Lars Poeschel > > --- > > Changes in v3: > > - seperate binding doc instead of entry in trivial-devices.txt > > > > .../devicetree/bindings/nfc/pn532.txt | 31 +++++++++++++++++++ > > 1 file changed, 31 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/nfc/pn532.txt > > > > diff --git a/Documentation/devicetree/bindings/nfc/pn532.txt b/Documentation/devicetree/bindings/nfc/pn532.txt > > new file mode 100644 > > index 000000000000..a2df72a5f504 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/nfc/pn532.txt > > @@ -0,0 +1,31 @@ > > +NXP PN532 NFC Chip > > What about the PN533? I read the publicy available docs from NXP a bit and I think this is wrong. PN533 is the version of the chip with usb. It does not have a i2c client interface. It only has a i2c master interface, but this serves us no purpose here and is furthermore not supported by the driver. PN532 is the version of the chip for "simple" serial protocols. It's interfaces to the host are uart, i2c and spi. So I left PN533 out here. > > + > > +Required properties: > > +- compatible: Should be > > + - "nxp,pn532" Place a node with this inside the devicetree node of the bus > > + where the NFC chip is connected to. > > + Currently the kernel has phy bindings for uart and i2c. > > + - "nxp,pn532-i2c" (DEPRECATED) only works for the i2c binding. > > + - "nxp,pn533-i2c" (DEPRECATED) only works for the i2c binding. > > + > > +There are no additional properties provided by the driver at the moment. > > I2C requires reg. I was so deeply focused at my uart part. Sorry, I missed that. I will wait a bit if I get some more feedback and will address this in the next version of the patchset. > > + > > +Example uart: > > + > > +uart4: serial@49042000 { > > + compatible = "ti,omap3-uart"; > > + > > + pn532: nfc { > > + compatible = "nxp,pn532"; > > + }; > > +}; > > + > > +Example i2c: > > + > > +i2c1: i2c@0 { > > + compatible = "ti,omap3-i2c"; > > + > > + pn532: nfc { > > + compatible = "nxp,pn532"; > > + }; > > +}; > > -- > > 2.19.1 > > Thank you for your review, Lars