All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Jacek Anaszewski <jacek.anaszewski@gmail.com>
Cc: Dan Murphy <dmurphy@ti.com>, Rob Herring <robh@kernel.org>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-leds@vger.kernel.org, lee.jones@linaro.org,
	tony@atomide.com
Subject: Re: [PATCH v4 2/7] dt-bindings: ti-lmu: Modify dt bindings for the LM3697
Date: Fri, 26 Oct 2018 10:30:37 +0200	[thread overview]
Message-ID: <20181026083037.GA19434@amd> (raw)
In-Reply-To: <ade3121a-58ab-c0c3-6605-cf7d6a638da0@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1273 bytes --]

Hi!

> >>>>> +Optional child properties:
> >>>>> +	- runtime-ramp-up-msec: Current ramping from one brightness level to
> >>>>> +				the a higher brightness level.
> >>>>> +				Range from 2048 us - 117.44 s

> This is this problem with the Device Tree's scope of responsibility.
> It is defined as a means for "describing the hardware", but often
> this rule is abused by the properties that fall into "configuration"
> category. E.g. default-state, retain-state-suspended from leds-gpio.txt
> or linux-default-trigger from common LED bindings.

I always assumed that ramp-up time is there because hardware (power
supply?) can not handle "too fast" switching. Missing capacitors or
something. If so, this needs to be in device tree.

If not, it indeed does not belong to device tree.

> In some cases this is justified. The question is whether it is something
> that necessarily needs to be configured on driver probing? If not, then
> I'd go for sysfs interface.

While this would be useful for hardware accelerated patterns, I doubt
we want to make it configurable without that support.

									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

  parent reply	other threads:[~2018-10-26  8:30 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-23 17:06 [PATCH v4 1/7] leds: add TI LMU backlight driver Dan Murphy
2018-10-23 17:06 ` Dan Murphy
2018-10-23 17:06 ` [PATCH v4 2/7] dt-bindings: ti-lmu: Modify dt bindings for the LM3697 Dan Murphy
2018-10-23 17:06   ` Dan Murphy
2018-10-24  9:04   ` Pavel Machek
2018-10-24 12:07     ` Dan Murphy
2018-10-24 12:07       ` Dan Murphy
2018-10-24 13:43       ` Pavel Machek
2018-10-24 14:54       ` Rob Herring
2018-10-25 18:07         ` Dan Murphy
2018-10-25 18:07           ` Dan Murphy
2018-10-25 18:27           ` Jacek Anaszewski
2018-10-25 18:32             ` Dan Murphy
2018-10-25 18:32               ` Dan Murphy
2018-10-25 19:54             ` Rob Herring
2018-10-26  8:30             ` Pavel Machek [this message]
2018-10-26  8:37             ` Pavel Machek
2018-10-30 13:40               ` Dan Murphy
2018-10-30 13:40                 ` Dan Murphy
2019-03-02 23:07                 ` Pavel Machek
2019-03-04 19:14                   ` Dan Murphy
2019-03-04 19:14                     ` Dan Murphy
2018-10-24 14:49   ` Rob Herring
2018-10-25 17:56     ` Dan Murphy
2018-10-25 17:56       ` Dan Murphy
2018-10-23 17:06 ` [PATCH v4 3/7] mfd: ti-lmu: Remove support for LM3697 Dan Murphy
2018-10-23 17:06   ` Dan Murphy
2018-10-23 17:06 ` [PATCH v4 4/7] leds: lm3697: Introduce the lm3697 driver Dan Murphy
2018-10-23 17:06   ` Dan Murphy
2018-10-23 17:06 ` [PATCH v4 5/7] dt-bindings: ti-lmu: Modify dt bindings for the LM3633 Dan Murphy
2018-10-23 17:06   ` Dan Murphy
2018-10-24  9:23   ` Pavel Machek
2018-10-24 14:35     ` Rob Herring
2018-10-24 18:38       ` Pavel Machek
2018-10-24 21:50         ` Rob Herring
2018-10-25 18:01     ` Dan Murphy
2018-10-25 18:01       ` Dan Murphy
2018-10-23 17:06 ` [PATCH v4 6/7] mfd: ti-lmu: Remove support for LM3633 Dan Murphy
2018-10-23 17:06   ` Dan Murphy
2018-10-23 17:06 ` [PATCH v4 7/7] leds: lm3633: Introduce the lm3633 driver Dan Murphy
2018-10-23 17:06   ` Dan Murphy
2018-10-24  9:14 ` [PATCH v4 1/7] leds: add TI LMU backlight driver Pavel Machek
2018-10-24 12:27   ` Dan Murphy
2018-10-24 12:27     ` Dan Murphy
2018-10-24 13:17     ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181026083037.GA19434@amd \
    --to=pavel@ucw.cz \
    --cc=devicetree@vger.kernel.org \
    --cc=dmurphy@ti.com \
    --cc=jacek.anaszewski@gmail.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.