From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Zijlstra Subject: Re: [PATCH 1/4] treewide: remove unused address argument from pte_alloc functions (v2) Date: Fri, 26 Oct 2018 10:50:47 +0200 Message-ID: <20181026085047.GB3109@worktop.c.hoisthospitality.com> References: <20181013013200.206928-1-joel@joelfernandes.org> <20181013013200.206928-2-joel@joelfernandes.org> <20181024083716.GN3109@worktop.c.hoisthospitality.com> <20181025104703.esl6wxyg2ihe4zoc@kshutemo-mobl1> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Cc: linux-mips@linux-mips.org, Rich Felker , linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org, Catalin Marinas , Dave Hansen , Will Deacon , Michal Hocko , linux-mm@kvack.org, lokeshgidra@google.com, "Joel Fernandes \(Google\)" , linux-riscv@lists.infradead.org, elfring@users.sourceforge.net, Jonas Bonn , kvmarm@lists.cs.columbia.edu, dancol@google.com, Yoshinori Sato , sparclinux@vger.kernel.org, linux-xtensa@linux-xtensa.org, linux-hexagon@vger.kernel.org, Helge Deller , "maintainer:X86 ARCHITECTURE \(32-BIT AND 64-BIT\)" , hughd@google.com, "James E.J. Bottomley" , kasan-dev@googlegroups.com, anton.ivanov@kot-begemot.co.uk, Ingo Molna To: "Kirill A. Shutemov" Return-path: In-Reply-To: <20181025104703.esl6wxyg2ihe4zoc@kshutemo-mobl1> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-riscv-bounces+glpr-linux-riscv=m.gmane.org@lists.infradead.org On Thu, Oct 25, 2018 at 01:47:03PM +0300, Kirill A. Shutemov wrote: > On Wed, Oct 24, 2018 at 10:37:16AM +0200, Peter Zijlstra wrote: > > On Fri, Oct 12, 2018 at 06:31:57PM -0700, Joel Fernandes (Google) wrote: > > > This series speeds up mremap(2) syscall by copying page tables at the > > > PMD level even for non-THP systems. There is concern that the extra > > > 'address' argument that mremap passes to pte_alloc may do something > > > subtle architecture related in the future that may make the scheme not > > > work. Also we find that there is no point in passing the 'address' to > > > pte_alloc since its unused. So this patch therefore removes this > > > argument tree-wide resulting in a nice negative diff as well. Also > > > ensuring along the way that the enabled architectures do not do anything > > > funky with 'address' argument that goes unnoticed by the optimization. > > > > Did you happen to look at the history of where that address argument > > came from? -- just being curious here. ISTR something vague about > > architectures having different paging structure for different memory > > ranges. > > I see some archicetures (i.e. sparc and, I believe power) used the address > for coloring. It's not needed anymore. Page allocator and SL?B are good > enough now. > > See 3c936465249f ("[SPARC64]: Kill pgtable quicklists and use SLAB.") Ah, shiny. Thanks. From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Fri, 26 Oct 2018 10:56:59 +0200 (CEST) Received: from merlin.infradead.org ([IPv6:2001:8b0:10b:1231::1]:55404 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S23992869AbeJZI4sdijEc (ORCPT ); Fri, 26 Oct 2018 10:56:48 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=t4U6dJOCnA0c/EZV0nmuSLy/HD8d4dYO3ZonI67d8Vk=; b=DPhftboxJNVK8gljOSI9ek+lk cu0xqt1kC5w7yCxw6Jsznw1tHw2bNfFS/B99G90XrfF2EouGTY+fnjyh2fFe8Ea4pm+LfBzpKsORm vHKSHxTajvN1zlzwJSY3IQRIoUSjK9Ks0EaN70/cGAc3V1cVwVubUjQU8B8T3dcCN+Cny2z4IXEkf 5989+J/lbf4qCCiiXPFuktGNapnha5La8DRY2VrXPeyZAvzLzZFAr0KwXyN2xKeaZefS1TlUOUz9Q v3E0AoVoDPrDe463fQg0erQi1phVVaaGU+vviNvYVqHIgoubM4nIzXXBkEBYhhWFO095CIUsfkQj8 Onm8/N6Lg==; Received: from [167.98.65.38] (helo=worktop) by merlin.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1gFxuk-00012P-H7; Fri, 26 Oct 2018 08:56:18 +0000 Received: by worktop (Postfix, from userid 1000) id 7F67E6E07BE; Fri, 26 Oct 2018 10:50:47 +0200 (CEST) Date: Fri, 26 Oct 2018 10:50:47 +0200 From: Peter Zijlstra To: "Kirill A. Shutemov" Cc: "Joel Fernandes (Google)" , linux-kernel@vger.kernel.org, kernel-team@android.com, Michal Hocko , Julia Lawall , akpm@linux-foundation.org, Andrey Ryabinin , Andy Lutomirski , anton.ivanov@kot-begemot.co.uk, Borislav Petkov , Catalin Marinas , Chris Zankel , dancol@google.com, Dave Hansen , "David S. Miller" , elfring@users.sourceforge.net, Fenghua Yu , Geert Uytterhoeven , Guan Xuetao , Helge Deller , hughd@google.com, Ingo Molnar , "James E.J. Bottomley" , Jeff Dike , Jonas Bonn , kasan-dev@googlegroups.com, kvmarm@lists.cs.columbia.edu, Ley Foon Tan , linux-alpha@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@linux-mips.org, linux-mm@kvack.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, lokeshgidra@google.com, Max Filippov , minchan@kernel.org, nios2-dev@lists.rocketboards.org, pantin@google.com, Richard Weinberger , Rich Felker , Sam Creasey , sparclinux@vger.kernel.org, Stafford Horne , Stefan Kristiansson , Thomas Gleixner , Tony Luck , Will Deacon , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , Yoshinori Sato Subject: Re: [PATCH 1/4] treewide: remove unused address argument from pte_alloc functions (v2) Message-ID: <20181026085047.GB3109@worktop.c.hoisthospitality.com> References: <20181013013200.206928-1-joel@joelfernandes.org> <20181013013200.206928-2-joel@joelfernandes.org> <20181024083716.GN3109@worktop.c.hoisthospitality.com> <20181025104703.esl6wxyg2ihe4zoc@kshutemo-mobl1> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181025104703.esl6wxyg2ihe4zoc@kshutemo-mobl1> User-Agent: Mutt/1.5.22.1 (2013-10-16) Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 66955 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: peterz@infradead.org Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On Thu, Oct 25, 2018 at 01:47:03PM +0300, Kirill A. Shutemov wrote: > On Wed, Oct 24, 2018 at 10:37:16AM +0200, Peter Zijlstra wrote: > > On Fri, Oct 12, 2018 at 06:31:57PM -0700, Joel Fernandes (Google) wrote: > > > This series speeds up mremap(2) syscall by copying page tables at the > > > PMD level even for non-THP systems. There is concern that the extra > > > 'address' argument that mremap passes to pte_alloc may do something > > > subtle architecture related in the future that may make the scheme not > > > work. Also we find that there is no point in passing the 'address' to > > > pte_alloc since its unused. So this patch therefore removes this > > > argument tree-wide resulting in a nice negative diff as well. Also > > > ensuring along the way that the enabled architectures do not do anything > > > funky with 'address' argument that goes unnoticed by the optimization. > > > > Did you happen to look at the history of where that address argument > > came from? -- just being curious here. ISTR something vague about > > architectures having different paging structure for different memory > > ranges. > > I see some archicetures (i.e. sparc and, I believe power) used the address > for coloring. It's not needed anymore. Page allocator and SL?B are good > enough now. > > See 3c936465249f ("[SPARC64]: Kill pgtable quicklists and use SLAB.") Ah, shiny. Thanks. From mboxrd@z Thu Jan 1 00:00:00 1970 From: peterz@infradead.org (Peter Zijlstra) Date: Fri, 26 Oct 2018 10:50:47 +0200 Subject: [PATCH 1/4] treewide: remove unused address argument from pte_alloc functions (v2) In-Reply-To: <20181025104703.esl6wxyg2ihe4zoc@kshutemo-mobl1> References: <20181013013200.206928-1-joel@joelfernandes.org> <20181013013200.206928-2-joel@joelfernandes.org> <20181024083716.GN3109@worktop.c.hoisthospitality.com> <20181025104703.esl6wxyg2ihe4zoc@kshutemo-mobl1> Message-ID: <20181026085047.GB3109@worktop.c.hoisthospitality.com> To: linux-riscv@lists.infradead.org List-Id: linux-riscv.lists.infradead.org On Thu, Oct 25, 2018 at 01:47:03PM +0300, Kirill A. Shutemov wrote: > On Wed, Oct 24, 2018 at 10:37:16AM +0200, Peter Zijlstra wrote: > > On Fri, Oct 12, 2018 at 06:31:57PM -0700, Joel Fernandes (Google) wrote: > > > This series speeds up mremap(2) syscall by copying page tables at the > > > PMD level even for non-THP systems. There is concern that the extra > > > 'address' argument that mremap passes to pte_alloc may do something > > > subtle architecture related in the future that may make the scheme not > > > work. Also we find that there is no point in passing the 'address' to > > > pte_alloc since its unused. So this patch therefore removes this > > > argument tree-wide resulting in a nice negative diff as well. Also > > > ensuring along the way that the enabled architectures do not do anything > > > funky with 'address' argument that goes unnoticed by the optimization. > > > > Did you happen to look at the history of where that address argument > > came from? -- just being curious here. ISTR something vague about > > architectures having different paging structure for different memory > > ranges. > > I see some archicetures (i.e. sparc and, I believe power) used the address > for coloring. It's not needed anymore. Page allocator and SL?B are good > enough now. > > See 3c936465249f ("[SPARC64]: Kill pgtable quicklists and use SLAB.") Ah, shiny. Thanks. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76AB3C6786E for ; Fri, 26 Oct 2018 08:56:26 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 436C920834 for ; Fri, 26 Oct 2018 08:56:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="lTogTAIv"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="DPhftbox" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 436C920834 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DSGdF6/iMXAfO2LNryt6tw4ux5kPprgiztoremF+SPM=; b=lTogTAIvogh7oR uJzuk6mbTmGcS8PCUIUC9SLt0BrKBjBdQwM947mtOq7aQ/nAUk33tqjYb6M/Semj1XcYUrOnbc0IV WI9qvlc7c8EFpdiwsjP9bj5UP9Aez7kinRADiptx3phu/ES0svcIma7ndEqeWhRts/EEjqr98wj3W HnkfBHwqJhnUs5UWrSinA7kRuyUPZn9Bi4/FwggICpnjBSx2OXuMEoE7+7483DjN2u1EJvJ4Wh9/f ixp629Jr1hGktyz9YvaGFEEnoQA8N3WGt6qWA/vpxFlk14i7JwKrL3WscMp/35fNO8/1Kuw4/bdiT LtTkISxpS5Rm9olBQUNg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gFxup-0005xs-B9; Fri, 26 Oct 2018 08:56:23 +0000 Received: from merlin.infradead.org ([2001:8b0:10b:1231::1]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gFxuo-0005xf-Kt; Fri, 26 Oct 2018 08:56:22 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=t4U6dJOCnA0c/EZV0nmuSLy/HD8d4dYO3ZonI67d8Vk=; b=DPhftboxJNVK8gljOSI9ek+lk cu0xqt1kC5w7yCxw6Jsznw1tHw2bNfFS/B99G90XrfF2EouGTY+fnjyh2fFe8Ea4pm+LfBzpKsORm vHKSHxTajvN1zlzwJSY3IQRIoUSjK9Ks0EaN70/cGAc3V1cVwVubUjQU8B8T3dcCN+Cny2z4IXEkf 5989+J/lbf4qCCiiXPFuktGNapnha5La8DRY2VrXPeyZAvzLzZFAr0KwXyN2xKeaZefS1TlUOUz9Q v3E0AoVoDPrDe463fQg0erQi1phVVaaGU+vviNvYVqHIgoubM4nIzXXBkEBYhhWFO095CIUsfkQj8 Onm8/N6Lg==; Received: from [167.98.65.38] (helo=worktop) by merlin.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1gFxuk-00012P-H7; Fri, 26 Oct 2018 08:56:18 +0000 Received: by worktop (Postfix, from userid 1000) id 7F67E6E07BE; Fri, 26 Oct 2018 10:50:47 +0200 (CEST) Date: Fri, 26 Oct 2018 10:50:47 +0200 From: Peter Zijlstra To: "Kirill A. Shutemov" Subject: Re: [PATCH 1/4] treewide: remove unused address argument from pte_alloc functions (v2) Message-ID: <20181026085047.GB3109@worktop.c.hoisthospitality.com> References: <20181013013200.206928-1-joel@joelfernandes.org> <20181013013200.206928-2-joel@joelfernandes.org> <20181024083716.GN3109@worktop.c.hoisthospitality.com> <20181025104703.esl6wxyg2ihe4zoc@kshutemo-mobl1> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20181025104703.esl6wxyg2ihe4zoc@kshutemo-mobl1> User-Agent: Mutt/1.5.22.1 (2013-10-16) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-mips@linux-mips.org, Rich Felker , linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org, Catalin Marinas , Dave Hansen , Will Deacon , Michal Hocko , linux-mm@kvack.org, lokeshgidra@google.com, "Joel Fernandes \(Google\)" , linux-riscv@lists.infradead.org, elfring@users.sourceforge.net, Jonas Bonn , kvmarm@lists.cs.columbia.edu, dancol@google.com, Yoshinori Sato , sparclinux@vger.kernel.org, linux-xtensa@linux-xtensa.org, linux-hexagon@vger.kernel.org, Helge Deller , "maintainer:X86 ARCHITECTURE \(32-BIT AND 64-BIT\)" , hughd@google.com, "James E.J. Bottomley" , kasan-dev@googlegroups.com, anton.ivanov@kot-begemot.co.uk, Ingo Molnar , Geert Uytterhoeven , Andrey Ryabinin , linux-snps-arc@lists.infradead.org, kernel-team@android.com, Sam Creasey , Fenghua Yu , linux-s390@vger.kernel.org, Jeff Dike , linux-um@lists.infradead.org, Stefan Kristiansson , Julia Lawall , linux-m68k@lists.linux-m68k.org, Borislav Petkov , Andy Lutomirski , nios2-dev@lists.rocketboards.org, Stafford Horne , Guan Xuetao , Chris Zankel , Tony Luck , Richard Weinberger , linux-parisc@vger.kernel.org, Max Filippov , pantin@google.com, linux-kernel@vger.kernel.org, minchan@kernel.org, Thomas Gleixner , linux-alpha@vger.kernel.org, Ley Foon Tan , akpm@linux-foundation.org, linuxppc-dev@lists.ozlabs.org, "David S. Miller" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org Message-ID: <20181026085047.vISFQP7No54BU4ixiQ2u-1XFgKgqW0tQf9fXjcKQj60@z> On Thu, Oct 25, 2018 at 01:47:03PM +0300, Kirill A. Shutemov wrote: > On Wed, Oct 24, 2018 at 10:37:16AM +0200, Peter Zijlstra wrote: > > On Fri, Oct 12, 2018 at 06:31:57PM -0700, Joel Fernandes (Google) wrote: > > > This series speeds up mremap(2) syscall by copying page tables at the > > > PMD level even for non-THP systems. There is concern that the extra > > > 'address' argument that mremap passes to pte_alloc may do something > > > subtle architecture related in the future that may make the scheme not > > > work. Also we find that there is no point in passing the 'address' to > > > pte_alloc since its unused. So this patch therefore removes this > > > argument tree-wide resulting in a nice negative diff as well. Also > > > ensuring along the way that the enabled architectures do not do anything > > > funky with 'address' argument that goes unnoticed by the optimization. > > > > Did you happen to look at the history of where that address argument > > came from? -- just being curious here. ISTR something vague about > > architectures having different paging structure for different memory > > ranges. > > I see some archicetures (i.e. sparc and, I believe power) used the address > for coloring. It's not needed anymore. Page allocator and SL?B are good > enough now. > > See 3c936465249f ("[SPARC64]: Kill pgtable quicklists and use SLAB.") Ah, shiny. Thanks. _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25051C6786E for ; Fri, 26 Oct 2018 08:59:45 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7E53A20834 for ; Fri, 26 Oct 2018 08:59:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="DPhftbox" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7E53A20834 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 42hHxV2fR4zF3H1 for ; Fri, 26 Oct 2018 19:59:42 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=infradead.org header.i=@infradead.org header.b="DPhftbox"; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=none (mailfrom) smtp.mailfrom=infradead.org (client-ip=2001:8b0:10b:1231::1; helo=merlin.infradead.org; envelope-from=peterz@infradead.org; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=infradead.org header.i=@infradead.org header.b="DPhftbox"; dkim-atps=neutral Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:8b0:10b:1231::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 42hHtz0PRdzDqCH for ; Fri, 26 Oct 2018 19:57:30 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=t4U6dJOCnA0c/EZV0nmuSLy/HD8d4dYO3ZonI67d8Vk=; b=DPhftboxJNVK8gljOSI9ek+lk cu0xqt1kC5w7yCxw6Jsznw1tHw2bNfFS/B99G90XrfF2EouGTY+fnjyh2fFe8Ea4pm+LfBzpKsORm vHKSHxTajvN1zlzwJSY3IQRIoUSjK9Ks0EaN70/cGAc3V1cVwVubUjQU8B8T3dcCN+Cny2z4IXEkf 5989+J/lbf4qCCiiXPFuktGNapnha5La8DRY2VrXPeyZAvzLzZFAr0KwXyN2xKeaZefS1TlUOUz9Q v3E0AoVoDPrDe463fQg0erQi1phVVaaGU+vviNvYVqHIgoubM4nIzXXBkEBYhhWFO095CIUsfkQj8 Onm8/N6Lg==; Received: from [167.98.65.38] (helo=worktop) by merlin.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1gFxuk-00012P-H7; Fri, 26 Oct 2018 08:56:18 +0000 Received: by worktop (Postfix, from userid 1000) id 7F67E6E07BE; Fri, 26 Oct 2018 10:50:47 +0200 (CEST) Date: Fri, 26 Oct 2018 10:50:47 +0200 From: Peter Zijlstra To: "Kirill A. Shutemov" Subject: Re: [PATCH 1/4] treewide: remove unused address argument from pte_alloc functions (v2) Message-ID: <20181026085047.GB3109@worktop.c.hoisthospitality.com> References: <20181013013200.206928-1-joel@joelfernandes.org> <20181013013200.206928-2-joel@joelfernandes.org> <20181024083716.GN3109@worktop.c.hoisthospitality.com> <20181025104703.esl6wxyg2ihe4zoc@kshutemo-mobl1> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181025104703.esl6wxyg2ihe4zoc@kshutemo-mobl1> User-Agent: Mutt/1.5.22.1 (2013-10-16) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-mips@linux-mips.org, Rich Felker , linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org, Catalin Marinas , Dave Hansen , Will Deacon , Michal Hocko , linux-mm@kvack.org, lokeshgidra@google.com, "Joel Fernandes \(Google\)" , linux-riscv@lists.infradead.org, elfring@users.sourceforge.net, Jonas Bonn , kvmarm@lists.cs.columbia.edu, dancol@google.com, Yoshinori Sato , sparclinux@vger.kernel.org, linux-xtensa@linux-xtensa.org, linux-hexagon@vger.kernel.org, Helge Deller , "maintainer:X86 ARCHITECTURE \(32-BIT AND 64-BIT\)" , hughd@google.com, "James E.J. Bottomley" , kasan-dev@googlegroups.com, anton.ivanov@kot-begemot.co.uk, Ingo Molnar , Geert Uytterhoeven , Andrey Ryabinin , linux-snps-arc@lists.infradead.org, kernel-team@android.com, Sam Creasey , Fenghua Yu , linux-s390@vger.kernel.org, Jeff Dike , linux-um@lists.infradead.org, Stefan Kristiansson , Julia Lawall , linux-m68k@lists.linux-m68k.org, Borislav Petkov , Andy Lutomirski , nios2-dev@lists.rocketboards.org, Stafford Horne , Guan Xuetao , Chris Zankel , Tony Luck , Richard Weinberger , linux-parisc@vger.kernel.org, Max Filippov , pantin@google.com, linux-kernel@vger.kernel.org, minchan@kernel.org, Thomas Gleixner , linux-alpha@vger.kernel.org, Ley Foon Tan , akpm@linux-foundation.org, linuxppc-dev@lists.ozlabs.org, "David S. Miller" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Thu, Oct 25, 2018 at 01:47:03PM +0300, Kirill A. Shutemov wrote: > On Wed, Oct 24, 2018 at 10:37:16AM +0200, Peter Zijlstra wrote: > > On Fri, Oct 12, 2018 at 06:31:57PM -0700, Joel Fernandes (Google) wrote: > > > This series speeds up mremap(2) syscall by copying page tables at the > > > PMD level even for non-THP systems. There is concern that the extra > > > 'address' argument that mremap passes to pte_alloc may do something > > > subtle architecture related in the future that may make the scheme not > > > work. Also we find that there is no point in passing the 'address' to > > > pte_alloc since its unused. So this patch therefore removes this > > > argument tree-wide resulting in a nice negative diff as well. Also > > > ensuring along the way that the enabled architectures do not do anything > > > funky with 'address' argument that goes unnoticed by the optimization. > > > > Did you happen to look at the history of where that address argument > > came from? -- just being curious here. ISTR something vague about > > architectures having different paging structure for different memory > > ranges. > > I see some archicetures (i.e. sparc and, I believe power) used the address > for coloring. It's not needed anymore. Page allocator and SL?B are good > enough now. > > See 3c936465249f ("[SPARC64]: Kill pgtable quicklists and use SLAB.") Ah, shiny. Thanks. From mboxrd@z Thu Jan 1 00:00:00 1970 From: peterz@infradead.org (Peter Zijlstra) Date: Fri, 26 Oct 2018 10:50:47 +0200 Subject: [PATCH 1/4] treewide: remove unused address argument from pte_alloc functions (v2) In-Reply-To: <20181025104703.esl6wxyg2ihe4zoc@kshutemo-mobl1> References: <20181013013200.206928-1-joel@joelfernandes.org> <20181013013200.206928-2-joel@joelfernandes.org> <20181024083716.GN3109@worktop.c.hoisthospitality.com> <20181025104703.esl6wxyg2ihe4zoc@kshutemo-mobl1> List-ID: Message-ID: <20181026085047.GB3109@worktop.c.hoisthospitality.com> To: linux-snps-arc@lists.infradead.org On Thu, Oct 25, 2018@01:47:03PM +0300, Kirill A. Shutemov wrote: > On Wed, Oct 24, 2018@10:37:16AM +0200, Peter Zijlstra wrote: > > On Fri, Oct 12, 2018@06:31:57PM -0700, Joel Fernandes (Google) wrote: > > > This series speeds up mremap(2) syscall by copying page tables at the > > > PMD level even for non-THP systems. There is concern that the extra > > > 'address' argument that mremap passes to pte_alloc may do something > > > subtle architecture related in the future that may make the scheme not > > > work. Also we find that there is no point in passing the 'address' to > > > pte_alloc since its unused. So this patch therefore removes this > > > argument tree-wide resulting in a nice negative diff as well. Also > > > ensuring along the way that the enabled architectures do not do anything > > > funky with 'address' argument that goes unnoticed by the optimization. > > > > Did you happen to look at the history of where that address argument > > came from? -- just being curious here. ISTR something vague about > > architectures having different paging structure for different memory > > ranges. > > I see some archicetures (i.e. sparc and, I believe power) used the address > for coloring. It's not needed anymore. Page allocator and SL?B are good > enough now. > > See 3c936465249f ("[SPARC64]: Kill pgtable quicklists and use SLAB.") Ah, shiny. Thanks. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Zijlstra Subject: Re: [PATCH 1/4] treewide: remove unused address argument from pte_alloc functions (v2) Date: Fri, 26 Oct 2018 10:50:47 +0200 Message-ID: <20181026085047.GB3109@worktop.c.hoisthospitality.com> References: <20181013013200.206928-1-joel@joelfernandes.org> <20181013013200.206928-2-joel@joelfernandes.org> <20181024083716.GN3109@worktop.c.hoisthospitality.com> <20181025104703.esl6wxyg2ihe4zoc@kshutemo-mobl1> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DSGdF6/iMXAfO2LNryt6tw4ux5kPprgiztoremF+SPM=; b=lTogTAIvogh7oR uJzuk6mbTmGcS8PCUIUC9SLt0BrKBjBdQwM947mtOq7aQ/nAUk33tqjYb6M/Semj1XcYUrOnbc0IV WI9qvlc7c8EFpdiwsjP9bj5UP9Aez7kinRADiptx3phu/ES0svcIma7ndEqeWhRts/EEjqr98wj3W HnkfBHwqJhnUs5UWrSinA7kRuyUPZn9Bi4/FwggICpnjBSx2OXuMEoE7+7483DjN2u1EJvJ4Wh9/f ixp629Jr1hGktyz9YvaGFEEnoQA8N3WGt6qWA/vpxFlk14i7JwKrL3WscMp/35fNO8/1Kuw4/bdiT LtTkISxpS5Rm9olBQUNg==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=t4U6dJOCnA0c/EZV0nmuSLy/HD8d4dYO3ZonI67d8Vk=; b=DPhftboxJNVK8gljOSI9ek+lk cu0xqt1kC5w7yCxw6Jsznw1tHw2bNfFS/B99G90XrfF2EouGTY+fnjyh2fFe8Ea4pm+LfBzpKsORm vHKSHxTajvN1zlzwJSY3IQRIoUSjK9Ks0EaN70/cGAc3V1cVwVubUjQU8B8T3dcCN+Cny2z4IXEkf 5989+J/lbf4qCCiiXPFuktGNapnha5La8DRY2VrXPeyZAvzLzZFAr0KwXyN2xKeaZefS1TlUOUz9Q v3E0AoVoDPrDe463fQg0erQi1phVVaaGU+vviNvYVqHIgoubM4nIzXXBkEBYhhWFO095CIUsfkQj8 Onm8/N6Lg==; Content-Disposition: inline In-Reply-To: <20181025104703.esl6wxyg2ihe4zoc@kshutemo-mobl1> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-riscv" Errors-To: linux-riscv-bounces+glpr-linux-riscv=m.gmane.org@lists.infradead.org To: "Kirill A. Shutemov" Cc: linux-mips@linux-mips.org, Rich Felker , linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org, Catalin Marinas , Dave Hansen , Will Deacon , Michal Hocko , linux-mm@kvack.org, lokeshgidra@google.com, "Joel Fernandes (Google)" , linux-riscv@lists.infradead.org, elfring@users.sourceforge.net, Jonas Bonn , kvmarm@lists.cs.columbia.edu, dancol@google.com, Yoshinori Sato , sparclinux@vger.kernel.org, linux-xtensa@linux-xtensa.org, linux-hexagon@vger.kernel.org, Helge Deller , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , hughd@google.com, "James E.J. Bottomley" , kasan-dev@googlegroups.com, anton.ivanov@kot-begemot.co.uk, Ingo On Thu, Oct 25, 2018 at 01:47:03PM +0300, Kirill A. Shutemov wrote: > On Wed, Oct 24, 2018 at 10:37:16AM +0200, Peter Zijlstra wrote: > > On Fri, Oct 12, 2018 at 06:31:57PM -0700, Joel Fernandes (Google) wrote: > > > This series speeds up mremap(2) syscall by copying page tables at the > > > PMD level even for non-THP systems. There is concern that the extra > > > 'address' argument that mremap passes to pte_alloc may do something > > > subtle architecture related in the future that may make the scheme not > > > work. Also we find that there is no point in passing the 'address' to > > > pte_alloc since its unused. So this patch therefore removes this > > > argument tree-wide resulting in a nice negative diff as well. Also > > > ensuring along the way that the enabled architectures do not do anything > > > funky with 'address' argument that goes unnoticed by the optimization. > > > > Did you happen to look at the history of where that address argument > > came from? -- just being curious here. ISTR something vague about > > architectures having different paging structure for different memory > > ranges. > > I see some archicetures (i.e. sparc and, I believe power) used the address > for coloring. It's not needed anymore. Page allocator and SL?B are good > enough now. > > See 3c936465249f ("[SPARC64]: Kill pgtable quicklists and use SLAB.") Ah, shiny. Thanks. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Fri, 26 Oct 2018 10:50:47 +0200 From: Peter Zijlstra Subject: Re: [PATCH 1/4] treewide: remove unused address argument from pte_alloc functions (v2) Message-ID: <20181026085047.GB3109@worktop.c.hoisthospitality.com> References: <20181013013200.206928-1-joel@joelfernandes.org> <20181013013200.206928-2-joel@joelfernandes.org> <20181024083716.GN3109@worktop.c.hoisthospitality.com> <20181025104703.esl6wxyg2ihe4zoc@kshutemo-mobl1> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20181025104703.esl6wxyg2ihe4zoc@kshutemo-mobl1> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: "Kirill A. Shutemov" Cc: linux-mips@linux-mips.org, Rich Felker , linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org, Catalin Marinas , Dave Hansen , Will Deacon , Michal Hocko , linux-mm@kvack.org, lokeshgidra@google.com, "Joel Fernandes (Google)" , linux-riscv@lists.infradead.org, elfring@users.sourceforge.net, Jonas Bonn , kvmarm@lists.cs.columbia.edu, dancol@google.com, Yoshinori Sato , sparclinux@vger.kernel.org, linux-xtensa@linux-xtensa.org, linux-hexagon@vger.kernel.org, Helge Deller , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , hughd@google.com, "James E.J. Bottomley" , kasan-dev@googlegroups.com, anton.ivanov@kot-begemot.co.uk, Ingo Molnar , Geert Uytterhoeven , Andrey Ryabinin , linux-snps-arc@lists.infradead.org, kernel-team@android.com, Sam Creasey , Fenghua Yu , linux-s390@vger.kernel.org, Jeff Dike , linux-um@lists.infradead.org, Stefan Kristiansson , Julia Lawall , linux-m68k@lists.linux-m68k.org, Borislav Petkov , Andy Lutomirski , nios2-dev@lists.rocketboards.org, Stafford Horne , Guan Xuetao , Chris Zankel , Tony Luck , Richard Weinberger , linux-parisc@vger.kernel.org, Max Filippov , pantin@google.com, linux-kernel@vger.kernel.org, minchan@kernel.org, Thomas Gleixner , linux-alpha@vger.kernel.org, Ley Foon Tan , akpm@linux-foundation.org, linuxppc-dev@lists.ozlabs.org, "David S. Miller" On Thu, Oct 25, 2018 at 01:47:03PM +0300, Kirill A. Shutemov wrote: > On Wed, Oct 24, 2018 at 10:37:16AM +0200, Peter Zijlstra wrote: > > On Fri, Oct 12, 2018 at 06:31:57PM -0700, Joel Fernandes (Google) wrote: > > > This series speeds up mremap(2) syscall by copying page tables at the > > > PMD level even for non-THP systems. There is concern that the extra > > > 'address' argument that mremap passes to pte_alloc may do something > > > subtle architecture related in the future that may make the scheme not > > > work. Also we find that there is no point in passing the 'address' to > > > pte_alloc since its unused. So this patch therefore removes this > > > argument tree-wide resulting in a nice negative diff as well. Also > > > ensuring along the way that the enabled architectures do not do anything > > > funky with 'address' argument that goes unnoticed by the optimization. > > > > Did you happen to look at the history of where that address argument > > came from? -- just being curious here. ISTR something vague about > > architectures having different paging structure for different memory > > ranges. > > I see some archicetures (i.e. sparc and, I believe power) used the address > for coloring. It's not needed anymore. Page allocator and SL?B are good > enough now. > > See 3c936465249f ("[SPARC64]: Kill pgtable quicklists and use SLAB.") Ah, shiny. Thanks. _______________________________________________ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um