All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: Pavel Machek <pavel@ucw.cz>
Cc: stable@vger.kernel.org, linux-kernel@vger.kernel.org,
	Daniel Drake <drake@endlessm.com>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>
Subject: Re: [PATCH AUTOSEL 4.14 03/15] Input: i8042 - enable keyboard wakeups by default when s2idle is used
Date: Fri, 26 Oct 2018 06:56:20 -0400	[thread overview]
Message-ID: <20181026105620.GC2015@sasha-vm> (raw)
In-Reply-To: <20181026090452.GB20200@amd>

On Fri, Oct 26, 2018 at 11:04:52AM +0200, Pavel Machek wrote:
>On Mon 2018-10-22 06:20:14, Sasha Levin wrote:
>> From: Daniel Drake <drake@endlessm.com>
>>
>> [ Upstream commit 684bec1092b6991ff2a7751e8a763898576eb5c2 ]
>>
>> Previously, on typical consumer laptops, pressing a key on the keyboard
>> when the system is in suspend would cause it to wake up (default or
>> unconditional behaviour). This happens because the EC generates a SCI
>> interrupt in this scenario.
>>
>> That is no longer true on modern laptops based on Intel WhiskeyLake,
>> including Acer Swift SF314-55G, Asus UX333FA, Asus UX433FN and Asus
>> UX533FD. We confirmed with Asus EC engineers that the "Modern Standby"
>> design has been modified so that the EC no longer generates a SCI
>> in this case; the keyboard controller itself should be used for wakeup.
>>
>> In order to retain the standard behaviour of being able to use the
>> keyboard to wake up the system, enable serio wakeups by default on
>> platforms that are using s2idle.
>
>Behaviour change, not a bugfix. Someone may like their laptop sleeping
>after keypress, we should not change it in the middle of -stable
>series.

Dmitry already asked for it to be dropped, so it's gone.

--
Thanks,
Sasha

  reply	other threads:[~2018-10-26 10:56 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-22 10:20 [PATCH AUTOSEL 4.14 01/15] ARM: dts: imx53-qsb: disable 1.2GHz OPP Sasha Levin
2018-10-22 10:20 ` [PATCH AUTOSEL 4.14 02/15] s390/hibernate: fix error handling when suspend cpu != resume cpu Sasha Levin
2018-10-26  9:05   ` Pavel Machek
2018-10-26  9:22     ` Greg KH
2018-10-26 10:15       ` Pavel Machek
2018-10-26 11:09         ` Sasha Levin
2018-10-26 12:18           ` Gerald Schaefer
2018-10-22 10:20 ` [PATCH AUTOSEL 4.14 03/15] Input: i8042 - enable keyboard wakeups by default when s2idle is used Sasha Levin
2018-10-26  9:04   ` Pavel Machek
2018-10-26 10:56     ` Sasha Levin [this message]
2018-10-22 10:20 ` [PATCH AUTOSEL 4.14 04/15] Input: mousedev - add a schedule point in mousedev_write() Sasha Levin
2018-10-22 10:20 ` [PATCH AUTOSEL 4.14 05/15] perf python: Use -Wno-redundant-decls to build with PYTHON=python3 Sasha Levin
2018-10-22 10:20 ` [PATCH AUTOSEL 4.14 06/15] Input: evdev - add a schedule point in evdev_write() Sasha Levin
2018-10-22 10:20 ` [PATCH AUTOSEL 4.14 07/15] Input: uinput - add a schedule point in uinput_inject_events() Sasha Levin
2018-10-22 10:20 ` [PATCH AUTOSEL 4.14 08/15] rxrpc: Don't check RXRPC_CALL_TX_LAST after calling rxrpc_rotate_tx_window() Sasha Levin
2018-10-22 10:20 ` [PATCH AUTOSEL 4.14 09/15] rxrpc: Only take the rwind and mtu values from latest ACK Sasha Levin
2018-10-22 10:20 ` [PATCH AUTOSEL 4.14 10/15] rxrpc: Fix connection-level abort handling Sasha Levin
2018-10-22 10:20 ` [PATCH AUTOSEL 4.14 11/15] net: ena: fix warning in rmmod caused by double iounmap Sasha Levin
2018-10-22 10:20 ` [PATCH AUTOSEL 4.14 12/15] net: ena: fix NULL dereference due to untimely napi initialization Sasha Levin
2018-10-22 10:20 ` [PATCH AUTOSEL 4.14 13/15] libertas: call into generic suspend code before turning off power Sasha Levin
2018-10-22 10:20 ` [PATCH AUTOSEL 4.14 14/15] selftests: rtnetlink.sh explicitly requires bash Sasha Levin
2018-10-22 10:20 ` [PATCH AUTOSEL 4.14 15/15] fs/fat/fatent.c: add cond_resched() to fat_count_free_clusters() Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181026105620.GC2015@sasha-vm \
    --to=sashal@kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=drake@endlessm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.