From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [RFC PATCH] drm/vc4: Add a load tracker to prevent HVS underflow errors Date: Fri, 26 Oct 2018 15:30:26 +0200 Message-ID: <20181026133026.GM21967@phenom.ffwll.local> References: <20181016094045.23021-1-boris.brezillon@bootlin.com> <20181016125743.GZ31561@phenom.ffwll.local> <20181023095508.21a9cabd@bbrezillon> <20181023134443.GQ324@phenom.ffwll.local> <20181025100931.50fddf7e@bbrezillon> <20181025093314.GB21967@phenom.ffwll.local> <20181025114114.42caf97d@bbrezillon> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ed1-x544.google.com (mail-ed1-x544.google.com [IPv6:2a00:1450:4864:20::544]) by gabe.freedesktop.org (Postfix) with ESMTPS id B25DC89DE5 for ; Fri, 26 Oct 2018 13:30:30 +0000 (UTC) Received: by mail-ed1-x544.google.com with SMTP id b7-v6so1285809edd.9 for ; Fri, 26 Oct 2018 06:30:30 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20181025114114.42caf97d@bbrezillon> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Boris Brezillon Cc: "Hollingworth, Gordon" , dri-devel@lists.freedesktop.org, Eben Upton List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBPY3QgMjUsIDIwMTggYXQgMTE6NDE6MTRBTSArMDIwMCwgQm9yaXMgQnJlemlsbG9u IHdyb3RlOgo+IE9uIFRodSwgMjUgT2N0IDIwMTggMTE6MzM6MTQgKzAyMDAKPiBEYW5pZWwgVmV0 dGVyIDxkYW5pZWxAZmZ3bGwuY2g+IHdyb3RlOgo+IAo+ID4gT24gVGh1LCBPY3QgMjUsIDIwMTgg YXQgMTA6MDk6MzFBTSArMDIwMCwgQm9yaXMgQnJlemlsbG9uIHdyb3RlOgo+ID4gPiBPbiBUdWUs IDIzIE9jdCAyMDE4IDE1OjQ0OjQzICswMjAwCj4gPiA+IERhbmllbCBWZXR0ZXIgPGRhbmllbEBm ZndsbC5jaD4gd3JvdGU6Cj4gPiA+ICAgCj4gPiA+ID4gT24gVHVlLCBPY3QgMjMsIDIwMTggYXQg MDk6NTU6MDhBTSArMDIwMCwgQm9yaXMgQnJlemlsbG9uIHdyb3RlOiAgCj4gPiA+ID4gPiBIaSBE YW5pZWwsCj4gPiA+ID4gPiAKPiA+ID4gPiA+IE9uIFR1ZSwgMTYgT2N0IDIwMTggMTQ6NTc6NDMg KzAyMDAKPiA+ID4gPiA+IERhbmllbCBWZXR0ZXIgPGRhbmllbEBmZndsbC5jaD4gd3JvdGU6Cj4g PiA+ID4gPiAgICAgCj4gPiA+ID4gPiA+IE9uIFR1ZSwgT2N0IDE2LCAyMDE4IGF0IDExOjQwOjQ1 QU0gKzAyMDAsIEJvcmlzIEJyZXppbGxvbiB3cm90ZTogICAgCj4gPiA+ID4gPiA+ID4gVGhlIEhW UyBibG9jayBpcyBzdXBwb3NlZCB0byBmaWxsIHRoZSBwaXhlbHZhbHZlIEZJRk9zIGZhc3QgZW5v dWdoIHRvCj4gPiA+ID4gPiA+ID4gbWVldCB0aGUgcmVxdWVzdGVkIGZyYW1lcmF0ZS4gVGhlIHBy b2JsZW0gaXMsIHRoZSBIVlMgYW5kIG1lbW9yeSBidXMKPiA+ID4gPiA+ID4gPiBiYW5kd2lkdGhz IGFyZSBsaW1pdGVkLCBhbmQgaWYgd2UgZG9uJ3QgdGFrZSB0aGVzZSBsaW1pdGF0aW9ucyBpbnRv Cj4gPiA+ID4gPiA+ID4gYWNjb3VudCB3ZSBtaWdodCBlbmQgdXAgd2l0aCBIVlMgdW5kZXJmbG93 IGVycm9ycy4KPiA+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4gPiBUaGlzIHBhdGNoIGlzIHRyeWlu ZyB0byBtb2RlbCB0aGUgcGVyLXBsYW5lIEhWUyBhbmQgbWVtb3J5IGJ1cyBiYW5kd2lkdGgKPiA+ ID4gPiA+ID4gPiBjb25zdW1wdGlvbiBhbmQgdGFrZSBhIGRlY2lzaW9uIGF0IGF0b21pY19jaGVj aygpIHRpbWUgd2hldGhlciB0aGUKPiA+ID4gPiA+ID4gPiBlc3RpbWF0ZWQgbG9hZCB3aWxsIGZp dCBpbiB0aGUgSFZTIGFuZCBtZW1idXMgYnVkZ2V0Lgo+ID4gPiA+ID4gPiA+IAo+ID4gPiA+ID4g PiA+IE5vdGUgdGhhdCB3ZSB0YWtlIGFuIGV4dHJhIG1hcmdpbiBvbiB0aGUgbWVtb3J5IGJ1cyBj b25zdW1wdGlvbiB0byBsZXQKPiA+ID4gPiA+ID4gPiB0aGUgc3lzdGVtIHJ1biBzbW9vdGhseSB3 aGVuIG90aGVyIGJsb2NrcyBhcmUgZG9pbmcgaGVhdnkgdXNlIG9mIHRoZQo+ID4gPiA+ID4gPiA+ IG1lbW9yeSBidXMuIFNhbWUgZ29lcyBmb3IgdGhlIEhWUyBsaW1pdCwgZXhjZXB0IHRoZSBtYXJn aW4gaXMgc21hbGxlciBpbgo+ID4gPiA+ID4gPiA+IHRoaXMgY2FzZSwgc2luY2UgdGhlIEhWUyBp cyBub3QgdXNlZCBieSBleHRlcm5hbCBjb21wb25lbnRzLgo+ID4gPiA+ID4gPiA+IAo+ID4gPiA+ ID4gPiA+IFNpZ25lZC1vZmYtYnk6IEJvcmlzIEJyZXppbGxvbiA8Ym9yaXMuYnJlemlsbG9uQGJv b3RsaW4uY29tPgo+ID4gPiA+ID4gPiA+IC0tLQo+ID4gPiA+ID4gPiA+IFRoaXMgbG9naWMgaGFz IGJlZW4gdmFsaWRhdGVkIHVzaW5nIGEgc2ltcGxlIHNoZWxsIHNjcmlwdCBhbmQKPiA+ID4gPiA+ ID4gPiBzb21lIGluc3RydW1lbnRhdGlvbiBpbiB0aGUgVkM0IGRyaXZlcjoKPiA+ID4gPiA+ID4g PiAKPiA+ID4gPiA+ID4gPiAtIGNhcHR1cmUgdW5kZXJmbG93IGVycm9ycyBhdCB0aGUgSFZTIGxl dmVsIGFuZCBleHBvc2UgYSBkZWJ1Z2ZzIGZpbGUKPiA+ID4gPiA+ID4gPiAgIHJlcG9ydGluZyB0 aG9zZSBlcnJvcnMKPiA+ID4gPiA+ID4gPiAtIGFkZCBkZWJ1Z2ZzIGZpbGVzIHRvIGV4cG9zZSB3 aGVuIGF0b21pY19jaGVjayBmYWlscyBiZWNhdXNlIG9mIHRoZQo+ID4gPiA+ID4gPiA+ICAgSFZT IG9yIG1lbWJ1cyBsb2FkIGxpbWl0YXRpb24gb3Igd2hlbiBpdCBmYWlscyBmb3Igb3RoZXIgcmVh c29ucwo+ID4gPiA+ID4gPiA+IAo+ID4gPiA+ID4gPiA+IFRoZSBicmFuY2ggY29udGFpbmluZyB0 aG9zZSBtb2RpZmljYXRpb24gaXMgYXZhaWxhYmxlIGhlcmUgWzFdLCBhbmQgdGhlCj4gPiA+ID4g PiA+ID4gc2NyaXB0ICh3aGljaCBpcyBpbnRlcm5hbGx5IHVzaW5nIG1vZGV0ZXN0KSBpcyBoZXJl IFsyXSAocGxlYXNlIG5vdGUKPiA+ID4gPiA+ID4gPiB0aGF0IEknbSBiYWQgYXQgd3JpdGluZyBz aGVsbCBzY3JpcHRzIDotKSkuCj4gPiA+ID4gPiA+ID4gCj4gPiA+ID4gPiA+ID4gTm90ZSB0aGF0 IHRob3NlIG1vZGlmaWNhdGlvbiB0ZW5kIHRvIG92ZXItZXN0aW1hdGUgdGhlIGxvYWQsIGFuZCB0 aHVzCj4gPiA+ID4gPiA+ID4gcmVqZWN0IHNldHVwcyB0aGF0IG1pZ2h0IGhhdmUgcHJldmlvdXNs eSB3b3JrZWQsIHNvIHdlIG1pZ2h0IHdhbnQgdG8KPiA+ID4gPiA+ID4gPiBhZGp1c3QgdGhlIGxp bWl0cyB0byBhdm9pZCB0aGF0Lgo+ID4gPiA+ID4gPiA+IAo+ID4gPiA+ID4gPiA+IFsxXWh0dHBz Oi8vZ2l0aHViLmNvbS9iYnJlemlsbG9uL2xpbnV4L3RyZWUvdmM0L2h2cy1iYW5kd2lkdGgtZXZh bAo+ID4gPiA+ID4gPiA+IFsyXWh0dHBzOi8vZ2l0aHViLmNvbS9iYnJlemlsbG9uL3ZjNC1odnMt YmFuZHdpZHRoLXRlc3QgICAgICAKPiA+ID4gPiA+ID4gCj4gPiA+ID4gPiA+IEFueSBpbnRlcmVz dCBpbiB1c2luZyBpZ3QgdG8gdGVzdCB0aGlzIHN0dWZmPyBXZSBoYXZlIGF0IGxlYXN0IGEgYnVu Y2ggb2YKPiA+ID4gPiA+ID4gdGVzdHMgYWxyZWFkeSBpbiB0aGVyZSB0aGF0IHRyeSBhbGwga2lu ZHMgb2YgcGxhbmUgc2V0dXBzLiBBbmQgd2UgdXNlCj4gPiA+ID4gPiA+IHRob3NlIHRvIGh1bnQg Zm9yIHVuZGVycnVucyBvbiBpOTE1IGh3Lgo+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4gV3J0IHVu ZGVycnVuIHJlcG9ydGluZzogT24gaTkxNSB3ZSBqdXN0IGR1bXAgdGhlbSBpbnRvIGRtZXNnIGF0 IHRoZSBlcnJvcgo+ID4gPiA+ID4gPiBsZXZlbCwgdXNpbmcgRFJNX0VSUk9SLCAgICAKPiA+ID4g PiA+IAo+ID4gPiA+ID4gQXJlIHlvdSBtYXNraW5nIHRoZSB1bmRlcnJ1biBpbnRlcnJ1cHQgYWZ0 ZXIgaXQncyBiZWVuIHJlcG9ydGVkPyBJZiB3ZQo+ID4gPiA+ID4gZG9uJ3QgZG8gdGhhdCBvbiBW QzQgd2UganVzdCBlbmQgdXAgZmxvb2RpbmcgdGhlIGtlcm5lbC1sb2cgYnVmZmVyIHVudGlsCj4g PiA+ID4gPiBzb21lb25lIGNvbWVzIGFuZCB1cGRhdGUgdGhlIGNvbmZpZy4gICAgCj4gPiA+ID4g Cj4gPiA+ID4gWWVhaCB3ZSBkbyB0aGF0IHRvby4gUnVsZSBpcyB0aGF0IGEgZnVsbCBtb2Rlc2V0 IHdpbGwgY2xlYXIgYW55IHVuZGVycnVuCj4gPiA+ID4gbWFza2luZyAoc28gdGVzdHMgbmVlZCB0 byBtYWtlIHN1cmUgdGhleSBzdGFydCB3aXRoIGEgbW9kZXNldCwgb3IgaXQnbGwgYmUKPiA+ID4g PiBmb3Igbm90aGluZykuCj4gPiA+ID4gICAKPiA+ID4gPiA+ICAgICAKPiA+ID4gPiA+ID4gcGx1 cyBhIHRyYWNlcG9pbnQuIFNlZSBlLmcuCj4gPiA+ID4gPiA+IGludGVsX3BjaF9maWZvX3VuZGVy cnVuX2lycV9oYW5kbGVyKCkuIElmIHRoZXJlJ3MgaW50ZXJlc3Qgd2UgY291bGQKPiA+ID4gPiA+ ID4gcGVyaGFwcyBleHRyYWN0IHRoaXMgaW50byBzb21ldGhpbmcgY29tbW9uLCBzaW1pbGFyIHRv IHdoYXQgd2FzIGRvbmUgd2l0aAo+ID4gPiA+ID4gPiBjcmMgc3VwcG9ydCBhbHJlYWR5Lgo+ID4g PiA+ID4gPiAgICAgCj4gPiA+ID4gPiAKPiA+ID4gPiA+IEknbSBub3QgYSBiaWcgZmFuIG9mIGhh cmRjb2RlZCB0cmFjZSBwb2ludHMgaW4gZ2VuZXJhbCAoYmVjYXVzZSBvZiB0aGUKPiA+ID4gPiA+ IHdob2xlICJpdCdzIHBhcnQgb2YgdGhlIHN0YWJsZSBBQkkiIHRoaW5nKSwgYW5kIGluIHRoaXMg Y2FzZSwgbWFraW5nIHRoZQo+ID4gPiA+ID4gdHJhY2Vwb2ludCBnZW5lcmljIHNvdW5kcyBldmVu IG1vcmUgcmlza3kgdG8gbWUuIEluZGVlZCwgaG93IGNhbiB3ZSBrbm93Cj4gPiA+ID4gPiBhYm91 dCBhbGwgdGhlIEhXIHNwZWNpZmljIGJpdHMgb25lIG1pZ2h0IHdhbnQgdG8gZXhwb3NlLiBGb3Ig aW5zdGFuY2UsCj4gPiA+ID4gPiBJIHNlZSB0aGUgaW50ZWwgdW5kZXJydW4gdHJhY2Vwb2ludCBl eHBvc2VzIGEgc3RydWN0IHdpdGggYSBmcmFtZSBhbmQKPiA+ID4gPiA+IHNjYW5saW5lIGZpZWxk LCBhbmQgQUZBSUNULCB3ZSBkb24ndCBoYXZlIHN1Y2ggaW5mb3JtYXRpb24gaW4gdGhlIFZDNAo+ ID4gPiA+ID4gY2FzZS4KPiA+ID4gPiA+IAo+ID4gPiA+ID4gQW55IG9waW5pb24gb24gdGhhdD8g ICAgCj4gPiA+ID4gCj4gPiA+ID4gSXQncyBvbmx5IGFiaSBpZiB5b3UncmUgdW5sdWNreS4gSWYg aXQncyBqdXN0IGZvciBkZWJ1Z2dpbmcgYW5kCj4gPiA+ID4gdmFsaWRhdGlvbiwgeW91IGNhbiBj aGFuZ2UgaXQgYWdhaW4uIFRiaCwgbm8gaWRlYSB3aHkgd2UgZXZlbiBoYXZlIHRoZXNlCj4gPiA+ ID4gdHJhY2Vwb2ludHMsIHRoZXkncmUgZmFpcmx5IHVzZWxlc3MgaW1vLiBDSSBvbmx5IHJlbGll cyB1cG9uIHRoZSBkbWVzZwo+ID4gPiA+IG91dHB1dC4gTWF5YmUgcnVuIGdpdCBibGFtZSBhbmQg YXNrIHRoZSBvcmlnaW5hbCBhdXRob3IsIHdlIGNhbiBwcm9iYWJseQo+ID4gPiA+IHVwZGF0ZSB0 aGVtIHRvIHN1aXQgb3VyIG5lZWRzLiAgCj4gPiA+IAo+ID4gPiBPa2F5LCBJIHRoaW5rIEknbGwg Z28gZm9yIGEgZ2VuZXJpYyBkZWJ1Z2ZzIGVudHJ5IHRoYXQgcmV0dXJucyB0cnVlCj4gPiA+IHdo ZW4gYW4gdW5kZXJydW4gZXJyb3IgaGFwcGVuZWQgc2luY2UgdGhlIGxhc3QgbW9kZXNldCwgZmFs c2Ugb3RoZXJ3aXNlLgo+ID4gPiAKPiA+ID4gTmV4dCBxdWVzdGlvbiBpczogc2hvdWxkIEkgYXR0 YWNoIHRoZSB1bmRlcnJ1biBzdGF0dXMgdG8gdGhlIGRybV9kZXZpY2UKPiA+ID4gb3IgaGF2ZSBv bmUgcGVyIENSVEM/IEluIG15IGNhc2UsIEkgb25seSBjYXJlIGFib3V0IHRoZSAiaGFzIGFuCj4g PiA+IHVuZGVycnVuIGVycm9yIG9jY3VycmVkIG9uIGFueSBvZiB0aGUgYWN0aXZlIENSVEMiIGNh c2UsIHNvIEknZCB2b3RlIGZvcgo+ID4gPiBhIHBlci1kZXZpY2UgdW5kZXJydW4gc3RhdHVzLiAg Cj4gPiAKPiA+IFllYWggcHJvYmFibHkgZ29vZCBlbm91Z2guIEZvciBvdXIgQ0kgYWxsIHdlIGNh cmUgYWJvdXQgaXMgdGhlIHdhcm4vZXJyb3IKPiA+IGxldmVsIGRtZXNnIG91dHB1dC4gQW55dGhp bmcgYXQgdGhhdCBsZXZlbCBpcyBjb25zaWRlcmVkIGEgQ0kgZmFpbHVyZS4KPiAKPiBTbyBpZ3Qg aXMgZ3JlcHBpbmcgZG1lc2cgdG8gZGV0ZWN0IHdoZW4gYW4gdW5kZXJydW4gaGFwcGVucz8KCk5v LCBidXQgdGhlIENJIHJ1bm5lciBpcyBhbHNvIG9ic2VydmluZyBkbWVzZy4gQW55dGhpbmcgaW4g dGhlcmUgYXQKd2FybmluZyBvciBoaWdoZXIgbGV2ZWwgaXMgY29uc2lkZXJlZCBhIGZhaWx1cmUu Cgo+ID4gV2hhdCBkbyB5b3UgbmVlZCB0aGUgZGVidWdmcyBmaWxlIGZvcj8KPiAKPiBJIGp1c3Qg dGhvdWdodCBoYXZpbmcgYSBkZWJ1Z2ZzIGZpbGUgdG8gZXhwb3NlIHRoZSB1bmRlcnJ1biBpbmZv cm1hdGlvbgo+IHdvdWxkIGJlIGNsZWFuZXIgdGhhbiBoYXZpbmcgdG8gZ3JlcCBpbiBkbWVzZyB0 byBkZXRlY3Qgc3VjaCBmYWlsdXJlcy4KClRoZSBpc3N1ZSBpcyB0aGF0IHlvdSB3YW50IHRvIGRl dGVjdCB1bmRlcnJ1bnMgZXZlcnl3aGVyZSwgbm90IGp1c3QgaW4gdGhlCnNwZWNpZmljIHRlc3Rz IHlvdSdyZSBjaGVja2luZyBmb3IgaXQuIEFueXRoaW5nIHRoYXQgZG9lcyBhIG1vZGVzZXQgY291 bGQKY2F1c2UgYW4gdW5kZXJydW4gKGF0IGxlYXN0IHdlJ3ZlIG1hbmFnZWQgdG8gZG8gc28gcHJl dHR5IG11Y2ggZXZlcnl3aGVyZQpvbiBpOTE1IGh3LCBpZiB5b3UgbWlzcHJvZ3JhbSBpcyBzdWZm aWNpZW50bHkpLgotRGFuaWVsCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJ bnRlbCBDb3Jwb3JhdGlvbgpodHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1k ZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcv bWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK