From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Paul Subject: Re: [PATCH 5/6] drm/panel: simple: Innolux TV123WAM is actually P120ZDG-BF1 Date: Fri, 26 Oct 2018 10:38:05 -0400 Message-ID: <20181026143805.GP154160@art_vandelay> References: <20181022204639.8558-1-dianders@chromium.org> <20181022204639.8558-5-dianders@chromium.org> <20181025181349.GM154160@art_vandelay> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Doug Anderson Cc: David Airlie , linux-arm-msm , Sandeep Panda , dri-devel , LKML , Rob Herring , Thierry Reding , Sean Paul , Laurent Pinchart , ryandcase@chromium.org, sean@poorly.run List-Id: linux-arm-msm@vger.kernel.org T24gVGh1LCBPY3QgMjUsIDIwMTggYXQgMDM6MjQ6NThQTSAtMDcwMCwgRG91ZyBBbmRlcnNvbiB3 cm90ZToKPiBIaSwKPiAKPiBPbiBUaHUsIE9jdCAyNSwgMjAxOCBhdCAxMToxMyBBTSBTZWFuIFBh dWwgPHNlYW5AcG9vcmx5LnJ1bj4gd3JvdGU6Cj4gPgo+ID4gT24gTW9uLCBPY3QgMjIsIDIwMTgg YXQgMDE6NDY6MzhQTSAtMDcwMCwgRG91Z2xhcyBBbmRlcnNvbiB3cm90ZToKPiA+ID4gQXMgZmFy IGFzIEkgY2FuIHRlbGwgdGhlIHBhbmVsIHRoYXQgd2FzIGFkZGVkIGluIGNvbW1pdCBkYTUwYmQ0 MjU4ZGIKPiA+ID4gKCJkcm0vcGFuZWw6IHNpbXBsZTogQWRkIElubm9sdXggVFYxMjNXQU0gcGFu ZWwgZHJpdmVyIHN1cHBvcnQiKQo+ID4gPiB3YXNuJ3QgYWN0dWFsbHkgYW4gSW5ub2x1eCBUVjEy M1dBTSBidXQgd2FzIGFjdHVhbGx5IGFuIElubm9sdXgKPiA+ID4gUDEyMFpERy1CRjEuCj4gPiA+ Cj4gPiA+IEFzIGZhciBhcyBJIGNhbiB0ZWxsIHRoZSBJbm5vbHV4IFRWMTIzV0FNIGlzbid0IGEg cmVhbCBwYW5lbCBhbmQgYnV0Cj4gPiA+IGl0J3MgYSBtb3NoIGJldHdlZW4gdGhlIFRJIFRWMTIz V0FNIGFuZCB0aGUgSW5ub2x1eCBQMTIwWkRHLUJGMS4KPiA+ID4gTGV0J3MgdW5tb3NoLgo+ID4g Pgo+ID4gPiBIZXJlJ3MgbXkgZXZpZGVuY2U6Cj4gPiA+Cj4gPiA+ICogU2VhcmNoaW5nIGZvciBU VjEyM1dBTSBvbiB0aGUgSW50ZXJuZXQgdHVybnMgdXAgYSBUSSBwYW5lbC4gIFdoaWxlCj4gPiA+ ICAgaXQncyBwb3NzaWJsZSB0aGF0IGFuIElubm9sdXggcGFuZWwgaGFzIHRoZSBzYW1lIG1vZGVs IG51bWJlciBhcyB0aGUKPiA+ID4gICBUSSBQYW5lbCwgaXQgc2VlbXMgYSBsaXR0bGUgZG91YnRm dWwuICBMb29raW5nIHVwIHRoZSBkYXRhc2hlZXQgZnJvbQo+ID4gPiAgIHRoZSBUSSBQYW5lbCBz aG93cyB0aGF0IGl0J3MgMTkyMCB4IDEyODAgYW5kIDI1OS4yIG1tIHggMTcyLjggbW0uCj4gPiA+ Cj4gPiA+ICogQXMgZmFyIGFzIEkga25vdywgdGhlIHBhdGNoIGFkZGluZyB0aGUgSW5ub2x1eCBQ YW5lbCB3YXMgc3VwcG9zZWQgdG8KPiA+ID4gICBiZSBmb3IgdGhlIGJvYXJkIHRoYXQncyBzaXR0 aW5nIGluIGZyb250IG9mIG1lIGFzIEkgdHlwZSB0aGlzCj4gPiA+ICAgKHN1cHBvcnQgZm9yIHRo YXQgYm9hcmQgaXMgbm90IHlldCB1cHN0cmVhbSkuICBPbiB0aGUgYmFjayBvZiB0aGF0Cj4gPiA+ ICAgcGFuZWwgSSBzZWUgSW5ub2x1eCBQMTIwWkRaLUVaMSByZXYgQjEuCj4gPiA+Cj4gPiA+ICog U29tZW9uZSBwb2ludGVkIG1lIGF0IGEgZGF0YXNoZWV0IHRoYXQncyBzdXBwb3NlZCB0byBiZSBm b3IgdGhlCj4gPiA+ICAgcGFuZWwgaW4gZnJvbnQgb2YgbWUgKHNvcnJ5LCBJIGNhbid0IHNoYXJl IHRoZSBkYXRhc2hlZXQpLiAgVGhhdAo+ID4gPiAgIGRhdGFzaGVldCBoYXMgdGhlIHN0cmluZyAi cDEyMHpkZy1iZjEiCj4gPiA+Cj4gPiA+ICogSWYgSSBzZWFyY2ggZm9yICJQMTIwWkRHLUJGMSIg b24gdGhlIEludGVybmV0IEkgZ2V0IGhpdHMgZm9yIHBhbmVscwo+ID4gPiAgIHRoYXQgYXJlIDIx NjB4MTQ0MC4gIFRoZXkgZG9uJ3QgaGF2ZSBkYXRhc2hlZXRzLCBidXQgdGhlIGZhY3QgdGhhdAo+ ID4gPiAgIHRoZSByZXNvbHV0aW9uIG1hdGNoZXMgaXMgYSBnb29kIHNpZ24uCj4gPiA+Cj4gPiA+ IEluIGFueSBjYXNlLCBsZXQncyB1cGRhdGUgdGhlIG5hbWUgYW5kIGFsc28gdGhlIHBoeXNpY2Fs IHNpemUgdG8gbWF0Y2gKPiA+ID4gdGhlIGNvcnJlY3QgcGFuZWwuCj4gPiA+Cj4gPiA+IEZpeGVz OiBkYTUwYmQ0MjU4ZGIgKCJkcm0vcGFuZWw6IHNpbXBsZTogQWRkIElubm9sdXggVFYxMjNXQU0g cGFuZWwgZHJpdmVyIHN1cHBvcnQiKQo+ID4gPiBTaWduZWQtb2ZmLWJ5OiBEb3VnbGFzIEFuZGVy c29uIDxkaWFuZGVyc0BjaHJvbWl1bS5vcmc+Cj4gPiA+IENjOiBTYW5kZWVwIFBhbmRhIDxzcGFu ZGFAY29kZWF1cm9yYS5vcmc+Cj4gPiA+IC0tLQo+ID4gPgo+ID4gPiAgZHJpdmVycy9ncHUvZHJt L3BhbmVsL3BhbmVsLXNpbXBsZS5jIHwgMTQgKysrKysrKy0tLS0tLS0KPiA+ID4gIDEgZmlsZSBj aGFuZ2VkLCA3IGluc2VydGlvbnMoKyksIDcgZGVsZXRpb25zKC0pCj4gPiA+Cj4gPiA+IGRpZmYg LS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vcGFuZWwvcGFuZWwtc2ltcGxlLmMgYi9kcml2ZXJzL2dw dS9kcm0vcGFuZWwvcGFuZWwtc2ltcGxlLmMKPiA+ID4gaW5kZXggOTM3ZTk3NDkwYzMwLi43ZWUx YWJjNWQ4MWIgMTAwNjQ0Cj4gPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9wYW5lbC9wYW5lbC1z aW1wbGUuYwo+ID4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vcGFuZWwvcGFuZWwtc2ltcGxlLmMK PiA+ID4gQEAgLTEzNzAsNyArMTM3MCw3IEBAIHN0YXRpYyBjb25zdCBzdHJ1Y3QgcGFuZWxfZGVz YyBpbm5vbHV4X24xNTZiZ2VfbDIxID0gewo+ID4gPiAgICAgICB9LAo+ID4gPiAgfTsKPiA+ID4K PiA+ID4gLXN0YXRpYyBjb25zdCBzdHJ1Y3QgZHJtX2Rpc3BsYXlfbW9kZSBpbm5vbHV4X3R2MTIz d2FtX21vZGUgPSB7Cj4gPiA+ICtzdGF0aWMgY29uc3Qgc3RydWN0IGRybV9kaXNwbGF5X21vZGUg aW5ub2x1eF9wMTIwemRnX2JmMV9tb2RlID0gewo+ID4gPiAgICAgICAuY2xvY2sgPSAyMDYwMTYs Cj4gPiA+ICAgICAgIC5oZGlzcGxheSA9IDIxNjAsCj4gPiA+ICAgICAgIC5oc3luY19zdGFydCA9 IDIxNjAgKyA0OCwKPiA+ID4gQEAgLTEzODQsMTMgKzEzODQsMTMgQEAgc3RhdGljIGNvbnN0IHN0 cnVjdCBkcm1fZGlzcGxheV9tb2RlIGlubm9sdXhfdHYxMjN3YW1fbW9kZSA9IHsKPiA+ID4gICAg ICAgLmZsYWdzID0gRFJNX01PREVfRkxBR19QSFNZTkMgfCBEUk1fTU9ERV9GTEFHX1BWU1lOQywK PiA+ID4gIH07Cj4gPiA+Cj4gPiA+IC1zdGF0aWMgY29uc3Qgc3RydWN0IHBhbmVsX2Rlc2MgaW5u b2x1eF90djEyM3dhbSA9IHsKPiA+ID4gLSAgICAgLm1vZGVzID0gJmlubm9sdXhfdHYxMjN3YW1f bW9kZSwKPiA+ID4gK3N0YXRpYyBjb25zdCBzdHJ1Y3QgcGFuZWxfZGVzYyBpbm5vbHV4X3AxMjB6 ZGdfYmYxID0gewo+ID4gPiArICAgICAubW9kZXMgPSAmaW5ub2x1eF9wMTIwemRnX2JmMV9tb2Rl LAo+ID4gPiAgICAgICAubnVtX21vZGVzID0gMSwKPiA+ID4gICAgICAgLmJwYyA9IDgsCj4gPiA+ ICAgICAgIC5zaXplID0gewo+ID4gPiAtICAgICAgICAgICAgIC53aWR0aCA9IDI1OSwKPiA+ID4g LSAgICAgICAgICAgICAuaGVpZ2h0ID0gMTczLAo+ID4gPiArICAgICAgICAgICAgIC53aWR0aCA9 IDI1NCwKPiA+ID4gKyAgICAgICAgICAgICAuaGVpZ2h0ID0gMTY5LAo+ID4gPiAgICAgICB9LAo+ ID4gPiAgICAgICAuZGVsYXkgPSB7Cj4gPiA+ICAgICAgICAgICAgICAgLnByZXBhcmUgPSAyMDAs Cj4gPiA+IEBAIC0yNDU0LDggKzI0NTQsOCBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IG9mX2Rldmlj ZV9pZCBwbGF0Zm9ybV9vZl9tYXRjaFtdID0gewo+ID4gPiAgICAgICAgICAgICAgIC5jb21wYXRp YmxlID0gImlubm9sdXgsbjE1NmJnZS1sMjEiLAo+ID4gPiAgICAgICAgICAgICAgIC5kYXRhID0g Jmlubm9sdXhfbjE1NmJnZV9sMjEsCj4gPiA+ICAgICAgIH0sIHsKPiA+ID4gLSAgICAgICAgICAg ICAuY29tcGF0aWJsZSA9ICJpbm5vbHV4LHR2MTIzd2FtIiwKPiA+Cj4gPiBJIHRoaW5rIHdlIHNo b3VsZCB1cGRhdGUgdGhlIHN0cnVjdCwgYnV0IHdlIG1pZ2h0IHdhbnQgdG8ga2VlcCB0aGlzIGFy b3VuZC4KPiA+IEdpdmVuIHRoZSB0djEyM3dhbSBwYW5lbCBpcyBUSSwgd2UncmUgbGlrZWx5IG5v dCBnb2luZyB0byBoYXZlIGEgY29sbGlzaW9uIG9uCj4gPiBpbm5vbHV4LC4uLgo+ID4KPiA+IFRo YXQgc2FpZCwgSSdsbCBkZWZlciB0byByb2JoIG9uIHRoaXMgb25lLCBJJ20gbm90IHN1cmUgaWYg Y2hhbmdpbmcgbmFtZXMgaXMKPiA+IGNvb2wgb25jZSB0aGUgYmluZGluZ3MgaGF2ZSBoaXQgbWFp bmxpbmUuCj4gCj4gUm9iIGdhdmUgdGhlIGJpbmRpbmdzIHBhdGNoIGEgUmV2aWV3ZWQtYnkgdGFn LCBzbyBJJ20gYXNzdW1pbmcgaGUncwo+IGNvb2wgd2l0aCBpdC4gIHYyIHN0aWxsIGRvZXNuJ3Qg a2VlcCB0aGUgImlubm9sdXgsdHYxMjN3YW0iIGFyb3VuZC4KPiBJZiB5b3UgZGlzYWdyZWUgdGhl biBsZXQgbWUga25vdyBhbmQgSSdsbCBkbyBhIHYzLgoKSSBoYXBwaWx5IGRlZmVyIHRvIFJvYiBv biBhbGwgdGhpbmdzIGR0LiBTbywKClJldmlld2VkLWJ5OiBTZWFuIFBhdWwgPHNlYW5AcG9vcmx5 LnJ1bj4KCgo+IAo+IC1Eb3VnCgotLSAKU2VhbiBQYXVsLCBTb2Z0d2FyZSBFbmdpbmVlciwgR29v Z2xlIC8gQ2hyb21pdW0gT1MKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJp LWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D080CC6786E for ; Fri, 26 Oct 2018 14:38:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7A3EF20651 for ; Fri, 26 Oct 2018 14:38:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=poorly.run header.i=@poorly.run header.b="IGHP73pE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7A3EF20651 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=poorly.run Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727369AbeJZXP0 (ORCPT ); Fri, 26 Oct 2018 19:15:26 -0400 Received: from mail-yw1-f66.google.com ([209.85.161.66]:44093 "EHLO mail-yw1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726195AbeJZXP0 (ORCPT ); Fri, 26 Oct 2018 19:15:26 -0400 Received: by mail-yw1-f66.google.com with SMTP id t78-v6so531269ywg.11 for ; Fri, 26 Oct 2018 07:38:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=poorly.run; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=/2z/mEgjYhyqRstHTZxN5Uc03DlP8LkFiul3rPe3GI4=; b=IGHP73pE3Zu8/Y/gmlFfccdcZQ4sgxS/WIe5itMZv+5LNTVjqrcChZCKR8K7qstgp2 U0DmsHOV2ClULvISjFci1z+7aummHMPmbZ8K7KIkOyTMzQnoLamxwwXqvyF28Bxmc96j 2eUy8OvMmW+vXlEqQ2NIj69D7DOZtiQEa3ucVPGdufBDAa6bvoxSXWvfAS5xvVv7OOSj AZ+gdXlBGauMhW7xfvLagdxKNCweTOZV2vgMhiEj0bmVMimEPe5pQQ8k3+aCEF9iOG8a wSobKIaj0pw73P7pFUuz8F/c47O/HH3afsyXtdITBMD3UTFkP06v93wgKCOvgWk8P38C qZ3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=/2z/mEgjYhyqRstHTZxN5Uc03DlP8LkFiul3rPe3GI4=; b=oBqKLpvWMvecLOgNOBdAp5ixnx0YS99lBUlPUsGTKCThfrA8heizwEyKsvEeqiVjNi xoLp87u3Wlcptrh4n0zwn6ktUCMeFvEAqhfhxUznh9jyEG5upFfor+bCDjmLjiE9dENY yWyyr7vR/xo3cWXoMjgCL1tuypD8l0+fwXTQj8g1rYrbjBlMkQOqGLQ7IbJGAu9QyYW9 NPqEbbiPLTvkEDIRHRxOMEMQYXDncA8134S1wnuJw0B7APA+ysb2MMIsav2gN31TEVSP SieU+FJkgr0hIBNtDJ5+JDvp59YkI60fVdK5RFc1FjSyLKBvJ0W3eAg/DqBz9v2Thki/ 9rew== X-Gm-Message-State: AGRZ1gI0CznqWWIAuxtPsObd/aUONpKEZL3OFktdN2JnkVLEWxdCidzF Iqe0i3+uoTDrxu0eyWlaNTRDqg== X-Google-Smtp-Source: AJdET5fRyh1lKFN/QDeJs7aB6PG9oFU6U2u6Qo4NMOZupcpCNQDVZdoT5kILnsFzY5zSbzA15eJQTA== X-Received: by 2002:a0d:f847:: with SMTP id i68-v6mr3836139ywf.160.1540564687042; Fri, 26 Oct 2018 07:38:07 -0700 (PDT) Received: from localhost ([2620:0:1013:11:ad55:b1db:adfe:3b9f]) by smtp.gmail.com with ESMTPSA id y206-v6sm2756532ywg.57.2018.10.26.07.38.06 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 26 Oct 2018 07:38:06 -0700 (PDT) Date: Fri, 26 Oct 2018 10:38:05 -0400 From: Sean Paul To: Doug Anderson Cc: sean@poorly.run, Sean Paul , Thierry Reding , Sandeep Panda , linux-arm-msm , Laurent Pinchart , Jeykumar Sankaran , ryandcase@chromium.org, David Airlie , dri-devel , LKML , Rob Herring Subject: Re: [PATCH 5/6] drm/panel: simple: Innolux TV123WAM is actually P120ZDG-BF1 Message-ID: <20181026143805.GP154160@art_vandelay> References: <20181022204639.8558-1-dianders@chromium.org> <20181022204639.8558-5-dianders@chromium.org> <20181025181349.GM154160@art_vandelay> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 25, 2018 at 03:24:58PM -0700, Doug Anderson wrote: > Hi, > > On Thu, Oct 25, 2018 at 11:13 AM Sean Paul wrote: > > > > On Mon, Oct 22, 2018 at 01:46:38PM -0700, Douglas Anderson wrote: > > > As far as I can tell the panel that was added in commit da50bd4258db > > > ("drm/panel: simple: Add Innolux TV123WAM panel driver support") > > > wasn't actually an Innolux TV123WAM but was actually an Innolux > > > P120ZDG-BF1. > > > > > > As far as I can tell the Innolux TV123WAM isn't a real panel and but > > > it's a mosh between the TI TV123WAM and the Innolux P120ZDG-BF1. > > > Let's unmosh. > > > > > > Here's my evidence: > > > > > > * Searching for TV123WAM on the Internet turns up a TI panel. While > > > it's possible that an Innolux panel has the same model number as the > > > TI Panel, it seems a little doubtful. Looking up the datasheet from > > > the TI Panel shows that it's 1920 x 1280 and 259.2 mm x 172.8 mm. > > > > > > * As far as I know, the patch adding the Innolux Panel was supposed to > > > be for the board that's sitting in front of me as I type this > > > (support for that board is not yet upstream). On the back of that > > > panel I see Innolux P120ZDZ-EZ1 rev B1. > > > > > > * Someone pointed me at a datasheet that's supposed to be for the > > > panel in front of me (sorry, I can't share the datasheet). That > > > datasheet has the string "p120zdg-bf1" > > > > > > * If I search for "P120ZDG-BF1" on the Internet I get hits for panels > > > that are 2160x1440. They don't have datasheets, but the fact that > > > the resolution matches is a good sign. > > > > > > In any case, let's update the name and also the physical size to match > > > the correct panel. > > > > > > Fixes: da50bd4258db ("drm/panel: simple: Add Innolux TV123WAM panel driver support") > > > Signed-off-by: Douglas Anderson > > > Cc: Sandeep Panda > > > --- > > > > > > drivers/gpu/drm/panel/panel-simple.c | 14 +++++++------- > > > 1 file changed, 7 insertions(+), 7 deletions(-) > > > > > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > > > index 937e97490c30..7ee1abc5d81b 100644 > > > --- a/drivers/gpu/drm/panel/panel-simple.c > > > +++ b/drivers/gpu/drm/panel/panel-simple.c > > > @@ -1370,7 +1370,7 @@ static const struct panel_desc innolux_n156bge_l21 = { > > > }, > > > }; > > > > > > -static const struct drm_display_mode innolux_tv123wam_mode = { > > > +static const struct drm_display_mode innolux_p120zdg_bf1_mode = { > > > .clock = 206016, > > > .hdisplay = 2160, > > > .hsync_start = 2160 + 48, > > > @@ -1384,13 +1384,13 @@ static const struct drm_display_mode innolux_tv123wam_mode = { > > > .flags = DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC, > > > }; > > > > > > -static const struct panel_desc innolux_tv123wam = { > > > - .modes = &innolux_tv123wam_mode, > > > +static const struct panel_desc innolux_p120zdg_bf1 = { > > > + .modes = &innolux_p120zdg_bf1_mode, > > > .num_modes = 1, > > > .bpc = 8, > > > .size = { > > > - .width = 259, > > > - .height = 173, > > > + .width = 254, > > > + .height = 169, > > > }, > > > .delay = { > > > .prepare = 200, > > > @@ -2454,8 +2454,8 @@ static const struct of_device_id platform_of_match[] = { > > > .compatible = "innolux,n156bge-l21", > > > .data = &innolux_n156bge_l21, > > > }, { > > > - .compatible = "innolux,tv123wam", > > > > I think we should update the struct, but we might want to keep this around. > > Given the tv123wam panel is TI, we're likely not going to have a collision on > > innolux,... > > > > That said, I'll defer to robh on this one, I'm not sure if changing names is > > cool once the bindings have hit mainline. > > Rob gave the bindings patch a Reviewed-by tag, so I'm assuming he's > cool with it. v2 still doesn't keep the "innolux,tv123wam" around. > If you disagree then let me know and I'll do a v3. I happily defer to Rob on all things dt. So, Reviewed-by: Sean Paul > > -Doug -- Sean Paul, Software Engineer, Google / Chromium OS