From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [PATCH net] net: sched: Remove TCA_OPTIONS from policy Date: Fri, 26 Oct 2018 18:08:30 +0200 Message-ID: <20181026160830.GC2229@nanopsycho.orion> References: <20181024153249.15374-1-dsahern@kernel.org> <20181025063148.GA2143@nanopsycho> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: David Ahern , netdev@vger.kernel.org, davem@davemloft.net, pupilla@libero.it To: David Ahern Return-path: Received: from mail-wr1-f66.google.com ([209.85.221.66]:35098 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726373AbeJ0AwD (ORCPT ); Fri, 26 Oct 2018 20:52:03 -0400 Received: by mail-wr1-f66.google.com with SMTP id w5-v6so1939911wrt.2 for ; Fri, 26 Oct 2018 09:14:24 -0700 (PDT) Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: Fri, Oct 26, 2018 at 06:02:01PM CEST, dsahern@gmail.com wrote: >On 10/25/18 12:31 AM, Jiri Pirko wrote: >> Wed, Oct 24, 2018 at 05:32:49PM CEST, dsahern@kernel.org wrote: >>> From: David Ahern >>> >>> Marco reported an error with hfsc: >>> root@Calimero:~# tc qdisc add dev eth0 root handle 1:0 hfsc default 1 >>> Error: Attribute failed policy validation. >>> >>> Apparently a few implementations pass TCA_OPTIONS as a binary instead >>> of nested attribute, so drop TCA_OPTIONS from the policy. >> >> Yeah, this is nice example of a case, where I think it wouldn't hurt to >> be a bit more strict. Apparently, the userspace app is buggy. It should >> be fixed. Note that I'm aware of the bw compatibility. > >Kernel side for hfsc expects TCA_OPTIONS as a binary as well - a struct >tc_hfsc_qopt. Nothing that can be done. :(