From: Dave Chinner <david@fromorbit.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Eric Sandeen <sandeen@redhat.com>, xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH] misc: only build with lto if explicitly enabled
Date: Sat, 27 Oct 2018 12:45:16 +1100 [thread overview]
Message-ID: <20181027014516.GH19305@dastard> (raw)
In-Reply-To: <20181026232538.GK28243@magnolia>
On Fri, Oct 26, 2018 at 04:25:38PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> Change the LTO default to off from probe because it wastes build time on
> developer machines. Anyone who really wants it for release builds or
> whatever can still turn it on.
Build time is not the problem. Making the resultant binary
completely unusable with gdb and hence undebuggable is the real
problem with LTO.
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
> configure.ac | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/configure.ac b/configure.ac
> index 44a4b3a8..f8f29c07 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -109,8 +109,8 @@ AC_ARG_ENABLE(threadsan,
> AC_SUBST(enable_threadsan)
>
> AC_ARG_ENABLE(lto,
> -[ --enable-lto=[yes/no] Enable link time optimization (LTO) [default=probe]],,
> - enable_lto=probe)
> +[ --enable-lto=[yes/no] Enable link time optimization (LTO) [default=no]],,
> + enable_lto=no)
Looks good.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
prev parent reply other threads:[~2018-10-27 10:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-26 23:25 [PATCH] misc: only build with lto if explicitly enabled Darrick J. Wong
2018-10-27 1:45 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181027014516.GH19305@dastard \
--to=david@fromorbit.com \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.