From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9282AC6786F for ; Tue, 30 Oct 2018 09:27:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6334720827 for ; Tue, 30 Oct 2018 09:27:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6334720827 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727369AbeJ3STp (ORCPT ); Tue, 30 Oct 2018 14:19:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49018 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726486AbeJ3STp (ORCPT ); Tue, 30 Oct 2018 14:19:45 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0D95A307CDDA; Tue, 30 Oct 2018 09:27:06 +0000 (UTC) Received: from krava (unknown [10.43.17.150]) by smtp.corp.redhat.com (Postfix) with SMTP id EFBB61000049; Tue, 30 Oct 2018 09:27:04 +0000 (UTC) Date: Tue, 30 Oct 2018 10:27:03 +0100 From: Jiri Olsa To: Jiri Olsa Cc: lkml , "Signed-off-by : Len Brown" , "Herton R. Krzesinski" Subject: Re: [PATCH 05/10] tools power x86_energy_perf_policy: Override CFLAGS assignments and add LDFLAGS to build command Message-ID: <20181030092703.GB19259@krava> References: <20181016150614.21260-1-jolsa@kernel.org> <20181016150614.21260-6-jolsa@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181016150614.21260-6-jolsa@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.49]); Tue, 30 Oct 2018 09:27:06 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ping thanks, jirka On Tue, Oct 16, 2018 at 05:06:10PM +0200, Jiri Olsa wrote: > So user could specify outside CFLAGS/LDFLAGS values. > > Cc: Signed-off-by: Len Brown > Signed-off-by: Jiri Olsa > --- > tools/power/x86/x86_energy_perf_policy/Makefile | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/tools/power/x86/x86_energy_perf_policy/Makefile b/tools/power/x86/x86_energy_perf_policy/Makefile > index f4534fb8b951..ae7a0e09b722 100644 > --- a/tools/power/x86/x86_energy_perf_policy/Makefile > +++ b/tools/power/x86/x86_energy_perf_policy/Makefile > @@ -9,12 +9,12 @@ ifeq ("$(origin O)", "command line") > endif > > x86_energy_perf_policy : x86_energy_perf_policy.c > -CFLAGS += -Wall > -CFLAGS += -DMSRHEADER='"../../../../arch/x86/include/asm/msr-index.h"' > +override CFLAGS += -Wall > +override CFLAGS += -DMSRHEADER='"../../../../arch/x86/include/asm/msr-index.h"' > > %: %.c > @mkdir -p $(BUILD_OUTPUT) > - $(CC) $(CFLAGS) $< -o $(BUILD_OUTPUT)/$@ > + $(CC) $(CFLAGS) $< -o $(BUILD_OUTPUT)/$@ $(LDFLAGS) > > .PHONY : clean > clean : > -- > 2.17.2 >