All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
Cc: linux-media@vger.kernel.org, hverkuil@xs4all.nl, mchehab@kernel.org
Subject: Re: [PATCH 4/4] SoC camera: Tidy the header
Date: Wed, 31 Oct 2018 11:29:45 +0200	[thread overview]
Message-ID: <20181031092945.csl5vifvstd5ds5g@paasikivi.fi.intel.com> (raw)
In-Reply-To: <20181030090618.2a62d2d4@coco.lan>

Hi Mauro,

On Tue, Oct 30, 2018 at 09:06:18AM -0300, Mauro Carvalho Chehab wrote:
> Em Tue, 30 Oct 2018 01:00:29 +0200
> Sakari Ailus <sakari.ailus@linux.intel.com> escreveu:
> 
> > Clean up the SoC camera framework header. It only exists now to keep board
> > code compiling. The header can be removed once the board code dependencies
> > to it has been removed.
> > 
> > Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> > ---
> >  include/media/soc_camera.h | 335 ---------------------------------------------
> >  1 file changed, 335 deletions(-)
> > 
> > diff --git a/include/media/soc_camera.h b/include/media/soc_camera.h
> > index b7e42a1b0910..14d19da6052a 100644
> > --- a/include/media/soc_camera.h
> > +++ b/include/media/soc_camera.h
> > @@ -22,172 +22,6 @@
> >  #include <media/v4l2-ctrls.h>
> >  #include <media/v4l2-device.h>
> 
> That doesn't make any sense. soc_camera.h should have the same fate
> as the entire soc_camera infrastructure: either be removed or moved
> to staging, and everything else that doesn't have the same fate
> should get rid of this header.

We can't just remove this; there is board code that depends on it.

The intent is to remove the board code as well but presuming that the board
code would be merged through a different tree, it'd be less hassle to wait
a bit; hence the patch removing any unnecessary stuff here.

-- 
Regards,

Sakari Ailus
sakari.ailus@linux.intel.com

  reply	other threads:[~2018-10-31 18:27 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-29 23:00 [PATCH 0/4] SoC camera removal Sakari Ailus
2018-10-29 23:00 ` [PATCH 1/4] tw9910: Unregister async subdev at device unbind Sakari Ailus
2018-10-29 23:00 ` [PATCH 2/4] tw9910: No SoC camera dependency Sakari Ailus
2018-10-30 12:03   ` Hans Verkuil
2018-10-31  9:49     ` Sakari Ailus
2018-10-31  9:50       ` Hans Verkuil
2018-10-29 23:00 ` [PATCH 4/4] SoC camera: Tidy the header Sakari Ailus
2018-10-30  9:50   ` Mauro Carvalho Chehab
2018-10-30 12:06   ` Mauro Carvalho Chehab
2018-10-31  9:29     ` Sakari Ailus [this message]
2018-10-31  9:40       ` Mauro Carvalho Chehab
2018-10-31  9:44         ` Sakari Ailus
2018-10-31  9:57         ` Sakari Ailus
2018-10-31 10:00         ` Hans Verkuil
2018-10-31 10:54           ` Mauro Carvalho Chehab
2018-11-13 22:41             ` Sakari Ailus
2018-10-29 23:21 ` [PATCH 3/4] SoC camera: Remove the framework and the drivers Sakari Ailus
2018-10-30  9:43   ` Mauro Carvalho Chehab
2018-10-30 12:06     ` Mauro Carvalho Chehab
2018-10-30 12:09       ` Mauro Carvalho Chehab
2018-10-30 12:14     ` Mauro Carvalho Chehab
2018-10-30 20:28       ` jacopo mondi
2018-10-30 20:35         ` Mauro Carvalho Chehab
2018-10-30 21:17           ` jacopo mondi
2018-10-31  9:12             ` Hans Verkuil
2018-10-31  9:32           ` Sakari Ailus
2018-10-31 10:04             ` Mauro Carvalho Chehab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181031092945.csl5vifvstd5ds5g@paasikivi.fi.intel.com \
    --to=sakari.ailus@linux.intel.com \
    --cc=hverkuil@xs4all.nl \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab+samsung@kernel.org \
    --cc=mchehab@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.