All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Roth <mdroth@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, "Tomáš Golembiovský" <tgolembi@redhat.com>
Subject: [Qemu-devel] [PULL v3 16/24] qga-win: demystify namespace stripping
Date: Wed, 31 Oct 2018 09:19:17 -0500	[thread overview]
Message-ID: <20181031141925.30026-17-mdroth@linux.vnet.ibm.com> (raw)
In-Reply-To: <20181031141925.30026-1-mdroth@linux.vnet.ibm.com>

From: Tomáš Golembiovský <tgolembi@redhat.com>

It was not obvious what exactly the cryptic string copying does to the
GUID. This change makes the intent clearer.

Signed-off-by: Tomáš Golembiovský <tgolembi@redhat.com>
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
---
 qga/commands-win32.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/qga/commands-win32.c b/qga/commands-win32.c
index 30d6c639c3..a1b7512d46 100644
--- a/qga/commands-win32.c
+++ b/qga/commands-win32.c
@@ -521,7 +521,7 @@ static GuestPCIAddress *get_pci_info(char *guid, Error **errp)
     char dev_name[MAX_PATH];
     char *buffer = NULL;
     GuestPCIAddress *pci = NULL;
-    char *name = g_strdup(&guid[4]);
+    char *name = NULL;
     bool partial_pci = false;
     pci = g_malloc0(sizeof(*pci));
     pci->domain = -1;
@@ -529,6 +529,13 @@ static GuestPCIAddress *get_pci_info(char *guid, Error **errp)
     pci->function = -1;
     pci->bus = -1;
 
+    if (g_str_has_prefix(guid, "\\\\.\\") ||
+        g_str_has_prefix(guid, "\\\\?\\")) {
+        name = g_strdup(guid + 4);
+    } else {
+        name = g_strdup(guid);
+    }
+
     if (!QueryDosDevice(name, dev_name, ARRAY_SIZE(dev_name))) {
         error_setg_win32(errp, GetLastError(), "failed to get dos device name");
         goto out;
-- 
2.17.1

  parent reply	other threads:[~2018-10-31 14:20 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-31 14:19 [Qemu-devel] [PULL v3 00/24] qemu-ga patch queue for soft-freeze Michael Roth
2018-10-31 14:19 ` [Qemu-devel] [PULL v3 01/24] qga: Support Unicode paths in guest-file-open on win32 Michael Roth
2018-10-31 14:19 ` [Qemu-devel] [PULL v3 02/24] qga-win: add support for qmp_guest_fsfreeze_freeze_list Michael Roth
2018-10-31 14:19 ` [Qemu-devel] [PULL v3 03/24] qga: ignore non present cpus when handling qmp_guest_get_vcpus() Michael Roth
2018-10-31 14:19 ` [Qemu-devel] [PULL v3 04/24] configure: add test for libudev Michael Roth
2018-10-31 14:19 ` [Qemu-devel] [PULL v3 05/24] qga: linux: report disk serial number Michael Roth
2018-10-31 14:19 ` [Qemu-devel] [PULL v3 06/24] qga: linux: return disk device in guest-get-fsinfo Michael Roth
2018-10-31 14:19 ` [Qemu-devel] [PULL v3 07/24] qga-win: prevent crash when executing fsinfo command Michael Roth
2018-10-31 14:19 ` [Qemu-devel] [PULL v3 08/24] qga-win: fsinfo: pci-info: allow partial info Michael Roth
2018-10-31 14:19 ` [Qemu-devel] [PULL v3 09/24] build: rename CONFIG_QGA_NTDDDISK to CONFIG_QGA_NTDDSCSI Michael Roth
2018-10-31 14:19 ` [Qemu-devel] [PULL v3 10/24] qga-win: add debugging information Michael Roth
2018-10-31 14:19 ` [Qemu-devel] [PULL v3 11/24] qga-win: refactor disk properties (bus) Michael Roth
2018-10-31 14:19 ` [Qemu-devel] [PULL v3 12/24] qga-win: report disk serial number Michael Roth
2018-10-31 14:19 ` [Qemu-devel] [PULL v3 13/24] qga-win: refactor disk info Michael Roth
2018-10-31 14:19 ` [Qemu-devel] [PULL v3 14/24] qga-win: handle multi-disk volumes Michael Roth
2018-10-31 14:19 ` [Qemu-devel] [PULL v3 15/24] qga-win: return disk device in guest-get-fsinfo Michael Roth
2018-10-31 14:19 ` Michael Roth [this message]
2018-10-31 14:19 ` [Qemu-devel] [PULL v3 17/24] qga: fix an off-by-one issue Michael Roth
2018-10-31 14:19 ` [Qemu-devel] [PULL v3 18/24] qga: group agent init/cleanup init separate routines Michael Roth
2018-10-31 14:19 ` [Qemu-devel] [PULL v3 19/24] qga: hang GAConfig/socket_activation off of GAState global Michael Roth
2018-10-31 14:19 ` [Qemu-devel] [PULL v3 20/24] qga: move w32 service handling out of run_agent() Michael Roth
2018-10-31 14:19 ` [Qemu-devel] [PULL v3 21/24] qga: add --retry-path option for re-initializing channel on failure Michael Roth
2018-10-31 14:19 ` [Qemu-devel] [PULL v3 22/24] qga-win: install service with --retry-path set by default Michael Roth
2018-10-31 14:19 ` [Qemu-devel] [PULL v3 23/24] qga-win: report specific error when failing to open channel Michael Roth
2018-10-31 14:19 ` [Qemu-devel] [PULL v3 24/24] qga-win: changing --retry-path option behavior Michael Roth
2018-11-01 18:28 ` [Qemu-devel] [PULL v3 00/24] qemu-ga patch queue for soft-freeze Peter Maydell
2018-11-02  0:27 ` no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181031141925.30026-17-mdroth@linux.vnet.ibm.com \
    --to=mdroth@linux.vnet.ibm.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=tgolembi@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.