From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8927CC0044C for ; Wed, 31 Oct 2018 16:42:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 423B22081B for ; Wed, 31 Oct 2018 16:42:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 423B22081B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729864AbeKABlU (ORCPT ); Wed, 31 Oct 2018 21:41:20 -0400 Received: from mx2.suse.de ([195.135.220.15]:58334 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729341AbeKABlU (ORCPT ); Wed, 31 Oct 2018 21:41:20 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id D60BEAE85; Wed, 31 Oct 2018 16:42:32 +0000 (UTC) Date: Wed, 31 Oct 2018 17:42:31 +0100 From: Michal Hocko To: Dave Hansen Cc: Kuo-Hsin Yang , linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-mm@kvack.org, Chris Wilson , Joonas Lahtinen , Peter Zijlstra , Andrew Morton Subject: Re: [PATCH v3] mm, drm/i915: mark pinned shmemfs pages as unevictable Message-ID: <20181031164231.GQ32673@dhcp22.suse.cz> References: <20181031081945.207709-1-vovoy@chromium.org> <20181031142458.GP32673@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 31-10-18 07:40:14, Dave Hansen wrote: > On 10/31/18 7:24 AM, Michal Hocko wrote: > > I am also wondering whether unevictable pages culling can be > > really visible when we do the anon LRU reclaim because the swap path is > > quite expensinve on its own. > > Didn't we create the unevictable lists in the first place because > scanning alone was observed to be so expensive in some scenarios? Yes, that is the case. I might just misunderstood the code I thought those pages were already on the LRU when unevictable flag was set and we would only move these pages to the unevictable list lazy during the reclaim. If the flag is set at the time when the page is added to the LRU then it should get to the proper LRU list right away. But then I do not understand the test results from previous run at all. -- Michal Hocko SUSE Labs From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Hocko Subject: Re: [PATCH v3] mm, drm/i915: mark pinned shmemfs pages as unevictable Date: Wed, 31 Oct 2018 17:42:31 +0100 Message-ID: <20181031164231.GQ32673@dhcp22.suse.cz> References: <20181031081945.207709-1-vovoy@chromium.org> <20181031142458.GP32673@dhcp22.suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 77630899E9 for ; Wed, 31 Oct 2018 16:42:35 +0000 (UTC) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Dave Hansen Cc: Peter Zijlstra , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton List-Id: intel-gfx@lists.freedesktop.org T24gV2VkIDMxLTEwLTE4IDA3OjQwOjE0LCBEYXZlIEhhbnNlbiB3cm90ZToKPiBPbiAxMC8zMS8x OCA3OjI0IEFNLCBNaWNoYWwgSG9ja28gd3JvdGU6Cj4gPiBJIGFtIGFsc28gd29uZGVyaW5nIHdo ZXRoZXIgdW5ldmljdGFibGUgcGFnZXMgY3VsbGluZyBjYW4gYmUKPiA+IHJlYWxseSB2aXNpYmxl IHdoZW4gd2UgZG8gdGhlIGFub24gTFJVIHJlY2xhaW0gYmVjYXVzZSB0aGUgc3dhcCBwYXRoIGlz Cj4gPiBxdWl0ZSBleHBlbnNpbnZlIG9uIGl0cyBvd24uCj4gCj4gRGlkbid0IHdlIGNyZWF0ZSB0 aGUgdW5ldmljdGFibGUgbGlzdHMgaW4gdGhlIGZpcnN0IHBsYWNlIGJlY2F1c2UKPiBzY2Fubmlu ZyBhbG9uZSB3YXMgb2JzZXJ2ZWQgdG8gYmUgc28gZXhwZW5zaXZlIGluIHNvbWUgc2NlbmFyaW9z PwoKWWVzLCB0aGF0IGlzIHRoZSBjYXNlLiBJIG1pZ2h0IGp1c3QgbWlzdW5kZXJzdG9vZCB0aGUg Y29kZSBJIHRob3VnaHQKdGhvc2UgcGFnZXMgd2VyZSBhbHJlYWR5IG9uIHRoZSBMUlUgd2hlbiB1 bmV2aWN0YWJsZSBmbGFnIHdhcyBzZXQgYW5kCndlIHdvdWxkIG9ubHkgbW92ZSB0aGVzZSBwYWdl cyB0byB0aGUgdW5ldmljdGFibGUgbGlzdCBsYXp5IGR1cmluZyB0aGUKcmVjbGFpbS4gSWYgdGhl IGZsYWcgaXMgc2V0IGF0IHRoZSB0aW1lIHdoZW4gdGhlIHBhZ2UgaXMgYWRkZWQgdG8gdGhlCkxS VSB0aGVuIGl0IHNob3VsZCBnZXQgdG8gdGhlIHByb3BlciBMUlUgbGlzdCByaWdodCBhd2F5LiBC dXQgdGhlbiBJIGRvCm5vdCB1bmRlcnN0YW5kIHRoZSB0ZXN0IHJlc3VsdHMgZnJvbSBwcmV2aW91 cyBydW4gYXQgYWxsLgotLSAKTWljaGFsIEhvY2tvClNVU0UgTGFicwpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0Cklu dGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK