From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F26DECDE44 for ; Wed, 31 Oct 2018 23:26:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 378C420847 for ; Wed, 31 Oct 2018 23:26:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="XKi3AvcF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 378C420847 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731364AbeKAI0s (ORCPT ); Thu, 1 Nov 2018 04:26:48 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:34726 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727546AbeKAI0r (ORCPT ); Thu, 1 Nov 2018 04:26:47 -0400 Received: from emerald.amanokami.net (unknown [96.44.9.81]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 0AAE811F2; Thu, 1 Nov 2018 00:26:26 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1541028388; bh=EZGOw/j7tr+oKO3jtwt4JL3i+Fs1aU4VF5qrCN8OpPU=; h=Date:From:To:Subject:References:In-Reply-To:From; b=XKi3AvcFYXle9xrJtQ8ynOLS7JbKvTzhrxHsFw4DeajesOU8FGHiFnva4x9Cv1ZoS CTG7rSxd0V8Mijiaxm4AY8LwC7gmNDaiC7kwEKOGaU/Yh/8lUvIz3PHx07gqMk6VrI ReYrFsRdAuI1xuz7pQLIS5C+2Zh4wrwf2y4zSu5o= Date: Wed, 31 Oct 2018 19:26:20 -0400 From: Paul Elder To: Bin Liu , laurent.pinchart@ideasonboard.com, kieran.bingham@ideasonboard.com, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, balbi@kernel.org, stern@rowland.harvard.edu, rogerq@ti.com Subject: Re: [PATCH 5/6] usb: musb: gadget: implement send_response Message-ID: <20181031232620.GA13896@emerald.amanokami.net> References: <20181010024903.1633-1-paul.elder@ideasonboard.com> <20181010024903.1633-6-paul.elder@ideasonboard.com> <20181011160746.GA8763@uda0271908> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181011160746.GA8763@uda0271908> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Bin, On Thu, Oct 11, 2018 at 11:07:46AM -0500, Bin Liu wrote: > Hi, > > On Tue, Oct 09, 2018 at 10:49:02PM -0400, Paul Elder wrote: > > This patch implements a mechanism to signal the MUSB driver to reply to > > a control OUT request with STALL or ACK. > > > > Signed-off-by: Paul Elder > > Reviewed-by: Laurent Pinchart > > The patch looks good to me, here is my Acked-by: > > Acked-by: Bin Liu > > but I am unable to test this patch set - the current Greg's usb-next > tree gives deadlock error between composite_disconnect() and > usb_function_deactivate() when loading g_webcam.ko on BeagleboneBlack. > The error happens before applying this patch set. We don't use g_webcam anymore, because it doesn't offer the flexibility that configfs does (for example, only one function can be configured with g_webcam). There are no features that g_webcam offers that configfs doesn't. I was unable to reproduce the deadlock that you mention on Greg's usb-next tree. Which commit were you on? I did, however, get the deadlock that you mention upon *killing* the userspace application providing the stream, not when loading g_webcam.ko. Here is a sample script for setting up a UVC gadget through configfs (I haven't tested this exact script; I extracted the functional components): CONFIGFS="/sys/kernel/config" GADGET="$CONFIGFS/usb_gadget" VID="0x0525" PID="0xa4a2" SERIAL="0123456789" MANUF=$(hostname) PRODUCT="UVC Gadget" UDC=`ls /sys/class/udc` cd $GADGET/g1 echo $VID > idVendor echo $PID > idProduct mkdir -p strings/0x409 echo $SERIAL > strings/0x409/serialnumber echo $MANUF > strings/0x409/manufacturer echo $PRODUCT > strings/0x409/product mkdir configs/c.1 mkdir configs/c.1/strings/0x409 # create uvc CONFIG="configs/c.1" FUNCTION="uvc.0" mkdir functions/$FUNCTION # create frame 640x360 uncompressed WIDTH=640 HEIGHT=360 wdir=functions/$FUNCTION/streaming/uncompressed/u/${HEIGHT}p mkdir $wdir echo $WIDTH > $wdir/wWidth echo $HEIGHT > $wdir/wHeight echo $(( $WIDTH * $HEIGHT * 2 )) > $wdir/dwMaxVideoFrameBufferSize cat < $wdir/dwFrameInterval 666666 100000 5000000 EOF # end create frame mkdir functions/$FUNCTION/streaming/header/h cd functions/$FUNCTION/streaming/header/h ln -s ../../uncompressed/u cd ../../class/fs ln -s ../../header/h cd ../../class/hs ln -s ../../header/h cd ../../../control mkdir header/h ln -s header/h class/fs ln -s header/h class/ss cd ../../../ # Set the packet size: uvc gadget max size is 3k... echo 3072 > functions/$FUNCTION/streaming_maxpacket echo 2048 > functions/$FUNCTION/streaming_maxpacket echo 1024 > functions/$FUNCTION/streaming_maxpacket ln -s functions/$FUNCTION configs/c.1 # end create uvc echo $UDC > UDC Thanks, Paul From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [5/6] usb: musb: gadget: implement send_response From: Paul Elder Message-Id: <20181031232620.GA13896@emerald.amanokami.net> Date: Wed, 31 Oct 2018 19:26:20 -0400 To: Bin Liu , laurent.pinchart@ideasonboard.com, kieran.bingham@ideasonboard.com, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, balbi@kernel.org, stern@rowland.harvard.edu, rogerq@ti.com List-ID: SGkgQmluLAoKT24gVGh1LCBPY3QgMTEsIDIwMTggYXQgMTE6MDc6NDZBTSAtMDUwMCwgQmluIExp dSB3cm90ZToKPiBIaSwKPiAKPiBPbiBUdWUsIE9jdCAwOSwgMjAxOCBhdCAxMDo0OTowMlBNIC0w NDAwLCBQYXVsIEVsZGVyIHdyb3RlOgo+ID4gVGhpcyBwYXRjaCBpbXBsZW1lbnRzIGEgbWVjaGFu aXNtIHRvIHNpZ25hbCB0aGUgTVVTQiBkcml2ZXIgdG8gcmVwbHkgdG8KPiA+IGEgY29udHJvbCBP VVQgcmVxdWVzdCB3aXRoIFNUQUxMIG9yIEFDSy4KPiA+IAo+ID4gU2lnbmVkLW9mZi1ieTogUGF1 bCBFbGRlciA8cGF1bC5lbGRlckBpZGVhc29uYm9hcmQuY29tPgo+ID4gUmV2aWV3ZWQtYnk6IExh dXJlbnQgUGluY2hhcnQgPGxhdXJlbnQucGluY2hhcnRAaWRlYXNvbmJvYXJkLmNvbT4KPiAKPiBU aGUgcGF0Y2ggbG9va3MgZ29vZCB0byBtZSwgaGVyZSBpcyBteSBBY2tlZC1ieToKPiAKPiBBY2tl ZC1ieTogQmluIExpdSA8Yi1saXVAdGkuY29tPgo+IAo+IGJ1dCBJIGFtIHVuYWJsZSB0byB0ZXN0 IHRoaXMgcGF0Y2ggc2V0IC0gdGhlIGN1cnJlbnQgR3JlZydzIHVzYi1uZXh0Cj4gdHJlZSBnaXZl cyBkZWFkbG9jayBlcnJvciBiZXR3ZWVuIGNvbXBvc2l0ZV9kaXNjb25uZWN0KCkgYW5kCj4gdXNi X2Z1bmN0aW9uX2RlYWN0aXZhdGUoKSB3aGVuIGxvYWRpbmcgZ193ZWJjYW0ua28gb24gQmVhZ2xl Ym9uZUJsYWNrLgo+IFRoZSBlcnJvciBoYXBwZW5zIGJlZm9yZSBhcHBseWluZyB0aGlzIHBhdGNo IHNldC4KCldlIGRvbid0IHVzZSBnX3dlYmNhbSBhbnltb3JlLCBiZWNhdXNlIGl0IGRvZXNuJ3Qg b2ZmZXIgdGhlIGZsZXhpYmlsaXR5CnRoYXQgY29uZmlnZnMgZG9lcyAoZm9yIGV4YW1wbGUsIG9u bHkgb25lIGZ1bmN0aW9uIGNhbiBiZSBjb25maWd1cmVkIHdpdGgKZ193ZWJjYW0pLiBUaGVyZSBh cmUgbm8gZmVhdHVyZXMgdGhhdCBnX3dlYmNhbSBvZmZlcnMgdGhhdCBjb25maWdmcyBkb2Vzbid0 LgoKSSB3YXMgdW5hYmxlIHRvIHJlcHJvZHVjZSB0aGUgZGVhZGxvY2sgdGhhdCB5b3UgbWVudGlv biBvbiBHcmVnJ3MKdXNiLW5leHQgdHJlZS4gV2hpY2ggY29tbWl0IHdlcmUgeW91IG9uPwpJIGRp ZCwgaG93ZXZlciwgZ2V0IHRoZSBkZWFkbG9jayB0aGF0IHlvdSBtZW50aW9uIHVwb24gKmtpbGxp bmcqIHRoZQp1c2Vyc3BhY2UgYXBwbGljYXRpb24gcHJvdmlkaW5nIHRoZSBzdHJlYW0sIG5vdCB3 aGVuIGxvYWRpbmcgZ193ZWJjYW0ua28uCgpIZXJlIGlzIGEgc2FtcGxlIHNjcmlwdCBmb3Igc2V0 dGluZyB1cCBhIFVWQyBnYWRnZXQgdGhyb3VnaCBjb25maWdmcwooSSBoYXZlbid0IHRlc3RlZCB0 aGlzIGV4YWN0IHNjcmlwdDsgSSBleHRyYWN0ZWQgdGhlIGZ1bmN0aW9uYWwKY29tcG9uZW50cyk6 CgpDT05GSUdGUz0iL3N5cy9rZXJuZWwvY29uZmlnIgpHQURHRVQ9IiRDT05GSUdGUy91c2JfZ2Fk Z2V0IgpWSUQ9IjB4MDUyNSIKUElEPSIweGE0YTIiClNFUklBTD0iMDEyMzQ1Njc4OSIKTUFOVUY9 JChob3N0bmFtZSkKUFJPRFVDVD0iVVZDIEdhZGdldCIKVURDPWBscyAvc3lzL2NsYXNzL3VkY2AK CmNkICRHQURHRVQvZzEKZWNobyAkVklEID4gaWRWZW5kb3IKZWNobyAkUElEID4gaWRQcm9kdWN0 Cgpta2RpciAtcCBzdHJpbmdzLzB4NDA5CmVjaG8gJFNFUklBTCA+IHN0cmluZ3MvMHg0MDkvc2Vy aWFsbnVtYmVyCmVjaG8gJE1BTlVGID4gc3RyaW5ncy8weDQwOS9tYW51ZmFjdHVyZXIKZWNobyAk UFJPRFVDVCA+IHN0cmluZ3MvMHg0MDkvcHJvZHVjdAoKbWtkaXIgY29uZmlncy9jLjEKbWtkaXIg Y29uZmlncy9jLjEvc3RyaW5ncy8weDQwOQoKIyBjcmVhdGUgdXZjCkNPTkZJRz0iY29uZmlncy9j LjEiCkZVTkNUSU9OPSJ1dmMuMCIKCm1rZGlyIGZ1bmN0aW9ucy8kRlVOQ1RJT04KCiMgY3JlYXRl IGZyYW1lIDY0MHgzNjAgdW5jb21wcmVzc2VkCldJRFRIPTY0MApIRUlHSFQ9MzYwCgp3ZGlyPWZ1 bmN0aW9ucy8kRlVOQ1RJT04vc3RyZWFtaW5nL3VuY29tcHJlc3NlZC91LyR7SEVJR0hUfXAKCm1r ZGlyICR3ZGlyCmVjaG8gJFdJRFRIID4gJHdkaXIvd1dpZHRoCmVjaG8gJEhFSUdIVCA+ICR3ZGly L3dIZWlnaHQKZWNobyAkKCggJFdJRFRIICogJEhFSUdIVCAqIDIgKSkgPiAkd2Rpci9kd01heFZp ZGVvRnJhbWVCdWZmZXJTaXplCmNhdCA8PEVPRiA+ICR3ZGlyL2R3RnJhbWVJbnRlcnZhbAo2NjY2 NjYKMTAwMDAwCjUwMDAwMDAKRU9GCiMgZW5kIGNyZWF0ZSBmcmFtZQoKbWtkaXIgZnVuY3Rpb25z LyRGVU5DVElPTi9zdHJlYW1pbmcvaGVhZGVyL2gKY2QgZnVuY3Rpb25zLyRGVU5DVElPTi9zdHJl YW1pbmcvaGVhZGVyL2gKbG4gLXMgLi4vLi4vdW5jb21wcmVzc2VkL3UKY2QgLi4vLi4vY2xhc3Mv ZnMKbG4gLXMgLi4vLi4vaGVhZGVyL2gKY2QgLi4vLi4vY2xhc3MvaHMKbG4gLXMgLi4vLi4vaGVh ZGVyL2gKY2QgLi4vLi4vLi4vY29udHJvbApta2RpciBoZWFkZXIvaApsbiAtcyBoZWFkZXIvaCBj bGFzcy9mcwpsbiAtcyBoZWFkZXIvaCBjbGFzcy9zcwpjZCAuLi8uLi8uLi8KCiMgU2V0IHRoZSBw YWNrZXQgc2l6ZTogdXZjIGdhZGdldCBtYXggc2l6ZSBpcyAzay4uLgplY2hvIDMwNzIgPiBmdW5j dGlvbnMvJEZVTkNUSU9OL3N0cmVhbWluZ19tYXhwYWNrZXQKZWNobyAyMDQ4ID4gZnVuY3Rpb25z LyRGVU5DVElPTi9zdHJlYW1pbmdfbWF4cGFja2V0CmVjaG8gMTAyNCA+IGZ1bmN0aW9ucy8kRlVO Q1RJT04vc3RyZWFtaW5nX21heHBhY2tldAoKbG4gLXMgZnVuY3Rpb25zLyRGVU5DVElPTiBjb25m aWdzL2MuMQojIGVuZCBjcmVhdGUgdXZjCgplY2hvICRVREMgPiBVREMKCgpUaGFua3MsCgpQYXVs Cg==