From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH 1/2] bus/dpaa: fix build with gcc 9.0
Date: Thu, 1 Nov 2018 10:42:31 -0700
Message-ID: <20181101104231.1a4c1d72@xeon-e3>
References: <20181101131951.91459-1-ferruh.yigit@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Cc: Thomas Monjalon <thomas@monjalon.net>, Hemant Agrawal
 <hemant.agrawal@nxp.com>, Shreyansh Jain <shreyansh.jain@nxp.com>,
 dev@dpdk.org, stable@dpdk.org
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pf1-f195.google.com (mail-pf1-f195.google.com
 [209.85.210.195]) by dpdk.org (Postfix) with ESMTP id 3E67D5B32
 for <dev@dpdk.org>; Thu,  1 Nov 2018 18:42:41 +0100 (CET)
Received: by mail-pf1-f195.google.com with SMTP id u13-v6so4062190pfm.4
 for <dev@dpdk.org>; Thu, 01 Nov 2018 10:42:41 -0700 (PDT)
In-Reply-To: <20181101131951.91459-1-ferruh.yigit@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu,  1 Nov 2018 13:19:50 +0000
Ferruh Yigit <ferruh.yigit@intel.com> wrote:

> build error:
> In function =E2=80=98fman_if_init=E2=80=99,
>     .../drivers/bus/dpaa/base/fman/fman.c:186:2:
>     error: =E2=80=98strncpy=E2=80=99 output may be truncated copying 4095=
 bytes from a
>            string of length 4095 [-Werror=3Dstringop-truncation]
>     strncpy(__if->node_path, dpa_node->full_name, PATH_MAX - 1);
>=20
> strncpy may result a not null-terminated string,
> replaced it with rte_strscpy
>=20
> Fixes: 5b22cf744689 ("bus/dpaa: introducing FMan configurations")
> Cc: stable@dpdk.org
>=20
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>

Maybe just use strlcpy instead of a DPDK specific function.
That way if Gcc gets smarter it can check that as well.