From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH 1/2] bus/dpaa: fix build with gcc 9.0
Date: Thu, 1 Nov 2018 17:45:50 +0000
Message-ID: <20181101174550.GA23396@bricha3-MOBL.ger.corp.intel.com>
References: <20181101131951.91459-1-ferruh.yigit@intel.com>
 <20181101104231.1a4c1d72@xeon-e3>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: Ferruh Yigit <ferruh.yigit@intel.com>,
 Thomas Monjalon <thomas@monjalon.net>,
 Hemant Agrawal <hemant.agrawal@nxp.com>,
 Shreyansh Jain <shreyansh.jain@nxp.com>, dev@dpdk.org, stable@dpdk.org
To: Stephen Hemminger <stephen@networkplumber.org>
Return-path: <dev-bounces@dpdk.org>
Content-Disposition: inline
In-Reply-To: <20181101104231.1a4c1d72@xeon-e3>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, Nov 01, 2018 at 10:42:31AM -0700, Stephen Hemminger wrote:
> On Thu,  1 Nov 2018 13:19:50 +0000
> Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> 
> > build error:
> > In function ‘fman_if_init’,
> >     .../drivers/bus/dpaa/base/fman/fman.c:186:2:
> >     error: ‘strncpy’ output may be truncated copying 4095 bytes from a
> >            string of length 4095 [-Werror=stringop-truncation]
> >     strncpy(__if->node_path, dpa_node->full_name, PATH_MAX - 1);
> > 
> > strncpy may result a not null-terminated string,
> > replaced it with rte_strscpy
> > 
> > Fixes: 5b22cf744689 ("bus/dpaa: introducing FMan configurations")
> > Cc: stable@dpdk.org
> > 
> > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> 
> Maybe just use strlcpy instead of a DPDK specific function.
> That way if Gcc gets smarter it can check that as well.

+1
While I get the point of strscpy, if strlcpy is good enough for openbsd,
it's good enough for me! :-)