From: Dave Chinner <david@fromorbit.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH] xfs: print buffer offsets when dumping corrupt buffers
Date: Fri, 2 Nov 2018 08:38:35 +1100 [thread overview]
Message-ID: <20181101213835.GB19305@dastard> (raw)
In-Reply-To: <20181031154710.GP4135@magnolia>
On Wed, Oct 31, 2018 at 08:47:10AM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> Use DUMP_PREFIX_OFFSET when printing hex dumps of corrupt buffers
> because modern Linux now prints a 32-bit hash of our 64-bit pointer when
> using DUMP_PREFIX_ADDRESS:
>
> 00000000b4bb4297: 00 00 00 00 00 00 00 00 3b ee 00 00 00 00 00 00 ........;.......
> 00000005ec77e26: 00 00 00 00 02 d0 5a 00 00 00 00 00 00 00 00 00 ......Z.........
> 000000015938018: 21 98 e8 b4 fd de 4c 07 bc ea 3c e5 ae b4 7c 48 !.....L...<...|H
>
> This is totally worthless for a sequential dump since we probably only
> care about tracking the buffer offsets and afaik there's no way to
> recover the actual pointer from the hashed value.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Makes sense - offset into buffer is what we really care about.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
prev parent reply other threads:[~2018-11-02 6:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-31 15:47 [PATCH] xfs: print buffer offsets when dumping corrupt buffers Darrick J. Wong
2018-11-01 21:38 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181101213835.GB19305@dastard \
--to=david@fromorbit.com \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.