From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Subject: Re: [PATCH bpf 0/3] show more accurrate bpf program address
Date: Thu, 1 Nov 2018 16:15:52 -0700
Message-ID: <20181101231550.5rzlibtccp7hhp2b@ast-mbp>
References: <20181101070058.2760251-1-songliubraving@fb.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: netdev@vger.kernel.org, kernel-team@fb.com, ast@kernel.org,
        daniel@iogearbox.net, sandipan@linux.vnet.ibm.com
To: Song Liu <songliubraving@fb.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-it1-f194.google.com ([209.85.166.194]:54937 "EHLO
        mail-it1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726386AbeKBIU5 (ORCPT
        <rfc822;netdev@vger.kernel.org>); Fri, 2 Nov 2018 04:20:57 -0400
Received: by mail-it1-f194.google.com with SMTP id d6so876627itl.4
        for <netdev@vger.kernel.org>; Thu, 01 Nov 2018 16:15:55 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20181101070058.2760251-1-songliubraving@fb.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Thu, Nov 01, 2018 at 12:00:55AM -0700, Song Liu wrote:
> This set improves bpf program address showed in /proc/kallsyms and in
> bpf_prog_info. First, real program address is showed instead of page
> address. Second, when there is no subprogram, bpf_prog_info->jited_ksyms
> returns the main prog address.

For the set:
Acked-by: Alexei Starovoitov <ast@kernel.org>

I think we have to make the whole thing consistent like this set does
and send it to stable.
The only other alternative is to invent new cmd and prog_info fields to return
proper jited_ksyms and keep this one buggy forever.
My preference is to fix it.