From mboxrd@z Thu Jan  1 00:00:00 1970
From: hch@lst.de (Christoph Hellwig)
Date: Fri, 2 Nov 2018 06:41:39 +0100
Subject: [PATCH v3] nvme: make sure ns head inherits underlying device
 limits
In-Reply-To: <20181101160457.13391-1-sagi@grimberg.me>
References: <20181101160457.13391-1-sagi@grimberg.me>
Message-ID: <20181102054139.GA16212@lst.de>

> @@ -1482,6 +1482,7 @@ static bool nvme_ns_ids_equal(struct nvme_ns_ids *a, struct nvme_ns_ids *b)
>  static void nvme_update_disk_info(struct gendisk *disk,
>  		struct nvme_ns *ns, struct nvme_id_ns *id)
>  {
> +	struct nvme_ns *n;
>  	sector_t capacity = le64_to_cpup(&id->nsze) << (ns->lba_shift - 9);
>  	unsigned short bs = 1 << ns->lba_shift;
>  
> @@ -1506,6 +1507,9 @@ static void nvme_update_disk_info(struct gendisk *disk,
>  	else
>  		set_disk_ro(disk, false);
>  
> +	list_for_each_entry_rcu(n, &ns->head->list, siblings)
> +		blk_queue_stack_limits(disk->queue, n->queue);

I think this should only be done for ns->head_disk, nor the disks
attached to the namespaces.

> @@ -2960,6 +2964,10 @@ static struct nvme_ns_head *nvme_alloc_ns_head(struct nvme_ctrl *ctrl,
>  	if (ret)
>  		goto out_cleanup_srcu;
>  
> +#ifdef CONFIG_NVME_MULTIPATH
> +	blk_set_stacking_limits(&head->disk->queue->limits);
> +#endif

And this should probably done in nvme_mpath_alloc_disk.