From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [PATCH] ACPI / PMIC: xpower: fix IOSF_MBI dependency Date: Fri, 2 Nov 2018 17:16:44 +0200 Message-ID: <20181102151644.GB10650@smile.fi.intel.com> References: <20181102110653.118257-1-arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20181102110653.118257-1-arnd@arndb.de> Sender: linux-kernel-owner@vger.kernel.org To: Arnd Bergmann Cc: "Rafael J. Wysocki" , Len Brown , Hans de Goede , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-acpi@vger.kernel.org On Fri, Nov 02, 2018 at 12:06:43PM +0100, Arnd Bergmann wrote: > We still get a link failure with IOSF_MBI=m when the xpower driver > is built-in: > > drivers/acpi/pmic/intel_pmic_xpower.o: In function `intel_xpower_pmic_update_power': > intel_pmic_xpower.c:(.text+0x4f2): undefined reference to `iosf_mbi_block_punit_i2c_access' > intel_pmic_xpower.c:(.text+0x5e2): undefined reference to `iosf_mbi_unblock_punit_i2c_access' > > This makes the dependency stronger, so we can only build when IOSF_MBI > is built-in. > > Fixes: 6a9b593d4b6f ("ACPI / PMIC: xpower: Add depends on IOSF_MBI to Kconfig entry") > Signed-off-by: Arnd Bergmann > --- > drivers/acpi/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig > index 18851e7eedd5..31a3c4a03f61 100644 > --- a/drivers/acpi/Kconfig > +++ b/drivers/acpi/Kconfig > @@ -514,7 +514,7 @@ config CRC_PMIC_OPREGION > > config XPOWER_PMIC_OPREGION > bool "ACPI operation region support for XPower AXP288 PMIC" > - depends on MFD_AXP20X_I2C && IOSF_MBI > + depends on MFD_AXP20X_I2C && IOSF_MBI=y To me sounds like select IOSF_MBI would be more appropriate here. > help > This config adds ACPI operation region support for XPower AXP288 PMIC. -- With Best Regards, Andy Shevchenko