From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH v7 10/19] drm/i915/dsc: Compute Rate Control
 parameters for DSC
Date: Fri, 2 Nov 2018 19:52:22 +0200
Message-ID: <20181102175222.GX9144@intel.com>
References: <20181102064659.8991-1-manasi.d.navare@intel.com>
 <20181102064659.8991-11-manasi.d.navare@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Content-Disposition: inline
In-Reply-To: <20181102064659.8991-11-manasi.d.navare@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Manasi Navare <manasi.d.navare@intel.com>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

T24gVGh1LCBOb3YgMDEsIDIwMTggYXQgMTE6NDY6NTBQTSAtMDcwMCwgTWFuYXNpIE5hdmFyZSB3
cm90ZToKPiBGcm9tOiBHYXVyYXYgSyBTaW5naCA8Z2F1cmF2Lmsuc2luZ2hAaW50ZWwuY29tPgo+
IAo+IFRoaXMgY29tcHV0YXRpb24gb2YgUkMgcGFyYW1zIGhhcHBlbnMgaW4gdGhlIGF0b21pYyBj
b21taXQgcGhhc2UKPiBkdXJpbmcgY29tcHV0ZV9jb25maWcoKSB0byB2YWxpZGF0ZSBpZiBkaXNw
bGF5IHN0cmVhbSBjb21wcmVzc2lvbgo+IGNhbiBiZSBlbmFibGVkIGZvciB0aGUgcmVxdWVzdGVk
IG1vZGUuCj4gCj4gdjYgKEZyb20gTWFuYXNpKToKPiAqIFVzZSA5IGluc3RlYWQgb2YgMHg5IGZv
ciBjb25zaXN0ZW5jeSAoQW51c2hhKQo+IAo+IHY1IChGcm9tIE1hbmFzaSk6Cj4gKiBGaXggZGlt
IGNoZWNrcGF0Y2ggd2FybmluZ3MvY2hlY2tzCj4gdjQoRnJvbSBHYXVyYXYpOgo+ICogTm8gY2hh
bmdlLlJlYmFzZSBvbiBkcm0tdGlwCj4gCj4gdjMgKEZyb20gR2F1cmF2KToKPiAqIFJlYmFzZSBv
biB0b3Agb2YgTWFuYXNpJ3MgbGF0ZXN0IHNlcmllcwo+ICogUmV0dXJuIC12ZSB2YWx1ZSBpbiBj
YXNlIG9mIGZhaWx1cmUgc2NlbmFyaW9zIChNYW5hc2kpCj4gCj4gRml4IHJldmlldyBjb21tZW50
cyBmcm9tIFZpbGxlOgo+ICogUmVtb3ZlIHVubmVjZXNzYXJ5IGNvbW1lbnRzCj4gKiBSZW1vdmUg
dW5uZWNlc3NhcnkgcGFyYW50aGVzaXMKPiAqIEFkZCBjb21tZW50cyBmb3IgZmV3IFJDIHBhcmFt
cyBjYWxjdWxhdGlvbnMKPiAKPiB2MiAoRnJvbSBNYW5hc2kpOgo+ICogUmViYXNlIEdhdXJhdidz
IHBhdGNoIGZyb20gaW50ZWwtZ2Z4IHRvIGdmeC1pbnRlcm5hbAo+ICogVXNlIHN0cnVjdCBkcm1f
ZHNjX2NmZyBpbnN0ZWFkIG9mIHN0cnVjdCBpbnRlbF9kcAo+IGFzIGEgcGFyYW1ldGVyCj4gCj4g
Q2M6IE1hbmFzaSBOYXZhcmUgPG1hbmFzaS5kLm5hdmFyZUBpbnRlbC5jb20+Cj4gQ2M6IEphbmkg
TmlrdWxhIDxqYW5pLm5pa3VsYUBsaW51eC5pbnRlbC5jb20+Cj4gQ2M6IFZpbGxlIFN5cmphbGEg
PHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+IFNpZ25lZC1vZmYtYnk6IEdhdXJhdiBL
IFNpbmdoIDxnYXVyYXYuay5zaW5naEBpbnRlbC5jb20+Cj4gU2lnbmVkLW9mZi1ieTogTWFuYXNp
IE5hdmFyZSA8bWFuYXNpLmQubmF2YXJlQGludGVsLmNvbT4KPiBSZXZpZXdlZC1ieTogQW51c2hh
IFNyaXZhdHNhIDxhbnVzaGEuc3JpdmF0c2FAaW50ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dw
dS9kcm0vaTkxNS9pbnRlbF92ZHNjLmMgfCAxMjcgKysrKysrKysrKysrKysrKysrKysrKysrKysr
KysrCj4gIDEgZmlsZSBjaGFuZ2VkLCAxMjcgaW5zZXJ0aW9ucygrKQo+IAo+IGRpZmYgLS1naXQg
YS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF92ZHNjLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkx
NS9pbnRlbF92ZHNjLmMKPiBpbmRleCAwYTE5MThmMmY2NDMuLmI5M2NiMzIwMjZmYSAxMDA2NDQK
PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF92ZHNjLmMKPiArKysgYi9kcml2ZXJz
L2dwdS9kcm0vaTkxNS9pbnRlbF92ZHNjLmMKPiBAQCAtMzE3LDYgKzMxNywxMzAgQEAgc3RhdGlj
IGludCBnZXRfY29sdW1uX2luZGV4X2Zvcl9yY19wYXJhbXModTggYml0c19wZXJfY29tcG9uZW50
KQo+ICAJfQo+ICB9Cj4gIAo+ICtzdGF0aWMgaW50IGludGVsX2NvbXB1dGVfcmNfcGFyYW1ldGVy
cyhzdHJ1Y3QgZHJtX2RzY19jb25maWcgKnZkc2NfY2ZnKQo+ICt7Cj4gKwl1bnNpZ25lZCBsb25n
IGdyb3Vwc19wZXJfbGluZSA9IDA7Cj4gKwl1bnNpZ25lZCBsb25nIGdyb3Vwc190b3RhbCA9IDA7
Cj4gKwl1bnNpZ25lZCBsb25nIG51bV9leHRyYV9tdXhfYml0cyA9IDA7Cj4gKwl1bnNpZ25lZCBs
b25nIHNsaWNlX2JpdHMgPSAwOwo+ICsJdW5zaWduZWQgbG9uZyBocmRfZGVsYXkgPSAwOwo+ICsJ
dW5zaWduZWQgbG9uZyBmaW5hbF9zY2FsZSA9IDA7Cj4gKwl1bnNpZ25lZCBsb25nIHJic19taW4g
PSAwOwo+ICsKPiArCS8qIE51bWJlciBvZiBncm91cHMgdXNlZCB0byBjb2RlIGVhY2ggbGluZSBv
ZiBhIHNsaWNlICovCj4gKwlncm91cHNfcGVyX2xpbmUgPSBESVZfUk9VTkRfVVAodmRzY19jZmct
PnNsaWNlX3dpZHRoLAo+ICsJCQkJICAgICAgIERTQ19SQ19QSVhFTFNfUEVSX0dST1VQKTsKPiAr
Cj4gKwkvKiBjaHVua3NpemUgaW4gQnl0ZXMgKi8KPiArCXZkc2NfY2ZnLT5zbGljZV9jaHVua19z
aXplID0gRElWX1JPVU5EX1VQKHZkc2NfY2ZnLT5zbGljZV93aWR0aCAqCj4gKwkJCQkJCSAgdmRz
Y19jZmctPmJpdHNfcGVyX3BpeGVsLAo+ICsJCQkJCQkgICg4ICogMTYpKTsKPiArCj4gKwlpZiAo
dmRzY19jZmctPmNvbnZlcnRfcmdiKQo+ICsJCW51bV9leHRyYV9tdXhfYml0cyA9IDMgKiAodmRz
Y19jZmctPm11eF93b3JkX3NpemUgKwo+ICsJCQkJCSAgKDQgKiB2ZHNjX2NmZy0+Yml0c19wZXJf
Y29tcG9uZW50ICsgNCkKPiArCQkJCQkgIC0gMik7Cj4gKwllbHNlCj4gKwkJbnVtX2V4dHJhX211
eF9iaXRzID0gMyAqIHZkc2NfY2ZnLT5tdXhfd29yZF9zaXplICsKPiArCQkJKDQgKiB2ZHNjX2Nm
Zy0+Yml0c19wZXJfY29tcG9uZW50ICsgNCkgKwo+ICsJCQkyICogKDQgKiB2ZHNjX2NmZy0+Yml0
c19wZXJfY29tcG9uZW50KSAtIDI7Cj4gKwkvKiBOdW1iZXIgb2YgYml0cyBpbiBvbmUgU2xpY2Ug
Ki8KPiArCXNsaWNlX2JpdHMgPSA4ICogdmRzY19jZmctPnNsaWNlX2NodW5rX3NpemUgKiB2ZHNj
X2NmZy0+c2xpY2VfaGVpZ2h0Owo+ICsKPiArCXdoaWxlICgobnVtX2V4dHJhX211eF9iaXRzID4g
MCkgJiYKPiArCSAgICAgICAoKHNsaWNlX2JpdHMgLSBudW1fZXh0cmFfbXV4X2JpdHMpICUgdmRz
Y19jZmctPm11eF93b3JkX3NpemUpKQo+ICsJCW51bV9leHRyYV9tdXhfYml0cy0tOwo+ICsKPiAr
CWlmIChncm91cHNfcGVyX2xpbmUgPCB2ZHNjX2NmZy0+aW5pdGlhbF9zY2FsZV92YWx1ZSAtIDgp
Cj4gKwkJdmRzY19jZmctPmluaXRpYWxfc2NhbGVfdmFsdWUgPSBncm91cHNfcGVyX2xpbmUgKyA4
Owo+ICsKPiArCS8qIHNjYWxlX2RlY3JlbWVudF9pbnRlcnZhbCBjYWxjdWxhdGlvbiBhY2NvcmRp
bmcgdG8gRFNDIHNwZWMgMS4xMSAqLwo+ICsJaWYgKHZkc2NfY2ZnLT5pbml0aWFsX3NjYWxlX3Zh
bHVlID4gOCkKPiArCQl2ZHNjX2NmZy0+c2NhbGVfZGVjcmVtZW50X2ludGVydmFsID0gZ3JvdXBz
X3Blcl9saW5lIC8KPiArCQkJKHZkc2NfY2ZnLT5pbml0aWFsX3NjYWxlX3ZhbHVlIC0gOCk7Cj4g
KwllbHNlCj4gKwkJdmRzY19jZmctPnNjYWxlX2RlY3JlbWVudF9pbnRlcnZhbCA9IERTQ19TQ0FM
RV9ERUNSRU1FTlRfSU5URVJWQUxfTUFYOwo+ICsKPiArCXZkc2NfY2ZnLT5maW5hbF9vZmZzZXQg
PSB2ZHNjX2NmZy0+cmNfbW9kZWxfc2l6ZSAtCj4gKwkJKHZkc2NfY2ZnLT5pbml0aWFsX3htaXRf
ZGVsYXkgKgo+ICsJCSB2ZHNjX2NmZy0+Yml0c19wZXJfcGl4ZWwgKyA4KSAvIDE2ICsgbnVtX2V4
dHJhX211eF9iaXRzOwo+ICsKPiArCWlmICh2ZHNjX2NmZy0+ZmluYWxfb2Zmc2V0ID49IHZkc2Nf
Y2ZnLT5yY19tb2RlbF9zaXplKSB7Cj4gKwkJRFJNX0VSUk9SKCJGaW5hbE9mcyA8IFJjTW9kZWxT
emUgZm9yIHRoaXMgSW5pdGlhbFhtaXREZWxheVxuIik7CgpNb3JlIERSTV9FUlJPUigpcy4gQ2Fu
IHRoZSB1c2VyIHRyaWdnZXIgdGhlc2U/Cgo+ICsJCXJldHVybiAtRUlOVkFMOwo+ICsJfQo+ICsK
PiArCWZpbmFsX3NjYWxlID0gKHZkc2NfY2ZnLT5yY19tb2RlbF9zaXplICogOCkgLwo+ICsJCSh2
ZHNjX2NmZy0+cmNfbW9kZWxfc2l6ZSAtIHZkc2NfY2ZnLT5maW5hbF9vZmZzZXQpOwo+ICsJaWYg
KHZkc2NfY2ZnLT5zbGljZV9oZWlnaHQgPiAxKQo+ICsJCS8qCj4gKwkJICogTmZsQnBnT2Zmc2V0
IGlzIDE2IGJpdCB2YWx1ZSB3aXRoIDExIGZyYWN0aW9uYWwgYml0cwo+ICsJCSAqIGhlbmNlIHdl
IG11bHRpcGx5IGJ5IDJeMTEgZm9yIHByZXNlcnZpbmcgdGhlCj4gKwkJICogZnJhY3Rpb25hbCBw
YXJ0Cj4gKwkJICovCj4gKwkJdmRzY19jZmctPm5mbF9icGdfb2Zmc2V0ID0gRElWX1JPVU5EX1VQ
KCh2ZHNjX2NmZy0+Zmlyc3RfbGluZV9icGdfb2Zmc2V0IDw8IDExKSwKPiArCQkJCQkJCSh2ZHNj
X2NmZy0+c2xpY2VfaGVpZ2h0IC0gMSkpOwo+ICsJZWxzZQo+ICsJCXZkc2NfY2ZnLT5uZmxfYnBn
X29mZnNldCA9IDA7Cj4gKwo+ICsJLyogMl4xNiAtIDEgKi8KPiArCWlmICh2ZHNjX2NmZy0+bmZs
X2JwZ19vZmZzZXQgPiA2NTUzNSkgewo+ICsJCURSTV9FUlJPUigiTmZsQnBnT2Zmc2V0IGlzIHRv
byBsYXJnZSBmb3IgdGhpcyBzbGljZSBoZWlnaHRcbiIpOwo+ICsJCXJldHVybiAtRUlOVkFMOwo+
ICsJfQo+ICsKPiArCS8qIE51bWJlciBvZiBncm91cHMgdXNlZCB0byBjb2RlIHRoZSBlbnRpcmUg
c2xpY2UgKi8KPiArCWdyb3Vwc190b3RhbCA9IGdyb3Vwc19wZXJfbGluZSAqIHZkc2NfY2ZnLT5z
bGljZV9oZWlnaHQ7Cj4gKwo+ICsJLyogc2xpY2VfYnBnX29mZnNldCBpcyAxNiBiaXQgdmFsdWUg
d2l0aCAxMSBmcmFjdGlvbmFsIGJpdHMgKi8KPiArCXZkc2NfY2ZnLT5zbGljZV9icGdfb2Zmc2V0
ID0gRElWX1JPVU5EX1VQKCgodmRzY19jZmctPnJjX21vZGVsX3NpemUgLQo+ICsJCQkJCQkgICAg
dmRzY19jZmctPmluaXRpYWxfb2Zmc2V0ICsKPiArCQkJCQkJICAgIG51bV9leHRyYV9tdXhfYml0
cykgPDwgMTEpLAo+ICsJCQkJCQkgIGdyb3Vwc190b3RhbCk7Cj4gKwo+ICsJaWYgKGZpbmFsX3Nj
YWxlID4gOSkgewo+ICsJCS8qCj4gKwkJICogU2NhbGVJbmNyZW1lbnRJbnRlcnZhbCA9Cj4gKwkJ
ICogZmluYWxvZmZzZXQvKChOZmxCcGdPZmZzZXQgKyBTbGljZUJwZ09mZnNldCkqOChmaW5hbHNj
YWxlIC0gMS4xMjUpKQo+ICsJCSAqIGFzIChOZmxCcGdPZmZzZXQgKyBTbGljZUJwZ09mZnNldCkg
aGFzIDExIGJpdCBmcmFjdGlvbmFsIHZhbHVlLAo+ICsJCSAqIHdlIG5lZWQgZGl2aWRlIGJ5IDJe
MTEgZnJvbSBwc3REc2NDZmcgdmFsdWVzCj4gKwkJICovCj4gKwkJdmRzY19jZmctPnNjYWxlX2lu
Y3JlbWVudF9pbnRlcnZhbCA9Cj4gKwkJCQkodmRzY19jZmctPmZpbmFsX29mZnNldCAqICgxIDw8
IDExKSkgLwo+ICsJCQkJKCh2ZHNjX2NmZy0+bmZsX2JwZ19vZmZzZXQgKwo+ICsJCQkJdmRzY19j
ZmctPnNsaWNlX2JwZ19vZmZzZXQpKgo+ICsJCQkJKGZpbmFsX3NjYWxlIC0gOSkpOwo+ICsJfSBl
bHNlIHsKPiArCQkvKgo+ICsJCSAqIElmIGZpbmFsU2NhbGVWYWx1ZSBpcyBsZXNzIHRoYW4gb3Ig
ZXF1YWwgdG8gOSwgYSB2YWx1ZSBvZiAwIHNob3VsZAo+ICsJCSAqIGJlIHVzZWQgdG8gZGlzYWJs
ZSB0aGUgc2NhbGUgaW5jcmVtZW50IGF0IHRoZSBlbmQgb2YgdGhlIHNsaWNlCj4gKwkJICovCj4g
KwkJdmRzY19jZmctPnNjYWxlX2luY3JlbWVudF9pbnRlcnZhbCA9IDA7Cj4gKwl9Cj4gKwo+ICsJ
aWYgKHZkc2NfY2ZnLT5zY2FsZV9pbmNyZW1lbnRfaW50ZXJ2YWwgPiA2NTUzNSkgewo+ICsJCURS
TV9FUlJPUigiU2NhbGVJbmNyZW1lbnRJbnRlcnZhbCBpcyBsYXJnZSBmb3Igc2xpY2UgaGVpZ2h0
XG4iKTsKPiArCQlyZXR1cm4gLUVJTlZBTDsKPiArCX0KPiArCj4gKwkvKgo+ICsJICogRFNDIHNw
ZWMgbWVudGlvbnMgdGhhdCBiaXRzX3Blcl9waXhlbCBzcGVjaWZpZXMgdGhlIHRhcmdldAo+ICsJ
ICogYml0cy9waXhlbCAoYnBwKSByYXRlIHRoYXQgaXMgdXNlZCBieSB0aGUgZW5jb2RlciwKPiAr
CSAqIGluIHN0ZXBzIG9mIDEvMTYgb2YgYSBiaXQgcGVyIHBpeGVsCj4gKwkgKi8KPiArCXJic19t
aW4gPSB2ZHNjX2NmZy0+cmNfbW9kZWxfc2l6ZSAtIHZkc2NfY2ZnLT5pbml0aWFsX29mZnNldCAr
Cj4gKwkJRElWX1JPVU5EX1VQKHZkc2NfY2ZnLT5pbml0aWFsX3htaXRfZGVsYXkgKgo+ICsJCQkg
ICAgIHZkc2NfY2ZnLT5iaXRzX3Blcl9waXhlbCwgMTYpICsKPiArCQlncm91cHNfcGVyX2xpbmUg
KiB2ZHNjX2NmZy0+Zmlyc3RfbGluZV9icGdfb2Zmc2V0Owo+ICsKPiArCWhyZF9kZWxheSA9IERJ
Vl9ST1VORF9VUCgocmJzX21pbiAqIDE2KSwgdmRzY19jZmctPmJpdHNfcGVyX3BpeGVsKTsKPiAr
CXZkc2NfY2ZnLT5yY19iaXRzID0gKGhyZF9kZWxheSAqIHZkc2NfY2ZnLT5iaXRzX3Blcl9waXhl
bCkgLyAxNjsKPiArCXZkc2NfY2ZnLT5pbml0aWFsX2RlY19kZWxheSA9IGhyZF9kZWxheSAtIHZk
c2NfY2ZnLT5pbml0aWFsX3htaXRfZGVsYXk7Cj4gKwo+ICsJcmV0dXJuIDA7Cj4gK30KPiArCj4g
Kwo+ICBpbnQgaW50ZWxfZHBfY29tcHV0ZV9kc2NfcGFyYW1zKHN0cnVjdCBpbnRlbF9kcCAqaW50
ZWxfZHAsCj4gIAkJCQlzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqcGlwZV9jb25maWcpCj4gIHsK
PiBAQCAtNDUxLDUgKzU3NSw4IEBAIGludCBpbnRlbF9kcF9jb21wdXRlX2RzY19wYXJhbXMoc3Ry
dWN0IGludGVsX2RwICppbnRlbF9kcCwKPiAgCXZkc2NfY2ZnLT5pbml0aWFsX3NjYWxlX3ZhbHVl
ID0gKHZkc2NfY2ZnLT5yY19tb2RlbF9zaXplIDw8IDMpIC8KPiAgCQkodmRzY19jZmctPnJjX21v
ZGVsX3NpemUgLSB2ZHNjX2NmZy0+aW5pdGlhbF9vZmZzZXQpOwo+ICAKPiArCWlmIChpbnRlbF9j
b21wdXRlX3JjX3BhcmFtZXRlcnModmRzY19jZmcpIDwgMCkKPiArCQlyZXR1cm4gLTE7CgpKdXN0
IHBhc3Mgb24gdGhlIGVycm5vLgoKPiArCj4gIAlyZXR1cm4gMDsKPiAgfQo+IC0tIAo+IDIuMTgu
MAoKLS0gClZpbGxlIFN5cmrDpGzDpApJbnRlbApfX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0
cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s
aXN0aW5mby9pbnRlbC1nZngK