From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH v7 18/19] drm/i915/dsc: Enable and disable appropriate power wells for VDSC Date: Fri, 2 Nov 2018 19:53:07 +0200 Message-ID: <20181102175307.GZ9144@intel.com> References: <20181102064659.8991-1-manasi.d.navare@intel.com> <20181102064659.8991-19-manasi.d.navare@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20181102064659.8991-19-manasi.d.navare@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Manasi Navare Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Rodrigo Vivi List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBOb3YgMDEsIDIwMTggYXQgMTE6NDY6NThQTSAtMDcwMCwgTWFuYXNpIE5hdmFyZSB3 cm90ZToKPiBBIHNlcGFyYXRlIHBvd2VyIHdlbGwgMiAoUEcyKSBpcyByZXF1aXJlZCBmb3IgVkRT QyBvbiBlRFAgdHJhbnNjb2Rlcgo+IHdoZXJlYXMgYWxsIG90aGVyIHRyYW5zY29kZXJzIHVzZSB0 aGUgcG93ZXIgd2VsbHMgYXNzb2NpYXRlZCB3aXRoIHRoZQo+IHRyYW5zY29kZXJzIGZvciBWRFND Lgo+IFRoaXMgcGF0Y2ggYWRkcyBhIGhlbHBlciB0byBvYnRhaW4gY29ycmVjdCBwb3dlciBkb21h aW4gZGVwZW5kaW5nIG9uCj4gdHJhbnNjb2RlciBiZWluZyB1c2VkIGFuZCBlbmFibGVzL2Rpc2Fi bGVzIHRoZSBwb3dlciB3ZWxscyBkdXJpbmcKPiBWRFNDIGVuYWJsaW5nL2Rpc2FibGluZy4KPiAK PiB2MzoKPiAqIENhbGwgaXQgaW50ZWxfZHNjX3Bvd2VyX2RvbWFpbiwgYWRkIHRvCj4gaW50ZWxf ZGRpX2dldF9wb3dlcl9kb21haW5zIChWaWxsZSkKPiB2MjoKPiAqIEZpeCB0YWJzLCBjb25zdCBj cnRjX3N0YXRlLCBmaXggY29tbWVudHMgKFZpbGxlKQo+IAo+IFN1Z2dlc3RlZC1ieTogVmlsbGUg U3lyamFsYSA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gQ2M6IFZpbGxlIFN5cmph bGEgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+IENjOiBJbXJlIERlYWsgPGltcmUu ZGVha0BpbnRlbC5jb20+Cj4gQ2M6IFJvZHJpZ28gVml2aSA8cm9kcmlnby52aXZpQGludGVsLmNv bT4KPiBTaWduZWQtb2ZmLWJ5OiBNYW5hc2kgTmF2YXJlIDxtYW5hc2kuZC5uYXZhcmVAaW50ZWwu Y29tPgo+IFJldmlld2VkLWJ5OiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXgu aW50ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kZGkuYyAgfCAg MyArKy0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmggIHwgIDIgKysKPiAgZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfdmRzYy5jIHwgMjUgKysrKysrKysrKysrKysrKysrKysr KysrKwo+ICAzIGZpbGVzIGNoYW5nZWQsIDI5IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkK PiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGRpLmMgYi9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kZGkuYwo+IGluZGV4IGFmMTJjMTVlZDk0Zi4uYzI0M2Ji M2YyYmU5IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RkaS5jCj4g KysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGRpLmMKPiBAQCAtMjEyNCw3ICsyMTI0 LDggQEAgc3RhdGljIHU2NCBpbnRlbF9kZGlfZ2V0X3Bvd2VyX2RvbWFpbnMoc3RydWN0IGludGVs X2VuY29kZXIgKmVuY29kZXIsCj4gIAkgKi8KPiAgCWlmIChpbnRlbF9jcnRjX2hhc19kcF9lbmNv ZGVyKGNydGNfc3RhdGUpIHx8Cj4gIAkgICAgaW50ZWxfcG9ydF9pc190YyhkZXZfcHJpdiwgZW5j b2Rlci0+cG9ydCkpCj4gLQkJZG9tYWlucyB8PSBCSVRfVUxMKGludGVsX2RkaV9tYWluX2xpbmtf YXV4X2RvbWFpbihkaWdfcG9ydCkpOwo+ICsJCWRvbWFpbnMgfD0gQklUX1VMTChpbnRlbF9kZGlf bWFpbl9saW5rX2F1eF9kb21haW4oZGlnX3BvcnQpKSB8Cj4gKwkJCUJJVF9VTEwoaW50ZWxfZHNj X3Bvd2VyX2RvbWFpbihjcnRjX3N0YXRlKSk7CgppZiAoY3J0Y19zdGF0ZS0+c29tZXRoaW5nKQoJ ZG9tYWlucyB8PSAuLi47Cgo+ICAKPiAgCXJldHVybiBkb21haW5zOwo+ICB9Cj4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oIGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfZHJ2LmgKPiBpbmRleCBlNTM3NTYxYjNkNDAuLjJkNDFkZmY2ZWVkMSAxMDA2NDQK PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaAo+ICsrKyBiL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2Rydi5oCj4gQEAgLTE4NTksNiArMTg1OSw4IEBAIHVpbnQ4X3Qg aW50ZWxfZHBfZHNjX2dldF9zbGljZV9jb3VudChzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwLCBp bnQgbW9kZV9jbG9jaywKPiAgLyogaW50ZWxfdmRzYy5jICovCj4gIGludCBpbnRlbF9kcF9jb21w dXRlX2RzY19wYXJhbXMoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCwKPiAgCQkJCXN0cnVjdCBp bnRlbF9jcnRjX3N0YXRlICpwaXBlX2NvbmZpZyk7Cj4gK2VudW0gaW50ZWxfZGlzcGxheV9wb3dl cl9kb21haW4KPiAraW50ZWxfZHNjX3Bvd2VyX2RvbWFpbihjb25zdCBzdHJ1Y3QgaW50ZWxfY3J0 Y19zdGF0ZSAqY3J0Y19zdGF0ZSk7Cj4gIAo+ICBzdGF0aWMgaW5saW5lIHVuc2lnbmVkIGludCBp bnRlbF9kcF91bnVzZWRfbGFuZV9tYXNrKGludCBsYW5lX2NvdW50KQo+ICB7Cj4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Zkc2MuYyBiL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX3Zkc2MuYwo+IGluZGV4IDIxOWRjMTUxN2M4YS4uOWVhZTAzN2EzYjRkIDEwMDY0 NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Zkc2MuYwo+ICsrKyBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX3Zkc2MuYwo+IEBAIC01ODEsNiArNTgxLDI0IEBAIGludCBp bnRlbF9kcF9jb21wdXRlX2RzY19wYXJhbXMoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCwKPiAg CXJldHVybiAwOwo+ICB9Cj4gIAo+ICtlbnVtIGludGVsX2Rpc3BsYXlfcG93ZXJfZG9tYWluCj4g K2ludGVsX2RzY19wb3dlcl9kb21haW4oY29uc3Qgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNy dGNfc3RhdGUpCj4gK3sKPiArCWVudW0gdHJhbnNjb2RlciBjcHVfdHJhbnNjb2RlciA9IGNydGNf c3RhdGUtPmNwdV90cmFuc2NvZGVyOwo+ICsKPiArCS8qCj4gKwkgKiBPbiBJQ0wgVkRTQy9qb2lu aW5nIGZvciBlRFAgdHJhbnNjb2RlciB1c2VzIGEgc2VwYXJhdGUgcG93ZXIgd2VsbCBQVzIKPiAr CSAqIFRoaXMgcmVxdWlyZXMgUE9XRVJfRE9NQUlOX1RSQU5TQ09ERVJfRURQX1ZEU0MgcG93ZXIg ZG9tYWluLgo+ICsJICogRm9yIGFueSBvdGhlciB0cmFuc2NvZGVyLCBWRFNDL2pvaW5pbmcgdXNl cyB0aGUgcG93ZXIgd2VsbCBhc3NvY2lhdGVkCj4gKwkgKiB3aXRoIHRoZSBwaXBlL3RyYW5zY29k ZXIgaW4gdXNlLiBIZW5jZSBhbm90aGVyIHJlZmVyZW5jZSBvbiB0aGUKPiArCSAqIHRyYW5zY29k ZXIgcG93ZXIgZG9tYWluIHdpbGwgc3VmZmljZS4KPiArCSAqLwo+ICsJaWYgKGNwdV90cmFuc2Nv ZGVyID09IFRSQU5TQ09ERVJfRURQKQo+ICsJCXJldHVybiBQT1dFUl9ET01BSU5fVFJBTlNDT0RF Ul9FRFBfVkRTQzsKPiArCWVsc2UKPiArCQlyZXR1cm4gUE9XRVJfRE9NQUlOX1RSQU5TQ09ERVIo Y3B1X3RyYW5zY29kZXIpOwo+ICt9Cj4gKwo+ICBzdGF0aWMgdm9pZCBpbnRlbF9jb25maWd1cmVf cHBzX2Zvcl9kc2NfZW5jb2RlcihzdHJ1Y3QgaW50ZWxfZW5jb2RlciAqZW5jb2RlciwKPiAgCQkJ CQkJY29uc3Qgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNydGNfc3RhdGUpCj4gIHsKPiBAQCAt MTAyMCw2ICsxMDM4LDEwIEBAIHZvaWQgaW50ZWxfZHNjX2VuYWJsZShzdHJ1Y3QgaW50ZWxfZW5j b2RlciAqZW5jb2RlciwKPiAgCWlmICghY3J0Y19zdGF0ZS0+ZHNjX3BhcmFtcy5jb21wcmVzc2lv bl9lbmFibGUpCj4gIAkJcmV0dXJuOwo+ICAKPiArCS8qIEVuYWJsZSBQb3dlciB3ZWxscyBmb3Ig VkRTQy9qb2luaW5nICovCj4gKwlpbnRlbF9kaXNwbGF5X3Bvd2VyX2dldChkZXZfcHJpdiwKPiAr CQkJCWludGVsX2RzY19wb3dlcl9kb21haW4oY3J0Y19zdGF0ZSkpOwo+ICsKPiAgCWludGVsX2Nv bmZpZ3VyZV9wcHNfZm9yX2RzY19lbmNvZGVyKGVuY29kZXIsIGNydGNfc3RhdGUpOwo+ICAKPiAg CWludGVsX2RwX3dyaXRlX2RzY19wcHNfc2RwKGVuY29kZXIsIGNydGNfc3RhdGUpOwo+IEBAIC0x MDcyLDQgKzEwOTQsNyBAQCB2b2lkIGludGVsX2RzY19kaXNhYmxlKGNvbnN0IHN0cnVjdCBpbnRl bF9jcnRjX3N0YXRlICpvbGRfY3J0Y19zdGF0ZSkKPiAgCQkJCSAgUklHSFRfQlJBTkNIX1ZEU0Nf RU5BQkxFKTsKPiAgCUk5MTVfV1JJVEUoZHNzX2N0bDJfcmVnLCBkc3NfY3RsMl92YWwpOwo+ICAK PiArCS8qIERpc2FibGUgUG93ZXIgd2VsbHMgZm9yIFZEU0Mvam9pbmluZyAqLwo+ICsJaW50ZWxf ZGlzcGxheV9wb3dlcl9wdXQoZGV2X3ByaXYsCj4gKwkJCQlpbnRlbF9kc2NfcG93ZXJfZG9tYWlu KG9sZF9jcnRjX3N0YXRlKSk7Cj4gIH0KPiAtLSAKPiAyLjE4LjAKCi0tIApWaWxsZSBTeXJqw6Rs w6QKSW50ZWwKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K ZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0 dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==