From: Petr Vorel <petr.vorel@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] merge_config.sh: Fix merging buildroot config files
Date: Fri, 2 Nov 2018 23:50:58 +0100 [thread overview]
Message-ID: <20181102225056.GB11633@dell5510> (raw)
In-Reply-To: <4c5ee82c-00eb-33e6-6ec1-fc4f21eba039@mind.be>
Hi Arnout,
> > How about this?
> > https://patchwork.kernel.org/patch/10665119/
> Perhaps it's better to make the entire pattern explicit, like:
> SED_CONFIG_EXP="s/^\(${CONFIG_PREFIX}[a-zA-Z0-9_]*\)=.*$\|^#
> \(${CONFIG_PREFIX}[a-zA-Z0-9_]*\) is not set$/\1\2/p"
> (\1\2 works because only one of the two subexpressions matches, so either \1 or
> \2 must be empty).
I'd prefer original Masahiro's version - it's easier to read and without
duplicity.
> Regards,
> Arnout
Kind regards,
Petr
next prev parent reply other threads:[~2018-11-02 22:50 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-19 22:58 [Buildroot] [PATCH] merge_config.sh: Fix finding redundant config mechanism Nasser
2018-10-20 14:56 ` Matthew Weber
2018-10-20 16:01 ` Arnout Vandecappelle
2018-10-21 17:27 ` Petr Vorel
2018-10-21 17:35 ` Matthew Weber
2018-10-21 17:46 ` Petr Vorel
2018-10-23 15:19 ` Nasser Afshin
2018-10-23 18:20 ` Arnout Vandecappelle
2018-10-24 19:15 ` Petr Vorel
2018-10-24 23:00 ` Nasser
2018-10-25 1:13 ` [Buildroot] [PATCH v2] merge_config.sh: merge also buildroot config files Nasser Afshin
2018-10-25 1:19 ` Nasser
2018-10-25 2:20 ` [Buildroot] [PATCH v3] " Nasser Afshin
2018-10-25 6:02 ` [Buildroot] Antwort: " Marcel Patzlaff
2018-10-25 7:43 ` [Buildroot] " Petr Vorel
2018-10-25 9:43 ` [Buildroot] Antwort: " Marcel Patzlaff
2018-10-25 21:43 ` Petr Vorel
2018-10-26 6:03 ` [Buildroot] Antwort: " Marcel Patzlaff
2018-10-26 23:05 ` Nasser
2018-10-27 4:46 ` Petr Vorel
2018-10-27 10:48 ` Nasser Afshin
2018-10-31 19:35 ` [Buildroot] " Petr Vorel
2018-10-31 20:38 ` Nasser
2018-10-31 20:56 ` Petr Vorel
2018-11-01 1:09 ` [Buildroot] [PATCH] merge_config.sh: Fix merging " Nasser Afshin
2018-11-01 3:51 ` yamada.masahiro at socionext.com
2018-11-01 5:49 ` Petr Vorel
2018-11-01 8:12 ` Nasser
2018-11-01 6:24 ` Petr Vorel
2018-11-01 10:55 ` Nasser
2018-11-01 12:05 ` Arnout Vandecappelle
2018-11-01 16:19 ` Petr Vorel
2018-11-02 2:12 ` Nasser
2018-11-02 7:55 ` yamada.masahiro at socionext.com
2018-11-02 10:05 ` Arnout Vandecappelle
2018-11-02 22:50 ` Petr Vorel [this message]
2018-11-03 21:32 ` Nasser
2018-11-05 8:23 ` yamada.masahiro at socionext.com
2018-11-05 8:35 ` Petr Vorel
2018-11-13 13:44 ` [Buildroot] [PATCH v3 0/3] Fix merging configuration fragments Nasser Afshin
2018-11-13 13:44 ` [Buildroot] [PATCH v3 1/3] merge_config.sh: Fix merging buildroot config files Nasser Afshin
2018-11-13 18:35 ` Petr Vorel
2018-11-14 7:16 ` Nasser Afshin
2018-11-13 13:44 ` [Buildroot] [PATCH v3 2/3] test-pkg: Use the correct config prefix when merging Nasser Afshin
2018-11-13 18:26 ` Petr Vorel
2018-11-13 13:44 ` [Buildroot] [PATCH v3 3/3] merge_config.sh: Avoid false positive matches from comment lines Nasser Afshin
2018-11-13 18:38 ` Petr Vorel
2018-11-14 7:18 ` [Buildroot] [PATCH v3 0/3] Fix merging configuration fragments Nasser Afshin
2018-11-01 13:23 ` [Buildroot] [PATCH] merge_config.sh: Fix merging buildroot config files Petr Vorel
2018-11-02 2:18 ` Nasser
2018-10-29 15:46 ` [Buildroot] Antwort: Re: Antwort: Re: [PATCH v3] merge_config.sh: merge also " Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181102225056.GB11633@dell5510 \
--to=petr.vorel@gmail.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.