From mboxrd@z Thu Jan  1 00:00:00 1970
From: Imre Deak <imre.deak@intel.com>
Subject: Re: [PATCH 3/4] drm/i915/icl: Only grab TC ports when
 using it
Date: Sat, 3 Nov 2018 01:06:03 +0200
Message-ID: <20181102230603.GG21181@ideak-desk.fi.intel.com>
References: <20181102203924.10870-1-jose.souza@intel.com>
 <20181102203924.10870-3-jose.souza@intel.com>
Reply-To: imre.deak@intel.com
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga17.intel.com (mga17.intel.com [192.55.52.151])
 by gabe.freedesktop.org (Postfix) with ESMTPS id C00D06E61F
 for <intel-gfx@lists.freedesktop.org>; Fri,  2 Nov 2018 23:06:05 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <20181102203924.10870-3-jose.souza@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: =?iso-8859-1?Q?Jos=E9?= Roberto de Souza <jose.souza@intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gRnJpLCBOb3YgMDIsIDIwMTggYXQgMDE6Mzk6MjNQTSAtMDcwMCwgSm9zw6kgUm9iZXJ0byBk
ZSBTb3V6YSB3cm90ZToKPiBXaGVuIHN1c3BlbmRpbmcgb3IgdW5sb2FkaW5nIHRoZSBkcml2ZXIs
IGl0IG5lZWRzIHRvIHJlbGVhc2UgdGhlCj4gVEMgcG9ydHMgc28gSFcgY2FuIGNoYW5nZSBpdCBz
dGF0ZSB3aXRob3V0IHdhaXQgZm9yIGRyaXZlciBoYW5kc2hha2UuCj4gU3BlYyBhbHNvIHN0YXRl
IHRoYXQgaWYgdGhlIHBvcnQgaXMgbm90IHVzZWQgYnkgZHJpdmVyIGl0IHNob3VsZAo+IHJlbGVh
c2UgVEMgYWNjZXNzLCBzbyBoZXJlIG9ubHkgZ3JhYmJpbmcgY29udHJvbCBvZiB0aGUgVEMgcG9y
dHMgYW5kCj4gbWFya2luZyBhcyB1bnNhZmUgd2hlbiBhdXggcG93ZXIgaXMgbmVlZGVkIGFzIGhh
dmUgYXV4IHBvd2VyIHdlbGwgaXMKPiBhIHJlcXVpcmVtZW50IHRvIGhhdmUgRERJIGVuYWJsZWQg
aW4gVEMgcG9ydHMsIHRoZSBwcmVfcGxsX2VuYWJsZSBhbmQKPiBwb3N0X3BsbF9kaXNhYmxlIGhv
b2tzIHRha2VzIGNhcmUgb2YgZ2V0dGluZyBhbmQgcmVsZWFzaW5nIGl0Lgo+IAo+IEJTcGVjOiAy
MTc1MAo+IAo+IENjOiBJbXJlIERlYWsgPGltcmUuZGVha0BpbnRlbC5jb20+Cj4gQ2M6IFZpbGxl
IFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gU2lnbmVkLW9mZi1i
eTogSm9zw6kgUm9iZXJ0byBkZSBTb3V6YSA8am9zZS5zb3V6YUBpbnRlbC5jb20+CgpBZ3JlZWQg
dGhhdCB3ZSBzaG91bGQgZm9yY2UgYSBtYW51YWwgZGlzY29ubmVjdCBiZWZvcmUgZW50ZXJpbmcK
bG93LXBvd2VyIHN0YXRlcyBhbmQgZHJpdmVyIHVubG9hZGluZywgYnV0IEkgZG9uJ3QgdGhpbmsg
dGhpcyBzaG91bGQgYmUKZG9uZSBmcm9tIHRoZSBwb3dlciB3ZWxsIGNvZGUuIFdlIGNvdWxkIHBl
cmZvcm0gbXVsdGlwbGUgQVVYIHRyYW5zZmVycwphZnRlciBhIGNvbm5lY3QgZXZlbnQgYXJvdW5k
IGVhY2ggb2Ygd2hpY2ggd2Ugd291bGQgZW5hYmxlL2Rpc2FibGUgdGhlCkFVWCBwb3dlciB3ZWxs
LiBXZSB3b3VsZCB0aGVuIGxpa2VseSBjb250aW51ZSBkb2luZyBhIG1vZGVzZXQuIER1cmluZwp0
aGlzIHdob2xlIHNlcXVlbmNlIEkgZG9uJ3QgdGhpbmsgd2Ugc2hvdWxkIGRvIGZvcmNlZApjb25u
ZWN0cy9kaXNjb25uZWN0cyBkdWUgdG8gdGhlIEFVWCBwb3dlciB3ZWxsIGdldHRpbmcgZW5hYmxl
ZC9kaXNhYmxlZC4KCkkgdGhpbmsgbm9ybWFsbHkgd2Ugc2hvdWxkIGNoYW5nZSB0aGUgY29ubmVj
dGlvbiBzdGF0dXMgKHRoYXQgaXMgdGhlCnNhZmUvdW5zYWZlIG1vZGUgeW91J3JlIHNldHRpbmcg
aGVyZSkgaW4gcmVzcG9uc2UgdG8gSFBEIGV2ZW50cywgYWxzbwpjb25zaWRlcmluZyB0aGF0IHdl
IG1heSBoYXZlIHRvIGRlbGF5IGNoYW5naW5nIHRoZSBzdGF0ZSBhcyBkaXNjdXNzZWQKZWFybGll
ciB3aXRoIFZpbGxlIChkdWUgdG8gYW4gb25nb2luZyBBVVggdHJhbnNmZXIgb3IgYWN0aXZlIG1v
ZGUgaW4gdGhlCm9wcG9zaXRlIFR5cGVDIG1vZGUpLiBUaGVuIG9ubHkgZHVyaW5nIHN5c3RlbS9y
dW50aW1lIHN1c3BlbmQgYW5kIHVubG9hZApzaG91bGQgd2UgZG8gYSBmb3JjZWQgZGlzY29ubmVj
dCwgd2hpY2ggd291bGQgYmUgc2FmZSBzaW5jZSBhdCB0aG9zZQpwb2ludHMgd2UgZG9uJ3QgaGF2
ZSBhbnkgcGVuZGluZyBBVVggdHJhbnNmZXJzIG9yIGFjdGl2ZSBvdXRwdXRzLgoKLS1JbXJlCgo+
IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jICAgICAgICAgfCAyOCAtLS0t
LS0tLS0tLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3J1bnRpbWVfcG0uYyB8IDU1
ICsrKysrKysrKysrKysrKysrKysrKysrKy0KPiAgMiBmaWxlcyBjaGFuZ2VkLCA1NCBpbnNlcnRp
b25zKCspLCAyOSBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJt
L2k5MTUvaW50ZWxfZHAuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMKPiBpbmRl
eCA1MmE1NGVmNzQ2YWYuLmQ5NzgxMjdlNzIwOCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9k
cm0vaTkxNS9pbnRlbF9kcC5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAu
Ywo+IEBAIC01MDEzLDE2ICs1MDEzLDYgQEAgc3RhdGljIGJvb2wgaWNsX3RjX3BoeV9jb25uZWN0
KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiAgCQlyZXR1cm4gZmFsc2U7Cj4g
IAl9Cj4gIAo+IC0JLyoKPiAtCSAqIFRoaXMgZnVuY3Rpb24gbWF5IGJlIGNhbGxlZCBtYW55IHRp
bWVzIGluIGEgcm93IHdpdGhvdXQgYW4gSFBEIGV2ZW50Cj4gLQkgKiBpbiBiZXR3ZWVuLCBzbyB0
cnkgdG8gYXZvaWQgdGhlIHdyaXRlIHdoZW4gd2UgY2FuLgo+IC0JICovCj4gLQl2YWwgPSBJOTE1
X1JFQUQoUE9SVF9UWF9ERkxFWERQQ1NTUyk7Cj4gLQlpZiAoISh2YWwgJiBEUF9QSFlfTU9ERV9T
VEFUVVNfTk9UX1NBRkUodGNfcG9ydCkpKSB7Cj4gLQkJdmFsIHw9IERQX1BIWV9NT0RFX1NUQVRV
U19OT1RfU0FGRSh0Y19wb3J0KTsKPiAtCQlJOTE1X1dSSVRFKFBPUlRfVFhfREZMRVhEUENTU1Ms
IHZhbCk7Cj4gLQl9Cj4gLQo+ICAJLyoKPiAgCSAqIE5vdyB3ZSBoYXZlIHRvIHJlLWNoZWNrIHRo
ZSBsaXZlIHN0YXRlLCBpbiBjYXNlIHRoZSBwb3J0IHJlY2VudGx5Cj4gIAkgKiBiZWNhbWUgZGlz
Y29ubmVjdGVkLiBOb3QgbmVjZXNzYXJ5IGZvciBsZWdhY3kgbW9kZS4KPiBAQCAtNTA0NCwyNCAr
NTAzNCw2IEBAIHN0YXRpYyBib29sIGljbF90Y19waHlfY29ubmVjdChzdHJ1Y3QgZHJtX2k5MTVf
cHJpdmF0ZSAqZGV2X3ByaXYsCj4gIHN0YXRpYyB2b2lkIGljbF90Y19waHlfZGlzY29ubmVjdChz
dHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gIAkJCQkgIHN0cnVjdCBpbnRlbF9k
aWdpdGFsX3BvcnQgKmRpZ19wb3J0KQo+ICB7Cj4gLQllbnVtIHRjX3BvcnQgdGNfcG9ydCA9IGlu
dGVsX3BvcnRfdG9fdGMoZGV2X3ByaXYsIGRpZ19wb3J0LT5iYXNlLnBvcnQpOwo+IC0KPiAtCWlm
IChkaWdfcG9ydC0+dGNfdHlwZSA9PSBUQ19QT1JUX1VOS05PV04pCj4gLQkJcmV0dXJuOwo+IC0K
PiAtCS8qCj4gLQkgKiBUQlQgZGlzY29ubmVjdGlvbiBmbG93IGlzIHJlYWQgdGhlIGxpdmUgc3Rh
dHVzLCB3aGF0IHdhcyBkb25lIGluCj4gLQkgKiBjYWxsZXIuCj4gLQkgKi8KPiAtCWlmIChkaWdf
cG9ydC0+dGNfdHlwZSA9PSBUQ19QT1JUX1RZUEVDIHx8Cj4gLQkgICAgZGlnX3BvcnQtPnRjX3R5
cGUgPT0gVENfUE9SVF9MRUdBQ1kpIHsKPiAtCQl1MzIgdmFsOwo+IC0KPiAtCQl2YWwgPSBJOTE1
X1JFQUQoUE9SVF9UWF9ERkxFWERQQ1NTUyk7Cj4gLQkJdmFsICY9IH5EUF9QSFlfTU9ERV9TVEFU
VVNfTk9UX1NBRkUodGNfcG9ydCk7Cj4gLQkJSTkxNV9XUklURShQT1JUX1RYX0RGTEVYRFBDU1NT
LCB2YWwpOwo+IC0JfQo+IC0KPiAgCWRpZ19wb3J0LT50Y190eXBlID0gVENfUE9SVF9VTktOT1dO
Owo+ICB9Cj4gIAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ydW50
aW1lX3BtLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ydW50aW1lX3BtLmMKPiBpbmRl
eCA2YzQ1MzM2NmNkMjQuLmRhYjVmOTA2NDZjNCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9k
cm0vaTkxNS9pbnRlbF9ydW50aW1lX3BtLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p
bnRlbF9ydW50aW1lX3BtLmMKPiBAQCAtNDY1LDYgKzQ2NSw0OCBAQCBpY2xfY29tYm9fcGh5X2F1
eF9wb3dlcl93ZWxsX2Rpc2FibGUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+
ICAJaHN3X3dhaXRfZm9yX3Bvd2VyX3dlbGxfZGlzYWJsZShkZXZfcHJpdiwgcG93ZXJfd2VsbCk7
Cj4gIH0KPiAgCj4gK3N0YXRpYyB2b2lkIGljbF90Y19ncmFiX2NvbnRyb2woc3RydWN0IGRybV9p
OTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICsJCQkJZW51bSBhdXhfY2ggYXV4X2NoLCBib29sIGdy
YWIpCj4gK3sKPiArCXN0cnVjdCBkcm1fZGV2aWNlICpkZXYgPSAmZGV2X3ByaXYtPmRybTsKPiAr
CXN0cnVjdCBkcm1fY29ubmVjdG9yX2xpc3RfaXRlciBjb25uX2l0ZXI7Cj4gKwlzdHJ1Y3QgZHJt
X2Nvbm5lY3RvciAqY29ubmVjdG9yOwo+ICsKPiArCWRybV9jb25uZWN0b3JfbGlzdF9pdGVyX2Jl
Z2luKGRldiwgJmNvbm5faXRlcik7Cj4gKwlkcm1fZm9yX2VhY2hfY29ubmVjdG9yX2l0ZXIoY29u
bmVjdG9yLCAmY29ubl9pdGVyKSB7Cj4gKwkJc3RydWN0IGludGVsX2Nvbm5lY3RvciAqaW50ZWxf
Y29ubmVjdG9yOwo+ICsJCXN0cnVjdCBpbnRlbF9lbmNvZGVyICppbnRlbF9lbmNvZGVyOwo+ICsJ
CXN0cnVjdCBpbnRlbF9kaWdpdGFsX3BvcnQgKmRpZ19wb3J0Owo+ICsJCWVudW0gdGNfcG9ydCB0
Y19wb3J0Owo+ICsKPiArCQlpbnRlbF9jb25uZWN0b3IgPSB0b19pbnRlbF9jb25uZWN0b3IoY29u
bmVjdG9yKTsKPiArCQlpZiAoIWludGVsX2Nvbm5lY3Rvci0+ZW5jb2RlcikKPiArCQkJY29udGlu
dWU7Cj4gKwkJaW50ZWxfZW5jb2RlciA9IGludGVsX2Nvbm5lY3Rvci0+ZW5jb2RlcjsKPiArCQlk
aWdfcG9ydCA9IGVuY190b19kaWdfcG9ydCgmaW50ZWxfZW5jb2Rlci0+YmFzZSk7Cj4gKwo+ICsJ
CWlmICghZGlnX3BvcnQgfHwgZGlnX3BvcnQtPmF1eF9jaCAhPSBhdXhfY2gpCj4gKwkJCWNvbnRp
bnVlOwo+ICsKPiArCQl0Y19wb3J0ID0gaW50ZWxfcG9ydF90b190YyhkZXZfcHJpdiwgZGlnX3Bv
cnQtPmJhc2UucG9ydCk7Cj4gKwo+ICsJCWlmIChkaWdfcG9ydC0+dGNfdHlwZSA9PSBUQ19QT1JU
X1RZUEVDIHx8Cj4gKwkJICAgIGRpZ19wb3J0LT50Y190eXBlID09IFRDX1BPUlRfTEVHQUNZKSB7
Cj4gKwkJCXUzMiB2YWw7Cj4gKwo+ICsJCQl2YWwgPSBJOTE1X1JFQUQoUE9SVF9UWF9ERkxFWERQ
Q1NTUyk7Cj4gKwkJCWlmIChncmFiKQo+ICsJCQkJdmFsIHw9IERQX1BIWV9NT0RFX1NUQVRVU19O
T1RfU0FGRSh0Y19wb3J0KTsKPiArCQkJZWxzZQo+ICsJCQkJdmFsICY9IH5EUF9QSFlfTU9ERV9T
VEFUVVNfTk9UX1NBRkUodGNfcG9ydCk7Cj4gKwkJCUk5MTVfV1JJVEUoUE9SVF9UWF9ERkxFWERQ
Q1NTUywgdmFsKTsKPiArCQl9Cj4gKwo+ICsJCWJyZWFrOwo+ICsJfQo+ICsJZHJtX2Nvbm5lY3Rv
cl9saXN0X2l0ZXJfZW5kKCZjb25uX2l0ZXIpOwo+ICt9Cj4gKwo+ICAjZGVmaW5lIElDTF9BVVhf
UFdfVE9fQ0gocHdfaWR4KQlcCj4gIAkoKHB3X2lkeCkgLSBJQ0xfUFdfQ1RMX0lEWF9BVVhfQSAr
IEFVWF9DSF9BKQo+ICAKPiBAQCAtNDc1LDYgKzUxNyw4IEBAIGljbF90Y19waHlfYXV4X3Bvd2Vy
X3dlbGxfZW5hYmxlKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiAgCWVudW0g
YXV4X2NoIGF1eF9jaCA9IElDTF9BVVhfUFdfVE9fQ0gocG93ZXJfd2VsbC0+ZGVzYy0+aHN3Lmlk
eCk7Cj4gIAl1MzIgdmFsOwo+ICAKPiArCWljbF90Y19ncmFiX2NvbnRyb2woZGV2X3ByaXYsIGF1
eF9jaCwgdHJ1ZSk7Cj4gKwo+ICAJdmFsID0gSTkxNV9SRUFEKERQX0FVWF9DSF9DVEwoYXV4X2No
KSk7Cj4gIAl2YWwgJj0gfkRQX0FVWF9DSF9DVExfVEJUX0lPOwo+ICAJaWYgKHBvd2VyX3dlbGwt
PmRlc2MtPmhzdy5pc190Y190YnQpCj4gQEAgLTQ4NCw2ICs1MjgsMTUgQEAgaWNsX3RjX3BoeV9h
dXhfcG93ZXJfd2VsbF9lbmFibGUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+
ICAJaHN3X3Bvd2VyX3dlbGxfZW5hYmxlKGRldl9wcml2LCBwb3dlcl93ZWxsKTsKPiAgfQo+ICAK
PiArc3RhdGljIHZvaWQgaWNsX3RjX3BoeV9hdXhfcG93ZXJfd2VsbF9kaXNhYmxlKHN0cnVjdCBk
cm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiArCQkJCQkgICAgICBzdHJ1Y3QgaTkxNV9wb3dl
cl93ZWxsICpwb3dlcl93ZWxsKQo+ICt7Cj4gKwllbnVtIGF1eF9jaCBhdXhfY2ggPSBJQ0xfQVVY
X1BXX1RPX0NIKHBvd2VyX3dlbGwtPmRlc2MtPmhzdy5pZHgpOwo+ICsKPiArCWljbF90Y19ncmFi
X2NvbnRyb2woZGV2X3ByaXYsIGF1eF9jaCwgZmFsc2UpOwo+ICsJaHN3X3Bvd2VyX3dlbGxfZGlz
YWJsZShkZXZfcHJpdiwgcG93ZXJfd2VsbCk7Cj4gK30KPiArCj4gIC8qCj4gICAqIFdlIHNob3Vs
ZCBvbmx5IHVzZSB0aGUgcG93ZXIgd2VsbCBpZiB3ZSBleHBsaWNpdGx5IGFza2VkIHRoZSBoYXJk
d2FyZSB0bwo+ICAgKiBlbmFibGUgaXQsIHNvIGNoZWNrIGlmIGl0J3MgZW5hYmxlZCBhbmQgYWxz
byBjaGVjayBpZiB3ZSd2ZSByZXF1ZXN0ZWQgaXQgdG8KPiBAQCAtMjc1NCw3ICsyODA3LDcgQEAg
c3RhdGljIGNvbnN0IHN0cnVjdCBpOTE1X3Bvd2VyX3dlbGxfb3BzIGljbF9jb21ib19waHlfYXV4
X3Bvd2VyX3dlbGxfb3BzID0gewo+ICBzdGF0aWMgY29uc3Qgc3RydWN0IGk5MTVfcG93ZXJfd2Vs
bF9vcHMgaWNsX3RjX3BoeV9hdXhfcG93ZXJfd2VsbF9vcHMgPSB7Cj4gIAkuc3luY19odyA9IGhz
d19wb3dlcl93ZWxsX3N5bmNfaHcsCj4gIAkuZW5hYmxlID0gaWNsX3RjX3BoeV9hdXhfcG93ZXJf
d2VsbF9lbmFibGUsCj4gLQkuZGlzYWJsZSA9IGhzd19wb3dlcl93ZWxsX2Rpc2FibGUsCj4gKwku
ZGlzYWJsZSA9IGljbF90Y19waHlfYXV4X3Bvd2VyX3dlbGxfZGlzYWJsZSwKPiAgCS5pc19lbmFi
bGVkID0gaHN3X3Bvd2VyX3dlbGxfZW5hYmxlZCwKPiAgfTsKPiAgCj4gLS0gCj4gMi4xOS4xCj4g
Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdm
eCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xp
c3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=