All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Lubomir Rintel <lkundrak@v3.sk>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86, olpc: Indicate that legacy PC platform should not register RTC
Date: Sun, 4 Nov 2018 12:29:06 +0100	[thread overview]
Message-ID: <20181104112905.GB23864@amd> (raw)
In-Reply-To: <20181004160808.307738-1-lkundrak@v3.sk>

[-- Attachment #1: Type: text/plain, Size: 1502 bytes --]

On Thu 2018-10-04 18:08:08, Lubomir Rintel wrote:
> On OLPC XO-1 we're discovering the RTC via device tree from the arch
> initcall. Don't let the PC platform register another one from its
> device initcall, it's not going to work:
> 
>   sysfs: cannot create duplicate filename '/devices/platform/rtc_cmos'
>   CPU: 0 PID: 1 Comm: swapper Not tainted 4.19.0-rc6 #12
>   Hardware name: OLPC XO/XO, BIOS OLPC Ver 1.00.01 06/11/2014
>   Call Trace:
>    dump_stack+0x16/0x18
>    sysfs_warn_dup+0x46/0x58
>    sysfs_create_dir_ns+0x76/0x9b
>    kobject_add_internal+0xed/0x209
>    ? __schedule+0x3fa/0x447
>    kobject_add+0x5b/0x66
>    device_add+0x298/0x535
>    ? insert_resource_conflict+0x2a/0x3e
>    platform_device_add+0x14d/0x192
>    ? io_delay_init+0x19/0x19
>    platform_device_register+0x1c/0x1f
>    add_rtc_cmos+0x16/0x31
>    do_one_initcall+0x78/0x14a
>    ? do_early_param+0x75/0x75
>    kernel_init_freeable+0x152/0x1e0
>    ? rest_init+0xa2/0xa2
>    kernel_init+0x8/0xd5
>    ret_from_fork+0x2e/0x38
>   kobject_add_internal failed for rtc_cmos with -EEXIST, don't try to
>     register things with the same name in the same directory.
>   platform rtc_cmos: registered platform RTC device (no PNP device found)
> 
> Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>

Acked-by: Pavel Machek <pavel@ucw.cz>


-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

      parent reply	other threads:[~2018-11-04 11:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-04 16:08 [PATCH] x86, olpc: Indicate that legacy PC platform should not register RTC Lubomir Rintel
2018-10-05 10:45 ` [tip:x86/olpc] x86/olpc: Indicate that legacy PC XO-1 " tip-bot for Lubomir Rintel
2018-10-05 13:17 ` [PATCH] x86/olpc: Fix build error with CONFIG_MFD_CS5535=m Borislav Petkov
2018-10-06 18:45   ` [tip:x86/platform] " tip-bot for Borislav Petkov
2018-11-04 11:29 ` Pavel Machek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181104112905.GB23864@amd \
    --to=pavel@ucw.cz \
    --cc=bp@alien8.de \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkundrak@v3.sk \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.