All of lore.kernel.org
 help / color / mirror / Atom feed
From: AKASHI Takahiro <takahiro.akashi@linaro.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 01/14] efi_loader: allow device == NULL in efi_dp_from_name()
Date: Mon,  5 Nov 2018 18:06:40 +0900	[thread overview]
Message-ID: <20181105090653.7409-2-takahiro.akashi@linaro.org> (raw)
In-Reply-To: <20181105090653.7409-1-takahiro.akashi@linaro.org>

This is a preparatory patch for use in efi_serialize_load_option()
as a load option's file_path should have both a device path and
a file path.

Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
---
 lib/efi_loader/efi_device_path.c | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/lib/efi_loader/efi_device_path.c b/lib/efi_loader/efi_device_path.c
index cdf7c7be8c5c..d94982314a3e 100644
--- a/lib/efi_loader/efi_device_path.c
+++ b/lib/efi_loader/efi_device_path.c
@@ -955,7 +955,7 @@ efi_status_t efi_dp_from_name(const char *dev, const char *devnr,
 	char filename[32] = { 0 }; /* dp->str is u16[32] long */
 	char *s;
 
-	if (!device || (path && !file))
+	if (path && !file)
 		return EFI_INVALID_PARAMETER;
 
 	is_net = !strcmp(dev, "Net");
@@ -965,10 +965,12 @@ efi_status_t efi_dp_from_name(const char *dev, const char *devnr,
 		if (part < 0)
 			return EFI_INVALID_PARAMETER;
 
-		*device = efi_dp_from_part(desc, part);
+		if (device)
+			*device = efi_dp_from_part(desc, part);
 	} else {
 #ifdef CONFIG_NET
-		*device = efi_dp_from_eth();
+		if (device)
+			*device = efi_dp_from_eth();
 #endif
 	}
 
@@ -985,7 +987,8 @@ efi_status_t efi_dp_from_name(const char *dev, const char *devnr,
 	s = filename;
 	while ((s = strchr(s, '/')))
 		*s++ = '\\';
-	*file = efi_dp_from_file(NULL, 0, filename);
+	*file = efi_dp_from_file(((!is_net && device) ? desc : NULL),
+				 part, filename);
 
 	return EFI_SUCCESS;
 }
-- 
2.19.0

  reply	other threads:[~2018-11-05  9:06 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-05  9:06 [U-Boot] [PATCH v2 00/14] efi: make efi and bootmgr more usable AKASHI Takahiro
2018-11-05  9:06 ` AKASHI Takahiro [this message]
2018-11-05  9:06 ` [U-Boot] [PATCH v2 02/14] efi_loader: bootmgr: add load option helper functions AKASHI Takahiro
2018-11-05  9:06 ` [U-Boot] [PATCH v2 03/14] efi_loader: bootmgr: allow for running a given load option AKASHI Takahiro
2018-12-02 23:22   ` Alexander Graf
2018-12-03  3:20     ` AKASHI Takahiro
2018-12-03 13:54       ` Alexander Graf
2018-11-05  9:06 ` [U-Boot] [PATCH v2 04/14] cmd: add efishell command AKASHI Takahiro
2018-12-02 23:42   ` Alexander Graf
2018-12-03  6:42     ` AKASHI Takahiro
2018-12-03 14:01       ` Alexander Graf
2018-11-05  9:06 ` [U-Boot] [PATCH v2 05/14] cmd: efishell: add devices command AKASHI Takahiro
2018-12-02 23:46   ` Alexander Graf
2018-12-03  7:02     ` AKASHI Takahiro
2018-12-23  3:11       ` Alexander Graf
2018-12-25 12:00         ` AKASHI Takahiro
2018-12-26  8:00           ` Alexander Graf
2019-01-07  8:22             ` AKASHI Takahiro
2018-11-05  9:06 ` [U-Boot] [PATCH v2 06/14] cmd: efishell: add drivers command AKASHI Takahiro
2018-11-05  9:06 ` [U-Boot] [PATCH v2 07/14] cmd: efishell: add images command AKASHI Takahiro
2018-11-05  9:06 ` [U-Boot] [PATCH v2 08/14] cmd: efishell: add memmap command AKASHI Takahiro
2018-12-02 23:48   ` Alexander Graf
2018-12-03  7:10     ` AKASHI Takahiro
2018-11-05  9:06 ` [U-Boot] [PATCH v2 09/14] cmd: efishell: add dh command AKASHI Takahiro
2018-11-05  9:06 ` [U-Boot] [PATCH v2 10/14] cmd: bootefi: carve out fdt parameter handling AKASHI Takahiro
2018-12-02 23:50   ` Alexander Graf
2018-12-03  7:33     ` AKASHI Takahiro
2018-12-23  3:11       ` Alexander Graf
2018-12-25 12:05         ` AKASHI Takahiro
2018-11-05  9:06 ` [U-Boot] [PATCH v2 11/14] cmd: bootefi: run an EFI application of a specific load option AKASHI Takahiro
2018-11-05  9:06 ` [U-Boot] [PATCH v2 12/14] cmd: run: add "-e" option to run an EFI application AKASHI Takahiro
2018-12-02 23:53   ` Alexander Graf
2018-12-03  7:57     ` AKASHI Takahiro
2018-11-05  9:06 ` [U-Boot] [PATCH v2 13/14] cmd: efishell: export uefi variable helper functions AKASHI Takahiro
2018-12-02 23:54   ` Alexander Graf
2018-12-03  8:08     ` AKASHI Takahiro
2018-12-23  3:13       ` Alexander Graf
2018-12-25 12:14         ` AKASHI Takahiro
2018-11-05  9:06 ` [U-Boot] [PATCH v2 14/14] cmd: env: add "-e" option for handling UEFI variables AKASHI Takahiro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181105090653.7409-2-takahiro.akashi@linaro.org \
    --to=takahiro.akashi@linaro.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.