From: David Sterba <dsterba@suse.cz>
To: Filipe Manana <fdmanana@kernel.org>
Cc: dsterba@suse.cz, Josef Bacik <josef@toxicpanda.com>,
linux-btrfs <linux-btrfs@vger.kernel.org>,
Filipe David Borba Manana <fdmanana@suse.com>
Subject: Re: [PATCH v4] Btrfs: fix deadlock on tree root leaf when finding free extent
Date: Mon, 5 Nov 2018 17:34:18 +0100 [thread overview]
Message-ID: <20181105163418.GB9136@twin.jikos.cz> (raw)
In-Reply-To: <CAL3q7H45e7B9acpDnx-R5hNxu+033Tfx4yD_ynZ_cY3hPfLryg@mail.gmail.com>
On Mon, Nov 05, 2018 at 04:30:35PM +0000, Filipe Manana wrote:
> On Mon, Nov 5, 2018 at 4:29 PM David Sterba <dsterba@suse.cz> wrote:
> >
> > On Wed, Oct 24, 2018 at 01:48:40PM +0100, Filipe Manana wrote:
> > > > Ah ok makes sense. Well in that case lets just make btrfs_read_locked_inode()
> > > > take a path, and allocate it in btrfs_iget, that'll remove the ugly
> > > >
> > > > if (path != in_path)
> > >
> > > You mean the following on top of v4:
> > >
> > > https://friendpaste.com/6XrGXb5p0RSJGixUFYouHg
> > >
> > > Not much different, just saves one such if statement. I'm ok with that.
> >
> > Now in misc-next with v4 and the friendpaste incremental as
> >
> > https://github.com/kdave/btrfs-devel/commit/efcfd6c87d28b3aa9bcba52d7c1e1fc79a2dad69
>
> Please don't add the incremental. It's buggy. It was meant to figure
> out what Josef was saying. That's why I haven't sent a V5.
Ok dropped, I'll will wait for a proper patch.
next prev parent reply other threads:[~2018-11-05 16:34 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-22 9:09 [PATCH] Btrfs: fix deadlock on tree root leaf when finding free extent fdmanana
2018-10-22 9:53 ` Filipe Manana
2018-10-22 9:54 ` Filipe Manana
2018-10-22 18:07 ` Josef Bacik
2018-10-22 18:51 ` Filipe Manana
2018-10-22 18:48 ` [PATCH v2] " fdmanana
2018-10-22 18:55 ` Josef Bacik
2018-10-22 19:10 ` Filipe Manana
2018-10-22 19:10 ` [PATCH v3] " fdmanana
2018-10-22 19:18 ` Josef Bacik
2018-10-22 22:05 ` Filipe Manana
2018-10-24 4:08 ` Josef Bacik
2018-10-24 9:07 ` Filipe Manana
2018-10-24 9:13 ` [PATCH v4] " fdmanana
2018-10-24 11:37 ` Josef Bacik
2018-10-24 11:53 ` Filipe Manana
2018-10-24 12:40 ` Josef Bacik
2018-10-24 12:48 ` Filipe Manana
2018-10-24 23:58 ` Josef Bacik
2018-11-05 16:28 ` David Sterba
2018-11-05 16:30 ` Filipe Manana
2018-11-05 16:34 ` David Sterba [this message]
2018-11-05 16:36 ` Filipe Manana
2018-11-13 14:33 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181105163418.GB9136@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=fdmanana@kernel.org \
--cc=fdmanana@suse.com \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.