From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50436) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gJhtZ-0007Ej-Ky for qemu-devel@nongnu.org; Mon, 05 Nov 2018 11:38:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gJhtJ-0003dC-88 for qemu-devel@nongnu.org; Mon, 05 Nov 2018 11:38:22 -0500 From: Kevin Wolf Date: Mon, 5 Nov 2018 17:37:16 +0100 Message-Id: <20181105163744.25139-9-kwolf@redhat.com> In-Reply-To: <20181105163744.25139-1-kwolf@redhat.com> References: <20181105163744.25139-1-kwolf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PULL 08/36] qcow2: Get the request alignment for encrypted images from QCryptoBlock List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-block@nongnu.org Cc: kwolf@redhat.com, peter.maydell@linaro.org, qemu-devel@nongnu.org From: Alberto Garcia This doesn't have any practical effect at the moment because the values of BDRV_SECTOR_SIZE, QCRYPTO_BLOCK_LUKS_SECTOR_SIZE and QCRYPTO_BLOCK_QCOW_SECTOR_SIZE are all the same (512 bytes), but future encryption methods could have different requirements. Signed-off-by: Alberto Garcia Reviewed-by: Daniel P. Berrang=C3=A9 Signed-off-by: Kevin Wolf --- block/qcow2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/qcow2.c b/block/qcow2.c index de94b290e6..991d6ac91b 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -1677,7 +1677,7 @@ static void qcow2_refresh_limits(BlockDriverState *= bs, Error **errp) =20 if (bs->encrypted) { /* Encryption works on a sector granularity */ - bs->bl.request_alignment =3D BDRV_SECTOR_SIZE; + bs->bl.request_alignment =3D qcrypto_block_get_sector_size(s->cr= ypto); } bs->bl.pwrite_zeroes_alignment =3D s->cluster_size; bs->bl.pdiscard_alignment =3D s->cluster_size; --=20 2.19.1