From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F19F4C46475 for ; Mon, 5 Nov 2018 17:30:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C38A420869 for ; Mon, 5 Nov 2018 17:30:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C38A420869 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730209AbeKFCvb (ORCPT ); Mon, 5 Nov 2018 21:51:31 -0500 Received: from mga04.intel.com ([192.55.52.120]:7718 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729800AbeKFCvb (ORCPT ); Mon, 5 Nov 2018 21:51:31 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Nov 2018 09:30:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,468,1534834800"; d="scan'208";a="271542607" Received: from wenjiewa-mobl2.ccr.corp.intel.com (HELO localhost) ([10.249.254.60]) by orsmga005.jf.intel.com with ESMTP; 05 Nov 2018 09:30:39 -0800 Date: Mon, 5 Nov 2018 19:30:38 +0200 From: Jarkko Sakkinen To: Andy Shevchenko Cc: "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , Platform Driver , linux-sgx@vger.kernel.org, Dave Hansen , sean.j.christopherson@intel.com, nhorman@redhat.com, npmccallum@redhat.com, serge.ayoun@intel.com, shay.katz-zamir@intel.com, haitao.huang@intel.com, mark.shanahan@intel.com, Andy Shevchenko , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , suresh.b.siddha@intel.com, Linux Kernel Mailing List Subject: Re: [PATCH v15 15/23] x86/sgx: Add wrappers for ENCLS leaf functions Message-ID: <20181105173038.GD4502@linux.intel.com> References: <20181102231320.29164-1-jarkko.sakkinen@linux.intel.com> <20181102231320.29164-16-jarkko.sakkinen@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Nov 03, 2018 at 03:17:35PM +0200, Andy Shevchenko wrote: > On Sat, Nov 3, 2018 at 1:18 AM Jarkko Sakkinen > wrote: > > > > ENCLS is an umbrella instruction for a variety of cpl0 SGX functions. > > The ENCLS function that is executed is specified in EAX, with each > > function potentially having more leaf-specific operands beyond EAX. > > ENCLS introduces its own (positive value) error codes that (some) > > leafs use to return failure information in EAX. Leafs that return > > an error code also modify RFLAGS. And finally, ENCLS generates > > ENCLS-specific non-fatal #GPs and #PFs, i.e. a bug-free kernel may > > encounter faults on ENCLS that must be handled gracefully. > > > > Because of the complexity involved in encoding ENCLS and handling its > > assortment of failure paths, executing any given leaf is not a simple > > matter of emitting ENCLS. > > > > To enable adding support for ENCLS leafs with minimal fuss, add a > > two-layer macro system along with an encoding scheme to allow wrappers > > to return trap numbers along ENCLS-specific error codes. The bottom > > layer of the macro system splits between the leafs that return an > > error code and those that do not. The second layer generates the > > correct input/output annotations based on the number of operands for > > each leaf function. > > > +/* SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause) */ > > > +/** > > I dunno if kernel-doc script still complains about this. Is there a way to ask for make htmldocs to do only a subset of docs? Still kind of trying to figure out what would be a good flow for working with Sphinx. /Jarkko From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Mon, 5 Nov 2018 19:30:38 +0200 From: Jarkko Sakkinen To: Andy Shevchenko CC: "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , Platform Driver , , Dave Hansen , , , , , , , , Andy Shevchenko , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , , "Linux Kernel Mailing List" Subject: Re: [PATCH v15 15/23] x86/sgx: Add wrappers for ENCLS leaf functions Message-ID: <20181105173038.GD4502@linux.intel.com> References: <20181102231320.29164-1-jarkko.sakkinen@linux.intel.com> <20181102231320.29164-16-jarkko.sakkinen@linux.intel.com> Content-Type: text/plain; charset="us-ascii" In-Reply-To: Return-Path: jarkko.sakkinen@linux.intel.com MIME-Version: 1.0 List-ID: On Sat, Nov 03, 2018 at 03:17:35PM +0200, Andy Shevchenko wrote: > On Sat, Nov 3, 2018 at 1:18 AM Jarkko Sakkinen > wrote: > > > > ENCLS is an umbrella instruction for a variety of cpl0 SGX functions. > > The ENCLS function that is executed is specified in EAX, with each > > function potentially having more leaf-specific operands beyond EAX. > > ENCLS introduces its own (positive value) error codes that (some) > > leafs use to return failure information in EAX. Leafs that return > > an error code also modify RFLAGS. And finally, ENCLS generates > > ENCLS-specific non-fatal #GPs and #PFs, i.e. a bug-free kernel may > > encounter faults on ENCLS that must be handled gracefully. > > > > Because of the complexity involved in encoding ENCLS and handling its > > assortment of failure paths, executing any given leaf is not a simple > > matter of emitting ENCLS. > > > > To enable adding support for ENCLS leafs with minimal fuss, add a > > two-layer macro system along with an encoding scheme to allow wrappers > > to return trap numbers along ENCLS-specific error codes. The bottom > > layer of the macro system splits between the leafs that return an > > error code and those that do not. The second layer generates the > > correct input/output annotations based on the number of operands for > > each leaf function. > > > +/* SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause) */ > > > +/** > > I dunno if kernel-doc script still complains about this. Is there a way to ask for make htmldocs to do only a subset of docs? Still kind of trying to figure out what would be a good flow for working with Sphinx. /Jarkko