From: Bruce Richardson <bruce.richardson@intel.com>
To: dev@dpdk.org
Cc: Yipeng Wang <yipeng1.wang@intel.com>
Subject: [PATCH 2/4] hash: add local cache for TSX region
Date: Mon, 5 Nov 2018 17:39:11 +0000 [thread overview]
Message-ID: <20181105173913.61225-3-bruce.richardson@intel.com> (raw)
In-Reply-To: <20181105173913.61225-1-bruce.richardson@intel.com>
From: Yipeng Wang <yipeng1.wang@intel.com>
This patch adds back the local cache when TSX support is turned on.
When TSX is turned on, free key-data slot ring would be contended by
various TSX regions. The purpose of this commit is to reduce possible
memory collisions during key insertion.
Signed-off-by: Yipeng Wang <yipeng1.wang@intel.com>
---
lib/librte_hash/rte_cuckoo_hash.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/lib/librte_hash/rte_cuckoo_hash.c b/lib/librte_hash/rte_cuckoo_hash.c
index 76f5dc8..5d5f9f1 100644
--- a/lib/librte_hash/rte_cuckoo_hash.c
+++ b/lib/librte_hash/rte_cuckoo_hash.c
@@ -180,8 +180,10 @@ struct rte_hash *
}
/* Check extra flags field to check extra options. */
- if (params->extra_flag & RTE_HASH_EXTRA_FLAGS_TRANS_MEM_SUPPORT)
+ if (params->extra_flag & RTE_HASH_EXTRA_FLAGS_TRANS_MEM_SUPPORT) {
+ use_local_cache = 1;
hw_trans_mem_support = 1;
+ }
if (params->extra_flag & RTE_HASH_EXTRA_FLAGS_MULTI_WRITER_ADD) {
use_local_cache = 1;
--
1.8.5.6
next prev parent reply other threads:[~2018-11-05 17:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-05 17:39 [PATCH 0/4] fixes for rte_hash with TSX Bruce Richardson
2018-11-05 17:39 ` [PATCH 1/4] hash: fix TSX aborts with newer gcc Bruce Richardson
2018-11-05 17:39 ` Bruce Richardson [this message]
2018-11-09 15:59 ` [PATCH 2/4] hash: add local cache for TSX region Bruce Richardson
2018-11-05 17:39 ` [PATCH 3/4] eal/x86: reduce contention when retrying TSX Bruce Richardson
2018-11-05 17:39 ` [PATCH 4/4] test/test: improve output for hash read-write test Bruce Richardson
2018-11-12 10:47 ` [PATCH v2 0/4] fixes for rte_hash with TSX Bruce Richardson
2018-11-12 10:47 ` [PATCH v2 1/4] hash: fix TSX aborts with newer gcc Bruce Richardson
2018-11-12 10:47 ` [PATCH v2 2/4] hash: add local cache for TSX region Bruce Richardson
2018-11-12 18:34 ` Honnappa Nagarahalli
2018-11-13 16:40 ` [dpdk-stable] " Thomas Monjalon
2018-11-13 17:16 ` Honnappa Nagarahalli
2018-11-13 17:24 ` Wang, Yipeng1
2018-11-13 17:48 ` Bruce Richardson
2018-11-12 10:47 ` [PATCH v2 3/4] eal/x86: reduce contention when retrying TSX Bruce Richardson
2018-11-12 10:47 ` [PATCH v2 4/4] test/test: improve output for hash read-write test Bruce Richardson
2018-11-14 0:06 ` [PATCH v2 0/4] fixes for rte_hash with TSX Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181105173913.61225-3-bruce.richardson@intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=yipeng1.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.