On Mon, Nov 05, 2018 at 09:23:08PM +0800, Icenowy Zheng wrote: > 在 2018-10-08一的 11:21 +0200,Maxime Ripard写道: > > On Fri, Oct 05, 2018 at 11:59:51PM +0200, Giulio Benetti wrote: > > > If tcon->panel pointer is NULL, trying to dereference from it > > > (i.e. tcon->panel->connector) will cause a null pointer > > > dereference. > > > > > > Add tcon->panel null pointer check before calling > > > sun4i_tcon0_mode_set_dithering(). > > > > > > Signed-off-by: Giulio Benetti > > > Fixes: f11adcecbd5f ("drm/sun4i: tcon: Add dithering support for > > > RGB565/RGB666 LCD panels") > > > Reviewed-by: Chen-Yu Tsai > > > > Applied both, thanks! > > Please bring them to 4.20. > > Currently in 4.20-rc1, bridge support of sun4i-drm is broken because of > this problem. I've merged them in drm-misc-fixes, thanks! Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com