All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH -next] edac: i82975x: remove set but not used variable 'dtype'
@ 2018-11-01  2:26 ` YueHaibing
  0 siblings, 0 replies; 6+ messages in thread
From: YueHaibing @ 2018-11-01  2:26 UTC (permalink / raw)
  To: linux-edac, ravi, arvino55, bp, mchehab; +Cc: linux-kernel, YueHaibing

Fixes gcc '-Wunused-but-set-variable' warning:

drivers/edac/i82975x_edac.c:378:16: warning:
 variable ‘dtype’ set but not used [-Wunused-but-set-variable]

It never used since introduction in commit
084a4fccef39 ("edac: move dimm properties to struct dimm_info")

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/edac/i82975x_edac.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/edac/i82975x_edac.c b/drivers/edac/i82975x_edac.c
index 892815e..ae0d8fa 100644
--- a/drivers/edac/i82975x_edac.c
+++ b/drivers/edac/i82975x_edac.c
@@ -375,7 +375,6 @@ static void i82975x_init_csrows(struct mem_ctl_info *mci,
 	u32 cumul_size, nr_pages;
 	int index, chan;
 	struct dimm_info *dimm;
-	enum dev_type dtype;
 
 	last_cumul_size = 0;
 
@@ -413,7 +412,6 @@ static void i82975x_init_csrows(struct mem_ctl_info *mci,
 		 *   [0-7] for single-channel; i.e. csrow->nr_channels = 1
 		 *   [0-3] for dual-channel; i.e. csrow->nr_channels = 2
 		 */
-		dtype = i82975x_dram_type(mch_window, index);
 		for (chan = 0; chan < csrow->nr_channels; chan++) {
 			dimm = mci->csrows[index]->channels[chan]->dimm;
 
-- 
2.7.0



^ permalink raw reply	[flat|nested] 6+ messages in thread

* [-next] edac: i82975x: remove set but not used variable 'dtype'
@ 2018-11-01  2:26 ` YueHaibing
  0 siblings, 0 replies; 6+ messages in thread
From: YueHaibing @ 2018-11-01  2:26 UTC (permalink / raw)
  To: linux-edac, ravi, arvino55, bp, mchehab; +Cc: linux-kernel, YueHaibing

Fixes gcc '-Wunused-but-set-variable' warning:

drivers/edac/i82975x_edac.c:378:16: warning:
 variable ‘dtype’ set but not used [-Wunused-but-set-variable]

It never used since introduction in commit
084a4fccef39 ("edac: move dimm properties to struct dimm_info")

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/edac/i82975x_edac.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/edac/i82975x_edac.c b/drivers/edac/i82975x_edac.c
index 892815e..ae0d8fa 100644
--- a/drivers/edac/i82975x_edac.c
+++ b/drivers/edac/i82975x_edac.c
@@ -375,7 +375,6 @@ static void i82975x_init_csrows(struct mem_ctl_info *mci,
 	u32 cumul_size, nr_pages;
 	int index, chan;
 	struct dimm_info *dimm;
-	enum dev_type dtype;
 
 	last_cumul_size = 0;
 
@@ -413,7 +412,6 @@ static void i82975x_init_csrows(struct mem_ctl_info *mci,
 		 *   [0-7] for single-channel; i.e. csrow->nr_channels = 1
 		 *   [0-3] for dual-channel; i.e. csrow->nr_channels = 2
 		 */
-		dtype = i82975x_dram_type(mch_window, index);
 		for (chan = 0; chan < csrow->nr_channels; chan++) {
 			dimm = mci->csrows[index]->channels[chan]->dimm;
 

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH -next] edac: i82975x: remove set but not used variable 'dtype'
@ 2018-11-06 18:05   ` Borislav Petkov
  0 siblings, 0 replies; 6+ messages in thread
From: Borislav Petkov @ 2018-11-06 18:05 UTC (permalink / raw)
  To: YueHaibing; +Cc: linux-edac, ravi, arvino55, mchehab, linux-kernel

On Thu, Nov 01, 2018 at 10:26:04AM +0800, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> drivers/edac/i82975x_edac.c:378:16: warning:
>  variable ‘dtype’ set but not used [-Wunused-but-set-variable]
> 
> It never used since introduction in commit
> 084a4fccef39 ("edac: move dimm properties to struct dimm_info")
> 
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>  drivers/edac/i82975x_edac.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/edac/i82975x_edac.c b/drivers/edac/i82975x_edac.c
> index 892815e..ae0d8fa 100644
> --- a/drivers/edac/i82975x_edac.c
> +++ b/drivers/edac/i82975x_edac.c
> @@ -375,7 +375,6 @@ static void i82975x_init_csrows(struct mem_ctl_info *mci,
>  	u32 cumul_size, nr_pages;
>  	int index, chan;
>  	struct dimm_info *dimm;
> -	enum dev_type dtype;
>  
>  	last_cumul_size = 0;
>  
> @@ -413,7 +412,6 @@ static void i82975x_init_csrows(struct mem_ctl_info *mci,
>  		 *   [0-7] for single-channel; i.e. csrow->nr_channels = 1
>  		 *   [0-3] for dual-channel; i.e. csrow->nr_channels = 2
>  		 */
> -		dtype = i82975x_dram_type(mch_window, index);

Please get rid of that silly function too and move the comment and the
assignment to the single place where it is done:

        /*
         * ECC is possible on i92975x ONLY with DEV_X8
         */
        dimm->dtype = DEV_X8;


Thx.

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [-next] edac: i82975x: remove set but not used variable 'dtype'
@ 2018-11-06 18:05   ` Borislav Petkov
  0 siblings, 0 replies; 6+ messages in thread
From: Borislav Petkov @ 2018-11-06 18:05 UTC (permalink / raw)
  To: YueHaibing; +Cc: linux-edac, ravi, arvino55, mchehab, linux-kernel

On Thu, Nov 01, 2018 at 10:26:04AM +0800, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> drivers/edac/i82975x_edac.c:378:16: warning:
>  variable ‘dtype’ set but not used [-Wunused-but-set-variable]
> 
> It never used since introduction in commit
> 084a4fccef39 ("edac: move dimm properties to struct dimm_info")
> 
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>  drivers/edac/i82975x_edac.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/edac/i82975x_edac.c b/drivers/edac/i82975x_edac.c
> index 892815e..ae0d8fa 100644
> --- a/drivers/edac/i82975x_edac.c
> +++ b/drivers/edac/i82975x_edac.c
> @@ -375,7 +375,6 @@ static void i82975x_init_csrows(struct mem_ctl_info *mci,
>  	u32 cumul_size, nr_pages;
>  	int index, chan;
>  	struct dimm_info *dimm;
> -	enum dev_type dtype;
>  
>  	last_cumul_size = 0;
>  
> @@ -413,7 +412,6 @@ static void i82975x_init_csrows(struct mem_ctl_info *mci,
>  		 *   [0-7] for single-channel; i.e. csrow->nr_channels = 1
>  		 *   [0-3] for dual-channel; i.e. csrow->nr_channels = 2
>  		 */
> -		dtype = i82975x_dram_type(mch_window, index);

Please get rid of that silly function too and move the comment and the
assignment to the single place where it is done:

        /*
         * ECC is possible on i92975x ONLY with DEV_X8
         */
        dimm->dtype = DEV_X8;


Thx.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH -next] edac: i82975x: remove set but not used variable 'dtype'
@ 2018-11-07  1:28     ` YueHaibing
  0 siblings, 0 replies; 6+ messages in thread
From: YueHaibing @ 2018-11-07  1:28 UTC (permalink / raw)
  To: Borislav Petkov; +Cc: linux-edac, ravi, arvino55, mchehab, linux-kernel

On 2018/11/7 2:05, Borislav Petkov wrote:
> On Thu, Nov 01, 2018 at 10:26:04AM +0800, YueHaibing wrote:
>> Fixes gcc '-Wunused-but-set-variable' warning:
>>
>> drivers/edac/i82975x_edac.c:378:16: warning:
>>  variable ‘dtype’ set but not used [-Wunused-but-set-variable]
>>
>> It never used since introduction in commit
>> 084a4fccef39 ("edac: move dimm properties to struct dimm_info")
>>
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>> ---
>>  drivers/edac/i82975x_edac.c | 2 --
>>  1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/edac/i82975x_edac.c b/drivers/edac/i82975x_edac.c
>> index 892815e..ae0d8fa 100644
>> --- a/drivers/edac/i82975x_edac.c
>> +++ b/drivers/edac/i82975x_edac.c
>> @@ -375,7 +375,6 @@ static void i82975x_init_csrows(struct mem_ctl_info *mci,
>>  	u32 cumul_size, nr_pages;
>>  	int index, chan;
>>  	struct dimm_info *dimm;
>> -	enum dev_type dtype;
>>  
>>  	last_cumul_size = 0;
>>  
>> @@ -413,7 +412,6 @@ static void i82975x_init_csrows(struct mem_ctl_info *mci,
>>  		 *   [0-7] for single-channel; i.e. csrow->nr_channels = 1
>>  		 *   [0-3] for dual-channel; i.e. csrow->nr_channels = 2
>>  		 */
>> -		dtype = i82975x_dram_type(mch_window, index);
> 
> Please get rid of that silly function too and move the comment and the
> assignment to the single place where it is done:
> 
>         /*
>          * ECC is possible on i92975x ONLY with DEV_X8
>          */
>         dimm->dtype = DEV_X8;
> 

OK, will send v2.

> 
> Thx.
> 


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [-next] edac: i82975x: remove set but not used variable 'dtype'
@ 2018-11-07  1:28     ` YueHaibing
  0 siblings, 0 replies; 6+ messages in thread
From: YueHaibing @ 2018-11-07  1:28 UTC (permalink / raw)
  To: Borislav Petkov; +Cc: linux-edac, ravi, arvino55, mchehab, linux-kernel

On 2018/11/7 2:05, Borislav Petkov wrote:
> On Thu, Nov 01, 2018 at 10:26:04AM +0800, YueHaibing wrote:
>> Fixes gcc '-Wunused-but-set-variable' warning:
>>
>> drivers/edac/i82975x_edac.c:378:16: warning:
>>  variable ‘dtype’ set but not used [-Wunused-but-set-variable]
>>
>> It never used since introduction in commit
>> 084a4fccef39 ("edac: move dimm properties to struct dimm_info")
>>
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>> ---
>>  drivers/edac/i82975x_edac.c | 2 --
>>  1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/edac/i82975x_edac.c b/drivers/edac/i82975x_edac.c
>> index 892815e..ae0d8fa 100644
>> --- a/drivers/edac/i82975x_edac.c
>> +++ b/drivers/edac/i82975x_edac.c
>> @@ -375,7 +375,6 @@ static void i82975x_init_csrows(struct mem_ctl_info *mci,
>>  	u32 cumul_size, nr_pages;
>>  	int index, chan;
>>  	struct dimm_info *dimm;
>> -	enum dev_type dtype;
>>  
>>  	last_cumul_size = 0;
>>  
>> @@ -413,7 +412,6 @@ static void i82975x_init_csrows(struct mem_ctl_info *mci,
>>  		 *   [0-7] for single-channel; i.e. csrow->nr_channels = 1
>>  		 *   [0-3] for dual-channel; i.e. csrow->nr_channels = 2
>>  		 */
>> -		dtype = i82975x_dram_type(mch_window, index);
> 
> Please get rid of that silly function too and move the comment and the
> assignment to the single place where it is done:
> 
>         /*
>          * ECC is possible on i92975x ONLY with DEV_X8
>          */
>         dimm->dtype = DEV_X8;
> 

OK, will send v2.

> 
> Thx.
>

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2018-11-07  1:28 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-01  2:26 [PATCH -next] edac: i82975x: remove set but not used variable 'dtype' YueHaibing
2018-11-01  2:26 ` [-next] " YueHaibing
2018-11-06 18:05 ` [PATCH -next] " Borislav Petkov
2018-11-06 18:05   ` [-next] " Borislav Petkov
2018-11-07  1:28   ` [PATCH -next] " YueHaibing
2018-11-07  1:28     ` [-next] " YueHaibing

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.