All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: Russell King - ARM Linux <linux@armlinux.org.uk>,
	David Miller <davem@davemloft.net>,
	netdev@vger.kernel.org
Subject: Re: [PATCH RFC net-next 0/3] net: phy: sfp: Warn when using generic PHY driver
Date: Wed, 7 Nov 2018 01:59:41 +0100	[thread overview]
Message-ID: <20181107005941.GB30774@lunn.ch> (raw)
In-Reply-To: <38f03d3d-d25d-6ff3-2f44-baa01e060746@gmail.com>

> Another approach could be to maintain a list of modules that do not work
> with the generic PHY driver and therefore require a specialized driver,
> in that case we could even go as far as not letting sfp_sm_probe_phy()
> return success. Not sure how well things would scale, probably not too
> bad given there are only a handful of users of the SFP framework thus far...

Hi Florian

Blacklisting modules with known issues with the generic driver does
not sound too bad. This is just a warning, a helpful hint, and it is
not going to work anyway. And i don't see scaling problems, Copper
SFPs seems quite odd to start with...

    Andrew

      reply	other threads:[~2018-11-07 10:27 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-06 23:29 [PATCH RFC net-next 0/3] net: phy: sfp: Warn when using generic PHY driver Florian Fainelli
2018-11-06 23:29 ` [PATCH RFC net-next 1/3] net: phy: Add helpers to determine if PHY driver is generic Florian Fainelli
2018-11-06 23:29 ` [PATCH RFC net-next 2/3] net: phy: sfp: Issue warning when using Generic PHY driver(s) Florian Fainelli
2018-11-06 23:29 ` [PATCH RFC net-next 3/3] net: phy: Default MARVELL_PHY to the value of SFP Florian Fainelli
2018-11-06 23:38 ` [PATCH RFC net-next 0/3] net: phy: sfp: Warn when using generic PHY driver David Miller
2018-11-06 23:42   ` Florian Fainelli
2018-11-07  0:03   ` Russell King - ARM Linux
2018-11-07  0:09     ` Florian Fainelli
2018-11-07  0:34       ` Russell King - ARM Linux
2018-11-07  0:51         ` Florian Fainelli
2018-11-07  0:59           ` Andrew Lunn [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181107005941.GB30774@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.