From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Kiper Subject: Re: [PATCH v4 05/19] xen: add some dummy headers for PVH mode Date: Wed, 7 Nov 2018 13:21:15 +0100 Message-ID: <20181107122115.GG4358@olila.i.net-space.pl> References: <20181102123738.16395-1-jgross@suse.com> <20181102123738.16395-6-jgross@suse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20181102123738.16395-6-jgross@suse.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Juergen Gross Cc: hans@knorrie.org, grub-devel@gnu.org, phcoder@gmail.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org T24gRnJpLCBOb3YgMDIsIDIwMTggYXQgMDE6Mzc6MjRQTSArMDEwMCwgSnVlcmdlbiBHcm9zcyB3 cm90ZToKPiBXaXRoIFhlbiBQVkggbW9kZSBhZGRpbmcgYSBuZXcgbWFjaGluZSB0eXBlIHRoZSBt YWNoaW5lIHJlbGF0ZWQgaGVhZGVycwo+IG5lZWQgdG8gYmUgcHJlc2VudCBmb3IgdGhlIGJ1aWxk IHRvIHN1Y2NlZWQuIE1vc3Qgb2YgdGhlIGhlYWRlcnMganVzdAo+IG5lZWQgdG8gaW5jbHVkZSB0 aGUgcmVsYXRlZCBjb21tb24gaTM4NiBoZWFkZXJzLiBBZGQgdGhvc2UgdG8gdGhlIHRyZWUuCj4K PiBTaWduZWQtb2ZmLWJ5OiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+Cj4gLS0tCj4g VjM6IHVwZGF0ZWQgY29tbWl0IG1lc3NhZ2UgKERhbmllbCBLaXBlcikKPiAgICAgeGVucHZoLT54 ZW5fcHZoIChEYW5pZWwgS2lwZXIpCj4gLS0tCj4gIGluY2x1ZGUvZ3J1Yi9pMzg2L3hlbl9wdmgv Ym9vdC5oICAgIHwgMSArCj4gIGluY2x1ZGUvZ3J1Yi9pMzg2L3hlbl9wdmgvY29uc29sZS5oIHwg MSArCj4gIGluY2x1ZGUvZ3J1Yi9pMzg2L3hlbl9wdmgvaW50LmggICAgIHwgMSArCj4gIGluY2x1 ZGUvZ3J1Yi9pMzg2L3hlbl9wdmgvbWVtb3J5LmggIHwgMSArCj4gIGluY2x1ZGUvZ3J1Yi9pMzg2 L3hlbl9wdmgvdGltZS5oICAgIHwgMSArCj4gIDUgZmlsZXMgY2hhbmdlZCwgNSBpbnNlcnRpb25z KCspCj4gIGNyZWF0ZSBtb2RlIDEwMDY0NCBpbmNsdWRlL2dydWIvaTM4Ni94ZW5fcHZoL2Jvb3Qu aAo+ICBjcmVhdGUgbW9kZSAxMDA2NDQgaW5jbHVkZS9ncnViL2kzODYveGVuX3B2aC9jb25zb2xl LmgKPiAgY3JlYXRlIG1vZGUgMTAwNjQ0IGluY2x1ZGUvZ3J1Yi9pMzg2L3hlbl9wdmgvaW50LmgK PiAgY3JlYXRlIG1vZGUgMTAwNjQ0IGluY2x1ZGUvZ3J1Yi9pMzg2L3hlbl9wdmgvbWVtb3J5LmgK PiAgY3JlYXRlIG1vZGUgMTAwNjQ0IGluY2x1ZGUvZ3J1Yi9pMzg2L3hlbl9wdmgvdGltZS5oCj4K PiBkaWZmIC0tZ2l0IGEvaW5jbHVkZS9ncnViL2kzODYveGVuX3B2aC9ib290LmggYi9pbmNsdWRl L2dydWIvaTM4Ni94ZW5fcHZoL2Jvb3QuaAo+IG5ldyBmaWxlIG1vZGUgMTAwNjQ0Cj4gaW5kZXgg MDAwMDAwMDAwLi42Y2QyM2FhODMKPiAtLS0gL2Rldi9udWxsCj4gKysrIGIvaW5jbHVkZS9ncnVi L2kzODYveGVuX3B2aC9ib290LmgKPiBAQCAtMCwwICsxIEBACj4gKyNpbmNsdWRlIDxncnViL2kz ODYvcGMvYm9vdC5oPgo+IGRpZmYgLS1naXQgYS9pbmNsdWRlL2dydWIvaTM4Ni94ZW5fcHZoL2Nv bnNvbGUuaCBiL2luY2x1ZGUvZ3J1Yi9pMzg2L3hlbl9wdmgvY29uc29sZS5oCj4gbmV3IGZpbGUg bW9kZSAxMDA2NDQKPiBpbmRleCAwMDAwMDAwMDAuLjMwNWE0NmQ4ZQo+IC0tLSAvZGV2L251bGwK PiArKysgYi9pbmNsdWRlL2dydWIvaTM4Ni94ZW5fcHZoL2NvbnNvbGUuaAo+IEBAIC0wLDAgKzEg QEAKPiArI2luY2x1ZGUgPGdydWIvaTM4Ni9wYy9jb25zb2xlLmg+Cj4gZGlmZiAtLWdpdCBhL2lu Y2x1ZGUvZ3J1Yi9pMzg2L3hlbl9wdmgvaW50LmggYi9pbmNsdWRlL2dydWIvaTM4Ni94ZW5fcHZo L2ludC5oCj4gbmV3IGZpbGUgbW9kZSAxMDA2NDQKPiBpbmRleCAwMDAwMDAwMDAuLjBmMWY5ZWU2 Mgo+IC0tLSAvZGV2L251bGwKPiArKysgYi9pbmNsdWRlL2dydWIvaTM4Ni94ZW5fcHZoL2ludC5o Cj4gQEAgLTAsMCArMSBAQAo+ICsjaW5jbHVkZSA8Z3J1Yi9pMzg2L3BjL2ludF90eXBlcy5oPgoK SSB0aGluayB0aGF0IHRoaXMgYmVncyBmb3IgZXhwbGFuYXRpb24gaW4gdGhlIGNvbW1pdCBtZXNz YWdlCndoeSBub3QgZ3J1Yi9pMzg2L3BjL2ludC5oLgoKPiBkaWZmIC0tZ2l0IGEvaW5jbHVkZS9n cnViL2kzODYveGVuX3B2aC9tZW1vcnkuaCBiL2luY2x1ZGUvZ3J1Yi9pMzg2L3hlbl9wdmgvbWVt b3J5LmgKPiBuZXcgZmlsZSBtb2RlIDEwMDY0NAo+IGluZGV4IDAwMDAwMDAwMC4uOGRkNmY3Yzhj Cj4gLS0tIC9kZXYvbnVsbAo+ICsrKyBiL2luY2x1ZGUvZ3J1Yi9pMzg2L3hlbl9wdmgvbWVtb3J5 LmgKPiBAQCAtMCwwICsxIEBACj4gKyNpbmNsdWRlIDxncnViL2kzODYvY29yZWJvb3QvbWVtb3J5 Lmg+CgpIbW1tLi4uIFdoeSBub3QgaW5jbHVkZS9ncnViL2kzODYvcGMvbWVtb3J5Lmg/Cgo+IGRp ZmYgLS1naXQgYS9pbmNsdWRlL2dydWIvaTM4Ni94ZW5fcHZoL3RpbWUuaCBiL2luY2x1ZGUvZ3J1 Yi9pMzg2L3hlbl9wdmgvdGltZS5oCj4gbmV3IGZpbGUgbW9kZSAxMDA2NDQKPiBpbmRleCAwMDAw MDAwMDAuLjIyOThlZThmNAo+IC0tLSAvZGV2L251bGwKPiArKysgYi9pbmNsdWRlL2dydWIvaTM4 Ni94ZW5fcHZoL3RpbWUuaAo+IEBAIC0wLDAgKzEgQEAKPiArI2luY2x1ZGUgPGdydWIvaTM4Ni9w Yy90aW1lLmg+CgpEYW5pZWwKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbnByb2pl Y3Qub3JnCmh0dHBzOi8vbGlzdHMueGVucHJvamVjdC5vcmcvbWFpbG1hbi9saXN0aW5mby94ZW4t ZGV2ZWw= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1gKMzn-000740-Mb for mharc-grub-devel@gnu.org; Wed, 07 Nov 2018 07:31:43 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34262) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gKMzj-0006tt-MS for grub-devel@gnu.org; Wed, 07 Nov 2018 07:31:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gKMq6-0002WP-0d for grub-devel@gnu.org; Wed, 07 Nov 2018 07:21:46 -0500 Received: from aserp2120.oracle.com ([141.146.126.78]:52488) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gKMpx-0002Lj-PD for grub-devel@gnu.org; Wed, 07 Nov 2018 07:21:36 -0500 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id wA7CIqG0001905; Wed, 7 Nov 2018 12:21:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2018-07-02; bh=AmAyYnoR11LuFxigpHCzX6gpEmnVd7iEoOYXpLN9ykE=; b=r7UBj3xsKu2nDqGzD7Yi3W+akldT+HmqarIIeBM5PKR1smFH1taEh1rmDqtFW3KPfCxi BBKixEN1aS19Nf+eXGhHe8LhInKaVEqdtCezCNjVADmCQTTAMOIpmzq6vrN/JzzIlQlz RRPyjI9z11MPC6OcdbhTdFo8Q0SODbTRx5STvUKc3J/+hx9qPbtuqxKRIF+r5n776kbp UIO6f/1zPO0voUfrhOpWT1fHK6YysxKukgpi5d1ofU+g/HoHkDXNM7eUgTJL6ZfWJ/tU 8/B4U9u2b/vLKEVMeZblHeroem+t356s38QHy7/A+rSOd/yGLUrbKHyeGNs2eyGA4lNA lQ== Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by aserp2120.oracle.com with ESMTP id 2nh3mpu4bu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 07 Nov 2018 12:21:23 +0000 Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id wA7CLMg1017539 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 7 Nov 2018 12:21:23 GMT Received: from abhmp0017.oracle.com (abhmp0017.oracle.com [141.146.116.23]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id wA7CLMNe011603; Wed, 7 Nov 2018 12:21:22 GMT Received: from olila.i.net-space.pl (/10.175.206.179) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 07 Nov 2018 04:21:21 -0800 Date: Wed, 7 Nov 2018 13:21:15 +0100 From: Daniel Kiper To: Juergen Gross Cc: grub-devel@gnu.org, xen-devel@lists.xen.org, phcoder@gmail.com, hans@knorrie.org Subject: Re: [PATCH v4 05/19] xen: add some dummy headers for PVH mode Message-ID: <20181107122115.GG4358@olila.i.net-space.pl> References: <20181102123738.16395-1-jgross@suse.com> <20181102123738.16395-6-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181102123738.16395-6-jgross@suse.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9069 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1811070113 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-Received-From: 141.146.126.78 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Nov 2018 12:31:42 -0000 On Fri, Nov 02, 2018 at 01:37:24PM +0100, Juergen Gross wrote: > With Xen PVH mode adding a new machine type the machine related headers > need to be present for the build to succeed. Most of the headers just > need to include the related common i386 headers. Add those to the tree. > > Signed-off-by: Juergen Gross > --- > V3: updated commit message (Daniel Kiper) > xenpvh->xen_pvh (Daniel Kiper) > --- > include/grub/i386/xen_pvh/boot.h | 1 + > include/grub/i386/xen_pvh/console.h | 1 + > include/grub/i386/xen_pvh/int.h | 1 + > include/grub/i386/xen_pvh/memory.h | 1 + > include/grub/i386/xen_pvh/time.h | 1 + > 5 files changed, 5 insertions(+) > create mode 100644 include/grub/i386/xen_pvh/boot.h > create mode 100644 include/grub/i386/xen_pvh/console.h > create mode 100644 include/grub/i386/xen_pvh/int.h > create mode 100644 include/grub/i386/xen_pvh/memory.h > create mode 100644 include/grub/i386/xen_pvh/time.h > > diff --git a/include/grub/i386/xen_pvh/boot.h b/include/grub/i386/xen_pvh/boot.h > new file mode 100644 > index 000000000..6cd23aa83 > --- /dev/null > +++ b/include/grub/i386/xen_pvh/boot.h > @@ -0,0 +1 @@ > +#include > diff --git a/include/grub/i386/xen_pvh/console.h b/include/grub/i386/xen_pvh/console.h > new file mode 100644 > index 000000000..305a46d8e > --- /dev/null > +++ b/include/grub/i386/xen_pvh/console.h > @@ -0,0 +1 @@ > +#include > diff --git a/include/grub/i386/xen_pvh/int.h b/include/grub/i386/xen_pvh/int.h > new file mode 100644 > index 000000000..0f1f9ee62 > --- /dev/null > +++ b/include/grub/i386/xen_pvh/int.h > @@ -0,0 +1 @@ > +#include I think that this begs for explanation in the commit message why not grub/i386/pc/int.h. > diff --git a/include/grub/i386/xen_pvh/memory.h b/include/grub/i386/xen_pvh/memory.h > new file mode 100644 > index 000000000..8dd6f7c8c > --- /dev/null > +++ b/include/grub/i386/xen_pvh/memory.h > @@ -0,0 +1 @@ > +#include Hmmm... Why not include/grub/i386/pc/memory.h? > diff --git a/include/grub/i386/xen_pvh/time.h b/include/grub/i386/xen_pvh/time.h > new file mode 100644 > index 000000000..2298ee8f4 > --- /dev/null > +++ b/include/grub/i386/xen_pvh/time.h > @@ -0,0 +1 @@ > +#include Daniel