All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Mark Brown <broonie@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	jarkko.nikula@bitmer.com
Cc: alsa-devel@alsa-project.org, linux-omap@vger.kernel.org
Subject: [PATCH v2 7/7] ASoC: omap-mcbsp: No need to initialize max_xx_thres when it is not used
Date: Wed, 7 Nov 2018 15:23:10 +0200	[thread overview]
Message-ID: <20181107132310.29597-8-peter.ujfalusi@ti.com> (raw)
In-Reply-To: <20181107132310.29597-1-peter.ujfalusi@ti.com>

Initializing to -EINVAL is not correct as the variables are unsigned and
if buffer_size is 0 then they are not used anyway.

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
 sound/soc/omap/omap-mcbsp.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/sound/soc/omap/omap-mcbsp.c b/sound/soc/omap/omap-mcbsp.c
index 8cab1151d3bb..e0ef4774c710 100644
--- a/sound/soc/omap/omap-mcbsp.c
+++ b/sound/soc/omap/omap-mcbsp.c
@@ -727,9 +727,6 @@ static int omap_mcbsp_init(struct platform_device *pdev)
 				"Unable to create additional controls\n");
 			goto err_thres;
 		}
-	} else {
-		mcbsp->max_tx_thres = -EINVAL;
-		mcbsp->max_rx_thres = -EINVAL;
 	}
 
 	ret = omap_mcbsp_st_init(pdev);
-- 
Peter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

  parent reply	other threads:[~2018-11-07 13:23 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-07 13:23 [PATCH v2 0/7] ASoC: omap-mcbsp: Cleanup and split core/sidetone support Peter Ujfalusi
2018-11-07 13:23 ` [PATCH v2 1/7] ASoC: omap-mcbsp: Clean up dma_data addr initialization code Peter Ujfalusi
2018-11-07 13:23 ` [PATCH v2 2/7] ASoC: omap-mcbsp: Clean up the interrupt handlers Peter Ujfalusi
2018-11-07 13:23 ` [PATCH v2 3/7] ASoC: omap-mcbsp: Simplify the mcbsp_start/_stop function parameters Peter Ujfalusi
2018-11-07 13:23 ` [PATCH v2 4/7] ASoC: omap-mcbsp: Move out the FIFO check from set_threshold and get_delay Peter Ujfalusi
2018-11-07 13:23 ` [PATCH v2 5/7] ASoC: omap-mcbsp: Re-arrange files for core McBSP and Sidetone function split Peter Ujfalusi
2018-11-07 13:23 ` [PATCH v2 6/7] ASoC: omap-mcbsp: Remove redundant check for mcbsp->pdata Peter Ujfalusi
2018-11-07 13:23 ` Peter Ujfalusi [this message]
2018-11-07 18:57 ` [PATCH v2 0/7] ASoC: omap-mcbsp: Cleanup and split core/sidetone support Jarkko Nikula
2018-11-08  7:13   ` Peter Ujfalusi
2018-11-08 11:58     ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181107132310.29597-8-peter.ujfalusi@ti.com \
    --to=peter.ujfalusi@ti.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=jarkko.nikula@bitmer.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.