From: Segher Boessenkool <segher@kernel.crashing.org>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] selftests/powerpc: Fix wild_bctr test to work on BE
Date: Wed, 7 Nov 2018 11:48:05 -0600 [thread overview]
Message-ID: <20181107174804.GI5994@gate.crashing.org> (raw)
In-Reply-To: <20181107101723.24970-1-mpe@ellerman.id.au>
Hi!
On Wed, Nov 07, 2018 at 09:17:23PM +1100, Michael Ellerman wrote:
> The selftest I recently added to test branching to an out-of-bounds
> NIP doesn't work on big endian. It does fail but not in the right way.
> That is it SEGVs trying to load from the opd at BAD_NIP, but it never
> gets as far as branching to BAD_NIP.
>
> To fix it we need to create an opd which is reachable but which holds
> the bad address.
> +#ifdef __BIG_ENDIAN__
Maybe you should test for _CALL_AIXDESC instead? It is more directly
what you want to know, and it even works correctly in all cases ;-)
Segher
prev parent reply other threads:[~2018-11-07 17:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-07 10:17 [PATCH] selftests/powerpc: Fix wild_bctr test to work on BE Michael Ellerman
2018-11-07 17:48 ` Segher Boessenkool [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181107174804.GI5994@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.