All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christian Stewart <christian@paral.in>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] go: specify GOARM when compiling target binaries
Date: Wed,  7 Nov 2018 12:12:58 -0800	[thread overview]
Message-ID: <20181107201259.28717-1-christian@paral.in> (raw)

Currently, GOARM is not specified correctly when compiling target binaries. This
results in incompatibility / illegal instruction issues on some ARM devices.

Signed-off-by: Christian Stewart <christian@paral.in>
---
 package/go/go.mk | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/go/go.mk b/package/go/go.mk
index ec74ba397c..8423dc7eea 100644
--- a/package/go/go.mk
+++ b/package/go/go.mk
@@ -43,6 +43,7 @@ HOST_GO_ROOT = $(HOST_DIR)/lib/go
 HOST_GO_TOOLDIR = $(HOST_GO_ROOT)/pkg/tool/linux_$(GO_GOARCH)
 HOST_GO_TARGET_ENV = \
 	GOARCH=$(GO_GOARCH) \
+	$(if $(GO_GOARM),GOARM=$(GO_GOARM)) \
 	GOROOT="$(HOST_GO_ROOT)" \
 	CC="$(TARGET_CC)" \
 	CXX="$(TARGET_CXX)" \
-- 
2.18.1

             reply	other threads:[~2018-11-07 20:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-07 20:12 Christian Stewart [this message]
2018-11-07 20:12 ` [Buildroot] [PATCH 2/2] DEVELOPERS: add Christian Stewart for go Christian Stewart
2018-11-08 14:17   ` Anisse Astier
2018-11-08 20:01   ` Thomas Petazzoni
2018-11-07 22:27 ` [Buildroot] [PATCH 1/2] go: specify GOARM when compiling target binaries Christian Stewart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181107201259.28717-1-christian@paral.in \
    --to=christian@paral.in \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.