All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: liuhangbin@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net] ipv6/mcast: update mc_qrv when join new group
Date: Thu, 08 Nov 2018 00:12:24 -0800 (PST)	[thread overview]
Message-ID: <20181108.001224.2130718342402961915.davem@davemloft.net> (raw)
In-Reply-To: <20181108074410.GO24677@leo.usersys.redhat.com>

From: Hangbin Liu <liuhangbin@gmail.com>
Date: Thu, 8 Nov 2018 15:44:10 +0800

> On Fri, Oct 26, 2018 at 10:30:54AM +0800, Hangbin Liu wrote:
>> Currently we only set mc_qrv to sysctl_mld_qrv when interface up. If we
>> change sysctl_mld_qrv after interface up, it will has no effect.
>> 
>> Fix it by assigning latest sysctl_mld_qrv to idev mc_qrv when join new group.
>> 
>> Reported-by: Ying Xu <yinxu@redhat.com>
>> Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
> 
> Hi David,
> 
> Any comments for this patch?

I did give you feedback and you never responded:

	https://patchwork.ozlabs.org/patch/989422/

So I tossed your patch.

  reply	other threads:[~2018-11-08 17:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-26  2:30 [PATCH net] ipv6/mcast: update mc_qrv when join new group Hangbin Liu
2018-10-30  3:23 ` David Miller
2018-11-08  7:44 ` Hangbin Liu
2018-11-08  8:12   ` David Miller [this message]
2018-11-14  2:37   ` Hangbin Liu
2018-11-20  9:00     ` Hangbin Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181108.001224.2130718342402961915.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=liuhangbin@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.