From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH 04/20] octeontx2-af: NPC MCAM entry alloc/free support Date: Thu, 08 Nov 2018 14:22:37 -0800 (PST) Message-ID: <20181108.142237.1471135715043960597.davem@davemloft.net> References: <1541702161-30673-1-git-send-email-sunil.kovvuri@gmail.com> <1541702161-30673-5-git-send-email-sunil.kovvuri@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, arnd@arndb.de, linux-soc@vger.kernel.org, sgoutham@marvell.com To: sunil.kovvuri@gmail.com Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:38186 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728453AbeKIIAO (ORCPT ); Fri, 9 Nov 2018 03:00:14 -0500 In-Reply-To: <1541702161-30673-5-git-send-email-sunil.kovvuri@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: From: sunil.kovvuri@gmail.com Date: Fri, 9 Nov 2018 00:05:45 +0530 > +int rvu_mbox_handler_NPC_MCAM_ALLOC_ENTRY(struct rvu *rvu, > + struct npc_mcam_alloc_entry_req *req, > + struct npc_mcam_alloc_entry_rsp *rsp); > +int rvu_mbox_handler_NPC_MCAM_FREE_ENTRY(struct rvu *rvu, > + struct npc_mcam_free_entry_req *req, > + struct msg_rsp *rsp); Please don't use capitalized letters or StUdLyCaPs for function and variable names. Keep capitalized letters for CPP macros. This is how programmers visually can see if something is a real C declaration or some CPP stuff.