From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH net-next 0/7] net: sched: prepare for more Qdisc
 offloads
Date: Thu, 08 Nov 2018 16:20:06 -0800 (PST)
Message-ID: <20181108.162006.1694208064641283923.davem@davemloft.net>
References: <20181108013340.20983-1-jakub.kicinski@netronome.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, oss-drivers@netronome.com,
        jiri@resnulli.us, xiyou.wangcong@gmail.com, jhs@mojatatu.com,
        nogah.frankel@gmail.com, yuvalm@mellanox.com
To: jakub.kicinski@netronome.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([23.128.96.9]:39920 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726926AbeKIJ6N (ORCPT
        <rfc822;netdev@vger.kernel.org>); Fri, 9 Nov 2018 04:58:13 -0500
In-Reply-To: <20181108013340.20983-1-jakub.kicinski@netronome.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Jakub Kicinski <jakub.kicinski@netronome.com>
Date: Wed,  7 Nov 2018 17:33:33 -0800

> This series refactors the "switchdev" Qdisc offloads a little.  We have
> a few Qdiscs which can be fully offloaded today to the forwarding plane
> of switching devices.
> 
> First patch adds a helper for handing statistic dumps, the code seems
> to be copy pasted between PRIO and RED.  Second patch removes unnecessary
> parameter from RED offload function.  Third patch makes the MQ offload
> use the dump helper which helps it behave much like PRIO and RED when
> it comes to the TCQ_F_OFFLOADED flag.  Patch 4 adds a graft helper,
> similar to the dump helper.
> 
> Patch 5 is unrelated to offloads, qdisc_graft() code seemed ripe for a
> small refactor - no functional changes there.
> 
> Last two patches move the qdisc_put() call outside of the sch_tree_lock
> section for RED and PRIO.  The child Qdiscs will get removed from the
> hierarchy under the lock, but having the put (and potentially destroy)
> called outside of the lock helps offload which may choose to sleep,
> and it should generally lower the Qdisc change impact.

Series applied, thanks Jakub.