From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Joe Perches <joe@perches.com>,
kernel@pengutronix.de,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scripts/spdxcheck: make python3 compliant
Date: Thu, 8 Nov 2018 07:22:00 +0100 [thread overview]
Message-ID: <20181108062200.ytkezavtcaypdlat@pengutronix.de> (raw)
In-Reply-To: <20181107153251.bac94150f8ebc8dbf53abe23@linux-foundation.org>
Hello Andrew,
On Wed, Nov 07, 2018 at 03:32:51PM -0800, Andrew Morton wrote:
> On Tue, 23 Oct 2018 09:08:02 +0200 Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote:
>
> > Without this change the following happens when using Python3 (3.6.6):
> >
> > $ echo "GPL-2.0" | python3 scripts/spdxcheck.py -
> > FAIL: 'str' object has no attribute 'decode'
> > Traceback (most recent call last):
> > File "scripts/spdxcheck.py", line 253, in <module>
> > parser.parse_lines(sys.stdin, args.maxlines, '-')
> > File "scripts/spdxcheck.py", line 171, in parse_lines
> > line = line.decode(locale.getpreferredencoding(False), errors='ignore')
> > AttributeError: 'str' object has no attribute 'decode'
> >
> > So as the line is already a string, there is no need to decode it and
> > the line can be dropped.
>
> I suppose people might want to run spdxcheck.py against (say) 4.19.x
> using python3. So I'll add a cc:stable here, OK?
Not sure if people call spdxcheck.py stand-alone. checkpatch.pl calls it
using "python scripts/spdxcheck.py" which AFAICT should still be python2
on all machines. The shebang-line also uses "python" and not "python3".
So for now this is only cosmetic (unless there are distros that install
Python 3 as "python").
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2018-11-08 6:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-23 7:08 [PATCH] scripts/spdxcheck: make python3 compliant Uwe Kleine-König
2018-11-07 23:32 ` Andrew Morton
2018-11-08 6:22 ` Uwe Kleine-König [this message]
2018-11-08 7:59 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181108062200.ytkezavtcaypdlat@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=akpm@linux-foundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.