From mboxrd@z Thu Jan  1 00:00:00 1970
From: Hangbin Liu <liuhangbin@gmail.com>
Subject: Re: [PATCH net] ipv6/mcast: update mc_qrv when join new group
Date: Thu, 8 Nov 2018 15:44:10 +0800
Message-ID: <20181108074410.GO24677@leo.usersys.redhat.com>
References: <1540521054-17825-1-git-send-email-liuhangbin@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: netdev@vger.kernel.org
To: David Miller <davem@davemloft.net>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pf1-f194.google.com ([209.85.210.194]:33545 "EHLO
        mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726133AbeKHRSd (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 8 Nov 2018 12:18:33 -0500
Received: by mail-pf1-f194.google.com with SMTP id v68-v6so5346266pfk.0
        for <netdev@vger.kernel.org>; Wed, 07 Nov 2018 23:44:21 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <1540521054-17825-1-git-send-email-liuhangbin@gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Fri, Oct 26, 2018 at 10:30:54AM +0800, Hangbin Liu wrote:
> Currently we only set mc_qrv to sysctl_mld_qrv when interface up. If we
> change sysctl_mld_qrv after interface up, it will has no effect.
> 
> Fix it by assigning latest sysctl_mld_qrv to idev mc_qrv when join new group.
> 
> Reported-by: Ying Xu <yinxu@redhat.com>
> Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>

Hi David,

Any comments for this patch?

Thanks
Hangbin
> ---
>  net/ipv6/mcast.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/net/ipv6/mcast.c b/net/ipv6/mcast.c
> index dbab62e..bed4890 100644
> --- a/net/ipv6/mcast.c
> +++ b/net/ipv6/mcast.c
> @@ -680,6 +680,7 @@ static void igmp6_group_added(struct ifmcaddr6 *mc)
>  	if (!(dev->flags & IFF_UP) || (mc->mca_flags & MAF_NOREPORT))
>  		return;
>  
> +	mc->idev->mc_qrv = sysctl_mld_qrv;
>  	if (mld_in_v1_mode(mc->idev)) {
>  		igmp6_join_group(mc);
>  		return;
> -- 
> 2.5.5
>