From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?67Cw7ISd7KeE?= Subject: RE:(2) (2) (2) [Kernel][NET] Bug report on packet defragmenting Date: Thu, 08 Nov 2018 16:58:37 +0900 Message-ID: <20181108075837epcms1p2747d212aee83ba0df60cc14ffac316aa@epcms1p2> References: <1771721f-40fd-0042-b603-5ed763c54378@gmail.com> <91b43bec-cb19-b94b-8ee3-26979e3a19d1@gmail.com> <20181108012927epcms1p47f719c1908da64a378690362901644ee@epcms1p4> <20181108020523epcms1p55a0c28d3e881a079231fe813258602f6@epcms1p5> <20181108041001epcms1p6c83831e3ef0d66b9591c2aca25d5841b@epcms1p6> <8b2209af-1221-f4f5-54e5-d9f5a503373e@gmail.com> Reply-To: soukjin.bae@samsung.com Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable To: Eric Dumazet , "netdev@vger.kernel.org" Return-path: Received: from mailout1.samsung.com ([203.254.224.24]:60778 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725945AbeKHRdA (ORCPT ); Thu, 8 Nov 2018 12:33:00 -0500 Received: from epcas1p3.samsung.com (unknown [182.195.41.47]) by mailout1.samsung.com (KnoxPortal) with ESMTP id 20181108075840epoutp0136dc2606ae6d71076004592a2e4f7b4c~lFyr8nv1m0648306483epoutp01C for ; Thu, 8 Nov 2018 07:58:40 +0000 (GMT) In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: >--------- Original Message --------- >Sender : Eric Dumazet=C2=A0=0D=0A>Date=20=20=20:= =202018-11-08=2015:13=20(GMT+9)=0D=0A>Title=20=20:=20Re:=20(2)=20(2)=20=5BK= ernel=5D=5BNET=5D=20Bug=20report=20on=20packet=20defragmenting=0D=0A>=C2=A0= =0D=0A>On=C2=A011/07/2018=C2=A008:26=C2=A0PM,=C2=A0Eric=C2=A0Dumazet=C2=A0w= rote:=0D=0A>>=C2=A0=0D=0A>>=C2=A0=0D=0A>>=C2=A0On=C2=A011/07/2018=C2=A008:1= 0=C2=A0PM,=C2=A0=EB=B0=B0=EC=84=9D=EC=A7=84=C2=A0wrote:=0D=0A>>>>=C2=A0----= -----=C2=A0Original=C2=A0Message=C2=A0---------=0D=0A>>>>=C2=A0Sender=C2=A0= :=C2=A0Eric=C2=A0Dumazet=C2=A0=0D=0A>>>>=C2=A0Dat= e=C2=A0=C2=A0=C2=A0:=C2=A02018-11-08=C2=A012:57=C2=A0(GMT+9)=0D=0A>>>>=C2= =A0Title=C2=A0=C2=A0:=C2=A0Re:=C2=A0(2)=C2=A0=5BKernel=5D=5BNET=5D=C2=A0Bug= =C2=A0report=C2=A0on=C2=A0packet=C2=A0defragmenting=0D=0A>>>>=C2=A0=C2=A0= =0D=0A>>>>=C2=A0On=C2=A011/07/2018=C2=A007:24=C2=A0PM,=C2=A0Eric=C2=A0Dumaz= et=C2=A0wrote:=0D=0A>>>>=0D=0A>>>>>=C2=A0=C2=A0Sure,=C2=A0it=C2=A0is=C2=A0b= etter=C2=A0if=C2=A0RPS=C2=A0is=C2=A0smarter,=C2=A0but=C2=A0if=C2=A0there=C2= =A0is=C2=A0a=C2=A0bug=C2=A0in=C2=A0IPv6=C2=A0defrag=C2=A0unit=0D=0A>>>>>=C2= =A0=C2=A0we=C2=A0must=C2=A0investigate=C2=A0and=C2=A0root-cause=C2=A0it.=0D= =0A>>>>=C2=A0=C2=A0=0D=0A>>>>=C2=A0BTW,=C2=A0IPv4=C2=A0defrag=C2=A0seems=C2= =A0to=C2=A0have=C2=A0the=C2=A0same=C2=A0issue.=0D=0A>>>=C2=A0=C2=A0=0D=0A>>= >=0D=0A>>>=C2=A0yes,=C2=A0it=C2=A0could=C2=A0be.=0D=0A>>>=C2=A0key=C2=A0poi= nt=C2=A0isn't=C2=A0limitted=C2=A0to=C2=A0ipv6.=0D=0A>>>=0D=0A>>>=C2=A0maybe= =C2=A0because=C2=A0of=C2=A0faster=C2=A0air-network=C2=A0and=C2=A0modem,=0D= =0A>>>=C2=A0it=C2=A0looks=C2=A0like=C2=A0occure=C2=A0more=C2=A0often=C2=A0a= nd=C2=A0we=C2=A0got=C2=A0recognized=C2=A0that.=0D=0A>>>=0D=0A>>>=C2=A0anywa= y,=0D=0A>>>=C2=A0we'll=C2=A0apply=C2=A0our=C2=A0patch=C2=A0to=C2=A0resolve= =C2=A0this=C2=A0problem.=0D=0A>>=C2=A0=0D=0A>>=C2=A0Yeah,=C2=A0and=C2=A0I= =C2=A0will=C2=A0fix=C2=A0the=C2=A0defrag=C2=A0units.=0D=0A>>=0D=0A>>=C2=A0W= e=C2=A0can=C2=A0not=C2=A0rely=C2=A0on=C2=A0other=C2=A0layers=C2=A0doing=C2= =A0proper=C2=A0no-reorder=C2=A0logic=C2=A0for=C2=A0us.=0D=0A>>=C2=A0=0D=0A>= >=C2=A0Problem=C2=A0here=C2=A0is=C2=A0that=C2=A0multiple=C2=A0cpus=C2=A0att= empt=C2=A0concurrent=C2=A0rhashtable_insert_fast()=0D=0A>>=C2=A0and=C2=A0do= =C2=A0not=C2=A0properly=C2=A0recover=C2=A0in=C2=A0case=C2=A0-EEXIST=C2=A0is= =C2=A0returned.=0D=0A>>=C2=A0=0D=0A>>=C2=A0This=C2=A0is=C2=A0silly,=C2=A0of= =C2=A0course=C2=A0:/=0D=0A>=C2=A0=0D=0A>Patch=C2=A0would=C2=A0be=C2=A0https= ://patchwork.ozlabs.org/patch/994658/=0D=0A=C2=A0=0D=0A=0D=0ADear=20Dumazet= ,=0D=0A=0D=0Awith=20your=20patch,=20kernel=20got=20the=20panic=20when=20pac= ket=20recieved.=0D=0AI=20double=20checked=20after=20disable=20your=20patch,= =20then=20no=20problem.=0D=0A=0D=0A=0D=0A<6>=5B=20=20119.702054=5D=20I=5B3:= =20=20kworker/u18:1:=201705=5D=20LNK-RX(1464):=206b=2080=2000=2000=2005=209= 0=202c=203e=2020=2001=2044=2030=2000=2005=2004=2001=20...=0D=0A<6>=5B=20=20= 119.702120=5D=20I=5B3:=20=20kworker/u18:1:=201705=5D=20__skb_flow_dissect:= =20ports:=2077500000=0D=0A<6>=5B=20=20119.702153=5D=20I=5B3:=20=20kworker/u= 18:1:=201705=5D=20get_rps_cpu:=20cpu:2,=20hash:2055028308=0D=0A<6>=5B=20=20= 119.702203=5D=20I=5B3:=20=20kworker/u18:1:=201705=5D=20LNK-RX(1212):=206b= =2080=2000=2000=2004=2094=202c=203e=2020=2001=2044=2030=2000=2005=2004=2001= =20...=0D=0A<6>=5B=20=20119.702231=5D=20I=5B3:=20=20kworker/u18:1:=201705= =5D=20__skb_flow_dissect:=20ports:=203c7e2c6b=0D=0A<6>=5B=20=20119.702258= =5D=20I=5B3:=20=20kworker/u18:1:=201705=5D=20get_rps_cpu:=20cpu:1,=20hash:6= 71343869=0D=0A<6>=5B=20=20119.702365=5D=20I=5B1:=20Binder:11369_2:11382=5D= =20ipv6_rcv=20+++=0D=0A<6>=5B=20=20119.702375=5D=20I=5B2:=20=20=20=20=20=20= swapper/2:=20=20=20=200=5D=20ipv6_rcv=20+++=0D=0A<6>=5B=20=20119.702406=5D= =20I=5B2:=20=20=20=20=20=20swapper/2:=20=20=20=200=5D=20ipv6_defrag=20+++= =0D=0A<6>=5B=20=20119.702425=5D=20I=5B1:=20Binder:11369_2:11382=5D=20ipv6_d= efrag=20+++=0D=0A<6>=5B=20=20119.702494=5D=20I=5B2:=20=20=20=20=20=20swappe= r/2:=20=20=20=200=5D=20ipv6_defrag:=20EINPROGRESS=0D=0A<6>=5B=20=20119.7025= 22=5D=20I=5B2:=20=20=20=20=20=20swapper/2:=20=20=20=200=5D=20ipv6_rcv=20---= =0D=0A<6>=5B=20=20119.702628=5D=20I=5B1:=20Binder:11369_2:11382=5D=20ipv6_d= efrag=20---=0D=0A<6>=5B=20=20119.702892=5D=20I=5B1:=20Binder:11369_2:11382= =5D=20ipv6_defrag=20+++=0D=0A<6>=5B=20=20119.702922=5D=20I=5B1:=20Binder:11= 369_2:11382=5D=20ipv6_defrag=20---=0D=0A<6>=5B=20=20119.702966=5D=20I=5B1:= =20Binder:11369_2:11382=5D=20ipv6_rcv=20---=0D=0A<0>=5B=20=20119.703792=5D= =20=20=5B1:=20Binder:11369_2:11382=5D=20BUG:=20sleeping=20function=20called= =20from=20invalid=20context=20at=20arch/arm64/mm/fault.c:518=0D=0A<3>=5B=20= =20119.703826=5D=20=20=5B1:=20Binder:11369_2:11382=5D=20in_atomic():=200,= =20irqs_disabled():=200,=20pid:=2011382,=20name:=20Binder:11369_2=0D=0A<3>= =5B=20=20119.703854=5D=20=20=5B1:=20Binder:11369_2:11382=5D=20Preemption=20= disabled=20at:=0D=0A<4>=5B=20=20119.703888=5D=20=20=5B1:=20Binder:11369_2:1= 1382=5D=20=5B=5D=20__do_softirq+0x68/0x3c4=0D=0A<4>=5B=20= =20119.703934=5D=20=20=5B1:=20Binder:11369_2:11382=5D=20CPU:=201=20PID:=201= 1382=20Comm:=20Binder:11369_2=20Tainted:=20G=20S=20=20=20=20=20=20W=20=20= =20=20=20=20=204.14.75-20181108-163447-eng=20=230=0D=0A<4>=5B=20=20119.7039= 60=5D=20=20=5B1:=20Binder:11369_2:11382=5D=20Hardware=20name:=20Samsung=20B= EYOND2LTE=20KOR=20SINGLE=2019=20board=20based=20on=20EXYNOS9820=20(DT)=0D= =0A<4>=5B=20=20119.703987=5D=20=20=5B1:=20Binder:11369_2:11382=5D=20Call=20= trace:=0D=0A<4>=5B=20=20119.704015=5D=20=20=5B1:=20Binder:11369_2:11382=5D= =20=5B=5D=20dump_backtrace+0x0/0x280=0D=0A<4>=5B=20=20119= .704045=5D=20=20=5B1:=20Binder:11369_2:11382=5D=20=5B=5D= =20show_stack+0x18/0x24=0D=0A<4>=5B=20=20119.704074=5D=20=20=5B1:=20Binder:= 11369_2:11382=5D=20=5B=5D=20dump_stack+0xb8/0xf8=0D=0A<4>= =5B=20=20119.704104=5D=20=20=5B1:=20Binder:11369_2:11382=5D=20=5B=5D=20___might_sleep+0x16c/0x178=0D=0A<4>=5B=20=20119.704132=5D=20= =20=5B1:=20Binder:11369_2:11382=5D=20=5B=5D=20__might_sle= ep+0x4c/0x84=0D=0A<4>=5B=20=20119.704164=5D=20=20=5B1:=20Binder:11369_2:113= 82=5D=20=5B=5D=20do_page_fault+0x2e8/0x4b8=0D=0A<4>=5B=20= =20119.704193=5D=20=20=5B1:=20Binder:11369_2:11382=5D=20=5B=5D=20do_translation_fault+0x7c/0x100=0D=0A<4>=5B=20=20119.704219=5D=20= =20=5B1:=20Binder:11369_2:11382=5D=20=5B=5D=20do_mem_abor= t+0x4c/0x12c=0D=0A<4>=5B=20=20119.704243=5D=20=20=5B1:=20Binder:11369_2:113= 82=5D=20Exception=20stack(0xffffff8038bf3ec0=20to=200xffffff8038bf4000)=0D= =0A<4>=5B=20=20119.704266=5D=20=20=5B1:=20Binder:11369_2:11382=5D=203ec0:= =2000000077b8262600=2000000077b1bd0800=2000000000708fcae0=20000000000000001= 8=0D=0A...=0D=0A<4>=5B=20=20119.704459=5D=20=20=5B1:=20Binder:11369_2:11382= =5D=203fe0:=200000000000000000=200000000000000000=200000000000000000=200000= 000000000000=0D=0A<4>=5B=20=20119.704480=5D=20=20=5B1:=20Binder:11369_2:113= 82=5D=20=5B=5D=20el0_da+0x20/0x24=0D=0A<4>=5B=20=20119.70= 4509=5D=20=20=5B1:=20Binder:11369_2:11382=5D=20------------=5B=20cut=20here= =20=5D------------=0D=0A<0>=5B=20=20119.704541=5D=20=20=5B1:=20Binder:11369= _2:11382=5D=20kernel=20BUG=20at=20kernel/sched/core.c:6152=21=0D=0A<2>=5B= =20=20119.704563=5D=20=20=5B1:=20Binder:11369_2:11382=5D=20sec_debug_set_ex= tra_info_fault=20=3D=20BUG=20/=200xffffff800811f180=0D=0A<0>=5B=20=20119.70= 4603=5D=20=20=5B1:=20Binder:11369_2:11382=5D=20Internal=20error:=20Oops=20-= =20BUG:=200=20=5B=231=5D=20PREEMPT=20SMP=0D=0A=0D=0A