From: Michal Hocko <email@example.com> To: Anshuman Khandual <firstname.lastname@example.org> Cc: email@example.com, Andrew Morton <firstname.lastname@example.org>, Oscar Salvador <OSalvador@suse.com>, Baoquan He <email@example.com>, LKML <firstname.lastname@example.org> Subject: Re: [RFC PATCH 4/5] mm, memory_hotplug: print reason for the offlining failure Date: Thu, 8 Nov 2018 08:59:34 +0100 [thread overview] Message-ID: <20181108075934.GL27423@dhcp22.suse.cz> (raw) In-Reply-To: <email@example.com> On Thu 08-11-18 11:53:21, Anshuman Khandual wrote: > > > On 11/07/2018 03:48 PM, Michal Hocko wrote: > > From: Michal Hocko <firstname.lastname@example.org> > > > > The memory offlining failure reporting is inconsistent and insufficient. > > Some error paths simply do not report the failure to the log at all. > > When we do report there are no details about the reason of the failure > > and there are several of them which makes memory offlining failures > > hard to debug. > > > > Make sure that the > > memory offlining [mem %#010llx-%#010llx] failed > > message is printed for all failures and also provide a short textual > > reason for the failure e.g. > > > > [ 1984.506184] rac1 kernel: memory offlining [mem 0x82600000000-0x8267fffffff] failed due to signal backoff > > > > this tells us that the offlining has failed because of a signal pending > > aka user intervention. > > > > Signed-off-by: Michal Hocko <email@example.com> > > It might help to enumerate these failure reason strings and use macros. Does it really make sense when all of them are on-off things? I would agree if they were reused somewhere. -- Michal Hocko SUSE Labs
next prev parent reply other threads:[~2018-11-08 7:59 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-11-07 10:18 [RFC PATCH 0/5] mm, memory_hotplug: improve memory offlining failures debugging Michal Hocko 2018-11-07 10:18 ` Michal Hocko 2018-11-07 10:18 ` [RFC PATCH 1/5] mm: print more information about mapping in __dump_page Michal Hocko 2018-11-07 10:18 ` Michal Hocko 2018-11-24 0:04 ` Andrew Morton 2018-11-24 0:04 ` Andrew Morton 2018-11-25 8:10 ` Michal Hocko 2018-11-07 10:18 ` [RFC PATCH 2/5] mm: lower the printk loglevel for __dump_page messages Michal Hocko 2018-11-07 10:18 ` Michal Hocko 2018-11-16 0:56 ` Baoquan He 2018-12-12 14:25 ` Michal Hocko 2018-12-12 14:34 ` Michal Hocko 2018-11-07 10:18 ` [RFC PATCH 3/5] mm, memory_hotplug: drop pointless block alignment checks from __offline_pages Michal Hocko 2018-11-07 10:18 ` Michal Hocko 2018-11-07 10:18 ` [RFC PATCH 4/5] mm, memory_hotplug: print reason for the offlining failure Michal Hocko 2018-11-07 10:18 ` Michal Hocko 2018-11-07 22:04 ` Andrew Morton 2018-11-07 22:04 ` Andrew Morton 2018-11-08 8:01 ` Michal Hocko 2018-11-13 8:02 ` Michal Hocko 2018-11-08 6:23 ` Anshuman Khandual 2018-11-08 7:59 ` Michal Hocko [this message] 2018-11-07 10:18 ` [RFC PATCH 5/5] mm, memory_hotplug: be more verbose for memory offline failures Michal Hocko 2018-11-07 10:18 ` Michal Hocko 2018-11-08 7:16 ` Anshuman Khandual 2018-11-08 8:12 ` Michal Hocko 2018-11-08 8:19 ` Anshuman Khandual 2018-11-13 8:03 ` Michal Hocko 2018-11-16 0:07 ` Andrew Morton 2018-11-16 0:07 ` Andrew Morton 2018-11-16 7:21 ` Michal Hocko 2018-11-16 7:21 ` Michal Hocko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20181108075934.GL27423@dhcp22.suse.cz \ --firstname.lastname@example.org \ --cc=OSalvador@suse.com \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [RFC PATCH 4/5] mm, memory_hotplug: print reason for the offlining failure' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.