From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75EEBC46465 for ; Thu, 8 Nov 2018 09:32:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 48A6720817 for ; Thu, 8 Nov 2018 09:32:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 48A6720817 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=8bytes.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726988AbeKHTHP (ORCPT ); Thu, 8 Nov 2018 14:07:15 -0500 Received: from 8bytes.org ([81.169.241.247]:60376 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726906AbeKHTHP (ORCPT ); Thu, 8 Nov 2018 14:07:15 -0500 Received: by theia.8bytes.org (Postfix, from userid 1000) id 43E2F42D; Thu, 8 Nov 2018 10:32:37 +0100 (CET) Date: Thu, 8 Nov 2018 10:32:37 +0100 From: Joerg Roedel To: YueHaibing Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH -next] iommu/amd: remove set but not used variable 'tag' Message-ID: <20181108093237.GE19831@8bytes.org> References: <1541657560-73681-1-git-send-email-yuehaibing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1541657560-73681-1-git-send-email-yuehaibing@huawei.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 08, 2018 at 06:12:40AM +0000, YueHaibing wrote: > - tag = event[1] & 0x03FF; > dev_err(dev, "INVALID_PPR_REQUEST device=%02x:%02x.%x pasid=0x%05x address=0x%016llx flags=0x%04x]\n", > PCI_BUS_NUM(devid), PCI_SLOT(devid), PCI_FUNC(devid), > pasid, address, flags); This looks like tag was just missed in the error message. It is better to add it there instead of removing it. Regards, Joerg From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joerg Roedel Date: Thu, 08 Nov 2018 09:32:37 +0000 Subject: Re: [PATCH -next] iommu/amd: remove set but not used variable 'tag' Message-Id: <20181108093237.GE19831@8bytes.org> List-Id: References: <1541657560-73681-1-git-send-email-yuehaibing@huawei.com> In-Reply-To: <1541657560-73681-1-git-send-email-yuehaibing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: YueHaibing Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org On Thu, Nov 08, 2018 at 06:12:40AM +0000, YueHaibing wrote: > - tag = event[1] & 0x03FF; > dev_err(dev, "INVALID_PPR_REQUEST device=%02x:%02x.%x pasid=0x%05x address=0x%016llx flags=0x%04x]\n", > PCI_BUS_NUM(devid), PCI_SLOT(devid), PCI_FUNC(devid), > pasid, address, flags); This looks like tag was just missed in the error message. It is better to add it there instead of removing it. Regards, Joerg