From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 12/14] drm/i915: Remove some useless zeroing on skl+ wm calculations Date: Thu, 8 Nov 2018 13:46:58 +0200 Message-ID: <20181108114658.GT9144@intel.com> References: <20181101150605.18235-1-ville.syrjala@linux.intel.com> <20181101150605.18235-13-ville.syrjala@linux.intel.com> <20181107221110.GO2237@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 046106E60C for ; Thu, 8 Nov 2018 11:47:01 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20181107221110.GO2237@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Rodrigo Vivi Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBOb3YgMDcsIDIwMTggYXQgMDI6MTE6MTBQTSAtMDgwMCwgUm9kcmlnbyBWaXZpIHdy b3RlOgo+IAo+IE9uIFRodSwgTm92IDAxLCAyMDE4IGF0IDA1OjA2OjAzUE0gKzAyMDAsIFZpbGxl IFN5cmphbGEgd3JvdGU6Cj4gPiBGcm9tOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFA bGludXguaW50ZWwuY29tPgo+ID4gCj4gPiBXZSBtZW1zZXQoMCkgdGhlIGVudGlyZSB3YXRlcm1h cmsgc3RydWN0IHRoZSBzdGFydCwgc28gdGhlcmUncyBubwo+ID4gbmVlZCB0byBjbGVhciB0aGlu Z3MgbGF0ZXIgb24uCj4gPiAKPiA+IFNpZ25lZC1vZmYtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmls bGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gPiAtLS0KPiA+ICBkcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9wbS5jIHwgMjAgKysrKystLS0tLS0tLS0tLS0tLS0KPiA+ICAxIGZpbGUgY2hh bmdlZCwgNSBpbnNlcnRpb25zKCspLCAxNSBkZWxldGlvbnMoLSkKPiA+IAo+ID4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BtLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9wbS5jCj4gPiBpbmRleCBiZDVmMTZiYzdlMDguLmIwNzIwOTk0ZmEwYSAxMDA2NDQK PiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BtLmMKPiA+ICsrKyBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX3BtLmMKPiA+IEBAIC00NzA2LDEwICs0NzA2LDggQEAgc3Rh dGljIGludCBza2xfY29tcHV0ZV9wbGFuZV93bShjb25zdCBzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0 ZSAqZGV2X3ByaXYsCj4gPiAgCWlmIChsYXRlbmN5ID09IDApCj4gPiAgCQlyZXR1cm4gbGV2ZWwg PT0gMCA/IC1FSU5WQUwgOiAwOwo+ID4gIAo+ID4gLQlpZiAoIWludGVsX3dtX3BsYW5lX3Zpc2li bGUoY3N0YXRlLCBpbnRlbF9wc3RhdGUpKSB7Cj4gPiAtCQlyZXN1bHQtPnBsYW5lX2VuID0gZmFs c2U7Cj4gPiArCWlmICghaW50ZWxfd21fcGxhbmVfdmlzaWJsZShjc3RhdGUsIGludGVsX3BzdGF0 ZSkpCj4gPiAgCQlyZXR1cm4gMDsKPiA+IC0JfQo+ID4gIAo+ID4gIAkvKiBEaXNwbGF5IFdBICMx MTQxOiBrYmwsY2ZsICovCj4gPiAgCWlmICgoSVNfS0FCWUxBS0UoZGV2X3ByaXYpIHx8IElTX0NP RkZFRUxBS0UoZGV2X3ByaXYpIHx8Cj4gPiBAQCAtNDgwNiw4ICs0ODA0LDYgQEAgc3RhdGljIGlu dCBza2xfY29tcHV0ZV9wbGFuZV93bShjb25zdCBzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2 X3ByaXYsCj4gPiAgCWlmICgobGV2ZWwgPiAwICYmIHJlc19saW5lcyA+IDMxKSB8fAo+ID4gIAkg ICAgcmVzX2Jsb2NrcyA+PSBkZGJfYWxsb2NhdGlvbiB8fAo+ID4gIAkgICAgbWluX2Rpc3BfYnVm X25lZWRlZCA+PSBkZGJfYWxsb2NhdGlvbikgewo+ID4gLQkJcmVzdWx0LT5wbGFuZV9lbiA9IGZh bHNlOwo+ID4gLQo+ID4gIAkJLyoKPiA+ICAJCSAqIElmIHRoZXJlIGFyZSBubyB2YWxpZCBsZXZl bCAwIHdhdGVybWFya3MsIHRoZW4gd2UgY2FuJ3QKPiA+ICAJCSAqIHN1cHBvcnQgdGhpcyBkaXNw bGF5IGNvbmZpZ3VyYXRpb24uCj4gPiBAQCAtNDgzMSwxMCArNDgyNyw4IEBAIHN0YXRpYyBpbnQg c2tsX2NvbXB1dGVfcGxhbmVfd20oY29uc3Qgc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9w cml2LAo+ID4gIAkgKi8KPiA+ICAJaWYgKHdwLT5pc19wbGFuYXIgJiYgbGV2ZWwgPj0gMSAmJgo+ ID4gIAkgICAgKElTX1NLWUxBS0UoZGV2X3ByaXYpIHx8IElTX0JST1hUT04oZGV2X3ByaXYpIHx8 Cj4gPiAtCSAgICAgSVNfQ05MX1JFVklEKGRldl9wcml2LCBDTkxfUkVWSURfQTAsIENOTF9SRVZJ RF9BMCkpKSB7Cj4gPiAtCQlyZXN1bHQtPnBsYW5lX2VuID0gZmFsc2U7Cj4gPiArCSAgICAgSVNf Q05MX1JFVklEKGRldl9wcml2LCBDTkxfUkVWSURfQTAsIENOTF9SRVZJRF9BMCkpKQo+IAo+IHRo aXMgcmVtaW5kcyBtZSB0aGF0IEkgcHJvYmFibHkgZm9yZ290IG9uZSBwYXRjaCBiZWhpbmQgc29t ZXdoZXJlLi4uCgpOYWguIFlvdSBqdXN0IHJldmlld2VkIHRoZSBvbGQgdmVyc2lvbiBoZXJlIDop Cgo+IAo+IAo+IFJldmlld2VkLWJ5OiBSb2RyaWdvIFZpdmkgPHJvZHJpZ28udml2aUBpbnRlbC5j b20+Cj4gCj4gCj4gPiAgCQlyZXR1cm4gMDsKPiA+IC0JfQo+ID4gIAo+ID4gIAkvKiBUaGUgbnVt YmVyIG9mIGxpbmVzIGFyZSBpZ25vcmVkIGZvciB0aGUgbGV2ZWwgMCB3YXRlcm1hcmsuICovCj4g PiAgCXJlc3VsdC0+cGxhbmVfcmVzX2IgPSByZXNfYmxvY2tzOwo+ID4gQEAgLTQ5MjAsMTUgKzQ5 MTQsMTUgQEAgc3RhdGljIHZvaWQgc2tsX2NvbXB1dGVfdHJhbnNpdGlvbl93bShjb25zdCBzdHJ1 Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqY3N0YXRlLAo+ID4gIAl1aW50MTZfdCB3bTBfc2VsX3Jlc19i LCB0cmFuc19vZmZzZXRfYiwgcmVzX2Jsb2NrczsKPiA+ICAKPiA+ICAJaWYgKCFjc3RhdGUtPmJh c2UuYWN0aXZlKQo+ID4gLQkJZ290byBleGl0Owo+ID4gKwkJcmV0dXJuOwo+ID4gIAo+ID4gIAkv KiBUcmFuc2l0aW9uIFdNIGFyZSBub3QgcmVjb21tZW5kZWQgYnkgSFcgdGVhbSBmb3IgR0VOOSAq Lwo+ID4gIAlpZiAoSU5URUxfR0VOKGRldl9wcml2KSA8PSA5KQo+ID4gLQkJZ290byBleGl0Owo+ ID4gKwkJcmV0dXJuOwo+ID4gIAo+ID4gIAkvKiBUcmFuc2l0aW9uIFdNIGRvbid0IG1ha2UgYW55 IHNlbnNlIGlmIGlwYyBpcyBkaXNhYmxlZCAqLwo+ID4gIAlpZiAoIWRldl9wcml2LT5pcGNfZW5h YmxlZCkKPiA+IC0JCWdvdG8gZXhpdDsKPiA+ICsJCXJldHVybjsKPiA+ICAKPiA+ICAJdHJhbnNf bWluID0gMTQ7Cj4gPiAgCWlmIChJTlRFTF9HRU4oZGV2X3ByaXYpID49IDExKQo+ID4gQEAgLTQ5 NjcsMTEgKzQ5NjEsNyBAQCBzdGF0aWMgdm9pZCBza2xfY29tcHV0ZV90cmFuc2l0aW9uX3dtKGNv bnN0IHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjc3RhdGUsCj4gPiAgCWlmIChyZXNfYmxvY2tz IDwgZGRiX2FsbG9jYXRpb24pIHsKPiA+ICAJCXRyYW5zX3dtLT5wbGFuZV9yZXNfYiA9IHJlc19i bG9ja3M7Cj4gPiAgCQl0cmFuc193bS0+cGxhbmVfZW4gPSB0cnVlOwo+ID4gLQkJcmV0dXJuOwo+ ID4gIAl9Cj4gPiAtCj4gPiAtZXhpdDoKPiA+IC0JdHJhbnNfd20tPnBsYW5lX2VuID0gZmFsc2U7 Cj4gPiAgfQo+ID4gIAo+ID4gIHN0YXRpYyBpbnQgX19za2xfYnVpbGRfcGxhbmVfd21fc2luZ2xl KHN0cnVjdCBza2xfZGRiX2FsbG9jYXRpb24gKmRkYiwKPiA+IC0tIAo+ID4gMi4xOC4xCj4gPiAK PiA+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gPiBJ bnRlbC1nZnggbWFpbGluZyBsaXN0Cj4gPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn Cj4gPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVs LWdmeAoKLS0gClZpbGxlIFN5cmrDpGzDpApJbnRlbApfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBs aXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1h bi9saXN0aW5mby9pbnRlbC1nZngK