From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1gKmMl-0007C5-8Z for mharc-grub-devel@gnu.org; Thu, 08 Nov 2018 10:37:07 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50790) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gKmMj-0007Bz-IT for grub-devel@gnu.org; Thu, 08 Nov 2018 10:37:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gKmMe-0001ZG-Kg for grub-devel@gnu.org; Thu, 08 Nov 2018 10:37:05 -0500 Received: from aserp2120.oracle.com ([141.146.126.78]:47248) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gKmMe-0001XA-B3 for grub-devel@gnu.org; Thu, 08 Nov 2018 10:37:00 -0500 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id wA8FXWCD120218; Thu, 8 Nov 2018 15:36:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2018-07-02; bh=MKYZhOm9EKUM6Flx/qQ1biGKZF7I7pOBHzgWObJnWe4=; b=RoGxr7naP4LzI/9dJt+rXzbrkz6l2j2DpnAhwxDpPDJCR+4KQgZgMkaGboh06FisVSwx hpZG+I+Zb6wlNQmsHLB2y5RBdg3uR6I9FoB5Oq0JsgYjoSEoxgGYJqXStH6U/2uVbLUo pKkxvQvi1cYt+uUU45sZW4+Ke9/LuwFRzJ1XbETdZ4uulWpp+1jsY3qgVkFIIhPMfS2B ib3MdpT1k6/nhmvLIGPRPW8l17fqU3ePV4CZFXkIvvOVH8p2AUEqfTHXRxxxiXHx4dfS a0pzVAYxVx6xyFGrOveXuOFqFQPEWwt/ZhTdjIAlcoqqr8IhdA0PUhqCE5IRgGOzsV/R PQ== Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by aserp2120.oracle.com with ESMTP id 2nh3mq24sa-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 08 Nov 2018 15:36:56 +0000 Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserv0021.oracle.com (8.14.4/8.14.4) with ESMTP id wA8Fau0Y030925 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 8 Nov 2018 15:36:56 GMT Received: from abhmp0004.oracle.com (abhmp0004.oracle.com [141.146.116.10]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id wA8FasCr015351; Thu, 8 Nov 2018 15:36:54 GMT Received: from olila.i.net-space.pl (/10.175.185.5) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 08 Nov 2018 07:36:54 -0800 Date: Thu, 8 Nov 2018 16:36:48 +0100 From: Daniel Kiper To: Juergen Gross Cc: grub-devel@gnu.org, xen-devel@lists.xen.org, phcoder@gmail.com, hans@knorrie.org Subject: Re: [PATCH v4 05/19] xen: add some dummy headers for PVH mode Message-ID: <20181108153648.GG4487@olila.i.net-space.pl> References: <20181102123738.16395-1-jgross@suse.com> <20181102123738.16395-6-jgross@suse.com> <20181107122115.GG4358@olila.i.net-space.pl> <4fc4f85b-7bc0-b1a5-7ad4-eedebc835ea8@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4fc4f85b-7bc0-b1a5-7ad4-eedebc835ea8@suse.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9070 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1811080130 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-Received-From: 141.146.126.78 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Nov 2018 15:37:06 -0000 On Wed, Nov 07, 2018 at 03:49:51PM +0100, Juergen Gross wrote: > On 07/11/2018 13:21, Daniel Kiper wrote: > > On Fri, Nov 02, 2018 at 01:37:24PM +0100, Juergen Gross wrote: > >> With Xen PVH mode adding a new machine type the machine related headers > >> need to be present for the build to succeed. Most of the headers just > >> need to include the related common i386 headers. Add those to the tree. > >> > >> Signed-off-by: Juergen Gross > >> --- > >> V3: updated commit message (Daniel Kiper) > >> xenpvh->xen_pvh (Daniel Kiper) > >> --- > >> include/grub/i386/xen_pvh/boot.h | 1 + > >> include/grub/i386/xen_pvh/console.h | 1 + > >> include/grub/i386/xen_pvh/int.h | 1 + > >> include/grub/i386/xen_pvh/memory.h | 1 + > >> include/grub/i386/xen_pvh/time.h | 1 + > >> 5 files changed, 5 insertions(+) > >> create mode 100644 include/grub/i386/xen_pvh/boot.h > >> create mode 100644 include/grub/i386/xen_pvh/console.h > >> create mode 100644 include/grub/i386/xen_pvh/int.h > >> create mode 100644 include/grub/i386/xen_pvh/memory.h > >> create mode 100644 include/grub/i386/xen_pvh/time.h > >> > >> diff --git a/include/grub/i386/xen_pvh/boot.h b/include/grub/i386/xen_pvh/boot.h > >> new file mode 100644 > >> index 000000000..6cd23aa83 > >> --- /dev/null > >> +++ b/include/grub/i386/xen_pvh/boot.h > >> @@ -0,0 +1 @@ > >> +#include > >> diff --git a/include/grub/i386/xen_pvh/console.h b/include/grub/i386/xen_pvh/console.h > >> new file mode 100644 > >> index 000000000..305a46d8e > >> --- /dev/null > >> +++ b/include/grub/i386/xen_pvh/console.h > >> @@ -0,0 +1 @@ > >> +#include > >> diff --git a/include/grub/i386/xen_pvh/int.h b/include/grub/i386/xen_pvh/int.h > >> new file mode 100644 > >> index 000000000..0f1f9ee62 > >> --- /dev/null > >> +++ b/include/grub/i386/xen_pvh/int.h > >> @@ -0,0 +1 @@ > >> +#include > > > > I think that this begs for explanation in the commit message > > why not grub/i386/pc/int.h. > > Okay. > > > > >> diff --git a/include/grub/i386/xen_pvh/memory.h b/include/grub/i386/xen_pvh/memory.h > >> new file mode 100644 > >> index 000000000..8dd6f7c8c > >> --- /dev/null > >> +++ b/include/grub/i386/xen_pvh/memory.h > >> @@ -0,0 +1 @@ > >> +#include > > > > Hmmm... Why not include/grub/i386/pc/memory.h? > > The coreboot variant is containing the stubs grub_machine_mmap_register > and grub_machine_mmap_unregister I need, with the pc variant I'd have to > add those to xen-pvh code. > > Using the coreboot variant for that purpose seems to be common practice: > include/grub/i386/qemu/memory.h > include/grub/i386/ieee1275/memory.h > include/grub/i386/multiboot/memory.h > are doing exactly the same. I am OK with it then. However, please say about that in the commit message. Otherwise it looks like a mistake. Daniel