From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH net-next v2 3/5] virtio_ring: add packed ring support Date: Thu, 8 Nov 2018 22:58:44 -0500 Message-ID: <20181108225555-mutt-send-email-mst__25975.7068510682$1541735809$gmane$org@kernel.org> References: <20180711022711.7090-1-tiwei.bie@intel.com> <20180711022711.7090-4-tiwei.bie@intel.com> <20181107123933-mutt-send-email-mst@kernel.org> <20181108013759.GA20591@debian> <2d46a41e-bc00-276a-e19a-105c9dffc75a@redhat.com> <20181108091337-mutt-send-email-mst@kernel.org> <21d6dbd9-8f78-6939-0e80-27b470aeb00a@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <21d6dbd9-8f78-6939-0e80-27b470aeb00a@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Jason Wang Cc: virtio-dev@lists.oasis-open.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, wexu@redhat.com List-Id: virtualization@lists.linuxfoundation.org T24gRnJpLCBOb3YgMDksIDIwMTggYXQgMTA6MjU6MjhBTSArMDgwMCwgSmFzb24gV2FuZyB3cm90 ZToKPiAKPiBPbiAyMDE4LzExLzgg5LiL5Y2IMTA6MTQsIE1pY2hhZWwgUy4gVHNpcmtpbiB3cm90 ZToKPiA+IE9uIFRodSwgTm92IDA4LCAyMDE4IGF0IDA0OjE4OjI1UE0gKzA4MDAsIEphc29uIFdh bmcgd3JvdGU6Cj4gPiA+IE9uIDIwMTgvMTEvOCDkuIrljYg5OjM4LCBUaXdlaSBCaWUgd3JvdGU6 Cj4gPiA+ID4gPiA+ICsKPiA+ID4gPiA+ID4gKwlpZiAodnEtPnZxLm51bV9mcmVlIDwgZGVzY3Nf dXNlZCkgewo+ID4gPiA+ID4gPiArCQlwcl9kZWJ1ZygiQ2FuJ3QgYWRkIGJ1ZiBsZW4gJWkgLSBh dmFpbCA9ICVpXG4iLAo+ID4gPiA+ID4gPiArCQkJIGRlc2NzX3VzZWQsIHZxLT52cS5udW1fZnJl ZSk7Cj4gPiA+ID4gPiA+ICsJCS8qIEZJWE1FOiBmb3IgaGlzdG9yaWNhbCByZWFzb25zLCB3ZSBm b3JjZSBhIG5vdGlmeSBoZXJlIGlmCj4gPiA+ID4gPiA+ICsJCSAqIHRoZXJlIGFyZSBvdXRnb2lu ZyBwYXJ0cyB0byB0aGUgYnVmZmVyLiAgUHJlc3VtYWJseSB0aGUKPiA+ID4gPiA+ID4gKwkJICog aG9zdCBzaG91bGQgc2VydmljZSB0aGUgcmluZyBBU0FQLiAqLwo+ID4gPiA+ID4gSSBkb24ndCB0 aGluayB3ZSBoYXZlIGEgcmVhc29uIHRvIGRvIHRoaXMgZm9yIHBhY2tlZCByaW5nLgo+ID4gPiA+ ID4gTm8gaGlzdG9yaWNhbCBiYWdnYWdlIHRoZXJlLCByaWdodD8KPiA+ID4gPiBCYXNlZCBvbiB0 aGUgb3JpZ2luYWwgY29tbWl0IGxvZywgaXQgc2VlbXMgdGhhdCB0aGUgbm90aWZ5IGhlcmUKPiA+ ID4gPiBpcyBqdXN0IGFuICJvcHRpbWl6YXRpb24iLiBCdXQgSSBkb24ndCBxdWl0ZSB1bmRlcnN0 YW5kIHdoYXQgZG9lcwo+ID4gPiA+IHRoZSAidGhlIGhldXJpc3RpY3Mgd2hpY2ggS1ZNIHVzZXMi IHJlZmVyIHRvLiBJZiBpdCdzIHNhZmUgdG8gZHJvcAo+ID4gPiA+IHRoaXMgaW4gcGFja2VkIHJp bmcsIEknZCBsaWtlIHRvIGRvIGl0Lgo+ID4gPiAKPiA+ID4gQWNjb3JkaW5nIHRvIHRoZSBjb21t aXQgbG9nLCBpdCBzZWVtcyBsaWtlIGEgd29ya2Fyb3VuZCBvZiBsZ3Vlc3QgbmV0d29ya2luZwo+ ID4gPiBiYWNrZW5kLiBJIGFncmVlIHRvIGRyb3AgaXQsIHdlIHNob3VsZCBub3QgaGF2ZSBzdWNo IGJ1cmRlbi4KPiA+ID4gCj4gPiA+IEJ1dCB3ZSBzaG91bGQgbm90aWNlIHRoYXQsIHdpdGggdGhp cyByZW1vdmVkLCB0aGUgY29tcGFyZSBiZXR3ZWVuIHBhY2tlZCB2cwo+ID4gPiBzcGxpdCBpcyBr aW5kIG9mIHVuZmFpci4KPiA+IEkgZG9uJ3QgdGhpbmsgdGhpcyBldmVyIHRyaWdnZXJzIHRvIGJl IGZyYW5rLiBXaGVuIHdvdWxkIGl0Pwo+IAo+IAo+IEkgdGhpbmsgaXQgY2FuIGhhcHBlbiBlLmcg aW4gdGhlIHBhdGggb2YgWERQIHRyYW5zbWlzc2lvbiBpbgo+IF9fdmlydG5ldF94ZHBfeG1pdF9v bmUoKToKPiAKPiAKPiDCoMKgwqDCoMKgwqDCoCBlcnIgPSB2aXJ0cXVldWVfYWRkX291dGJ1Zihz cS0+dnEsIHNxLT5zZywgMSwgeGRwZiwgR0ZQX0FUT01JQyk7Cj4gwqDCoMKgwqDCoMKgwqAgaWYg KHVubGlrZWx5KGVycikpCj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHJldHVybiAt RU5PU1BDOyAvKiBDYWxsZXIgaGFuZGxlIGZyZWUvcmVmY250ICovCj4gCgpJIHNlZS4gV2UgdXNl ZCB0byBkbyBpdCBmb3IgcmVndWxhciB4bWl0IGJ1dCBzdG9wcGVkCmRvaW5nIGl0LiBJcyBpdCBm aW5lIGZvciB4ZHAgdGhlbj8KCj4gPiAKPiA+ID4gQ29uc2lkZXIgdGhlIHJlbW92YWwgb2YgbGd1 ZXN0IHN1cHBvcnQgcmVjZW50bHksCj4gPiA+IG1heWJlIHdlIGNhbiBkcm9wIHRoaXMgZm9yIHNw bGl0IHJpbmcgYXMgd2VsbD8KPiA+ID4gCj4gPiA+IFRoYW5rcwo+ID4gSWYgaXQncyBoZWxwZnVs LCB0aGVuIGZvciBzdXJlIHdlIGNhbiBkcm9wIGl0IGZvciB2aXJ0aW8gMS4KPiA+IENhbiB5b3Ug c2VlIGFueSBwZXJmIGRpZmZlcmVuY2VzIGF0IGFsbD8gV2l0aCB3aGljaCBkZXZpY2U/Cj4gCj4g Cj4gSSBkb24ndCB0ZXN0IGJ1dCBjb25zaWRlciB0aGUgY2FzZSBvZiBYRFBfVFggaW4gZ3Vlc3Qg cGx1cyB2aG9zdF9uZXQgaW4KPiBob3N0LiBTaW5jZSB2aG9zdF9uZXQgaXMgaGFsZiBkdXBsZXgs IGl0J3MgcHJldHR5IGVhc2llciB0byB0cmlnZ2VyIHRoaXMKPiBjb25kaXRpb24uCj4gCj4gVGhh bmtzCgpTb3VuZHMgcmVhc29uYWJsZS4gV29ydGggdGVzdGluZyBiZWZvcmUgd2UgY2hhbmdlIHRo aW5ncyB0aG91Z2guCgo+IAo+ID4gCj4gPiA+ID4gY29tbWl0IDQ0NjUzZWFlMTQwN2Y3OWRmZjZm NTJmY2Y1OTRhZTg0Y2IxNjVlYzQKPiA+ID4gPiBBdXRob3I6IFJ1c3R5IFJ1c3NlbGw8cnVzdHlA cnVzdGNvcnAuY29tLmF1Pgo+ID4gPiA+IERhdGU6ICAgRnJpIEp1bCAyNSAxMjowNjowNCAyMDA4 IC0wNTAwCj4gPiA+ID4gCj4gPiA+ID4gICAgICAgdmlydGlvOiBkb24ndCBhbHdheXMgZm9yY2Ug YSBub3RpZmljYXRpb24gd2hlbiByaW5nIGlzIGZ1bGwKPiA+ID4gPiAgICAgICBXZSBmb3JjZSBu b3RpZmljYXRpb24gd2hlbiB0aGUgcmluZyBpcyBmdWxsLCBldmVuIGlmIHRoZSBob3N0IGhhcwo+ ID4gPiA+ICAgICAgIGluZGljYXRlZCBpdCBkb2Vzbid0IHdhbnQgdG8ga25vdy4gIFRoaXMgc2Vl bWVkIGxpa2UgYSBnb29kIGlkZWEgYXQKPiA+ID4gPiAgICAgICB0aGUgdGltZTogaWYgd2UgZmls bCB0aGUgdHJhbnNtaXQgcmluZywgd2Ugc2hvdWxkIHRlbGwgdGhlIGhvc3QKPiA+ID4gPiAgICAg ICBpbW1lZGlhdGVseS4KPiA+ID4gPiAgICAgICBVbmZvcnR1bmF0ZWx5IHRoaXMgbG9naWMgYWxz byBhcHBsaWVzIHRvIHRoZSByZWNlaXZpbmcgcmluZywgd2hpY2ggaXMKPiA+ID4gPiAgICAgICBy ZWZpbGxlZCBjb25zdGFudGx5LiAgV2Ugc2hvdWxkIGludHJvZHVjZSByZWFsIG5vdGlmaWNhdGlv biB0aGVzaG9sZHMKPiA+ID4gPiAgICAgICB0byByZXBsYWNlIHRoaXMgbG9naWMuICBNZWFud2hp bGUsIHJlbW92aW5nIHRoZSBsb2dpYyBhbHRvZ2V0aGVyIGJyZWFrcwo+ID4gPiA+ICAgICAgIHRo ZSBoZXVyaXN0aWNzIHdoaWNoIEtWTSB1c2VzLCBzbyB3ZSB1c2UgYSBoYWNrOiBvbmx5IG5vdGlm eSBpZiB0aGVyZSBhcmUKPiA+ID4gPiAgICAgICBvdXRnb2luZyBwYXJ0cyBvZiB0aGUgbmV3IGJ1 ZmZlci4KPiA+ID4gPiAgICAgICBIZXJlIGFyZSB0aGUgbnVtYmVyIG9mIGV4aXRzIHdpdGggbGd1 ZXN0J3MgY3JhcHB5IG5ldHdvcmsgaW1wbGVtZW50YXRpb246Cj4gPiA+ID4gICAgICAgQmVmb3Jl Ogo+ID4gPiA+ICAgICAgICAgICAgICAgbmV0d29yayB4bWl0IDc4NTkwNTEgcmVjdiAyMzY0MjAK PiA+ID4gPiAgICAgICBBZnRlcjoKPiA+ID4gPiAgICAgICAgICAgICAgIG5ldHdvcmsgeG1pdCA3 ODU4NjEwIHJlY3YgMTE4MTM2Cj4gPiA+ID4gICAgICAgU2lnbmVkLW9mZi1ieTogUnVzdHkgUnVz c2VsbDxydXN0eUBydXN0Y29ycC5jb20uYXU+Cj4gPiA+ID4gCj4gPiA+ID4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvdmlydGlvL3ZpcnRpb19yaW5nLmMgYi9kcml2ZXJzL3ZpcnRpby92aXJ0aW9fcmlu Zy5jCj4gPiA+ID4gaW5kZXggNzJiZjhiYzA5MDE0Li4yMWQ5YTYyNzY3YWYgMTAwNjQ0Cj4gPiA+ ID4gLS0tIGEvZHJpdmVycy92aXJ0aW8vdmlydGlvX3JpbmcuYwo+ID4gPiA+ICsrKyBiL2RyaXZl cnMvdmlydGlvL3ZpcnRpb19yaW5nLmMKPiA+ID4gPiBAQCAtODcsOCArODcsMTEgQEAgc3RhdGlj IGludCB2cmluZ19hZGRfYnVmKHN0cnVjdCB2aXJ0cXVldWUgKl92cSwKPiA+ID4gPiAgICAJaWYg KHZxLT5udW1fZnJlZSA8IG91dCArIGluKSB7Cj4gPiA+ID4gICAgCQlwcl9kZWJ1ZygiQ2FuJ3Qg YWRkIGJ1ZiBsZW4gJWkgLSBhdmFpbCA9ICVpXG4iLAo+ID4gPiA+ICAgIAkJCSBvdXQgKyBpbiwg dnEtPm51bV9mcmVlKTsKPiA+ID4gPiAtCQkvKiBXZSBub3RpZnkqZXZlbiBpZiogIFZSSU5HX1VT RURfRl9OT19OT1RJRlkgaXMgc2V0IGhlcmUuICovCj4gPiA+ID4gLQkJdnEtPm5vdGlmeSgmdnEt PnZxKTsKPiA+ID4gPiArCQkvKiBGSVhNRTogZm9yIGhpc3RvcmljYWwgcmVhc29ucywgd2UgZm9y Y2UgYSBub3RpZnkgaGVyZSBpZgo+ID4gPiA+ICsJCSAqIHRoZXJlIGFyZSBvdXRnb2luZyBwYXJ0 cyB0byB0aGUgYnVmZmVyLiAgUHJlc3VtYWJseSB0aGUKPiA+ID4gPiArCQkgKiBob3N0IHNob3Vs ZCBzZXJ2aWNlIHRoZSByaW5nIEFTQVAuICovCj4gPiA+ID4gKwkJaWYgKG91dCkKPiA+ID4gPiAr CQkJdnEtPm5vdGlmeSgmdnEtPnZxKTsKPiA+ID4gPiAgICAJCUVORF9VU0UodnEpOwo+ID4gPiA+ ICAgIAkJcmV0dXJuIC1FTk9TUEM7Cj4gPiA+ID4gICAgCX0KPiA+ID4gPiAKPiA+ID4gPiAKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KVmlydHVhbGl6YXRp b24gbWFpbGluZyBsaXN0ClZpcnR1YWxpemF0aW9uQGxpc3RzLmxpbnV4LWZvdW5kYXRpb24ub3Jn Cmh0dHBzOi8vbGlzdHMubGludXhmb3VuZGF0aW9uLm9yZy9tYWlsbWFuL2xpc3RpbmZvL3ZpcnR1 YWxpemF0aW9u