From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH net-next v2 3/5] virtio_ring: add packed ring support Date: Thu, 8 Nov 2018 23:00:28 -0500 Message-ID: <20181108225858-mutt-send-email-mst__44883.010935928$1541735913$gmane$org@kernel.org> References: <20180711022711.7090-1-tiwei.bie@intel.com> <20180711022711.7090-4-tiwei.bie@intel.com> <20181107123933-mutt-send-email-mst@kernel.org> <20181108013759.GA20591@debian> <2d46a41e-bc00-276a-e19a-105c9dffc75a@redhat.com> <20181108115148.GA15701@debian> <20181108103155-mutt-send-email-mst@kernel.org> <67bd6a88-00f2-ed13-ad13-bdfe92ceeffc@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <67bd6a88-00f2-ed13-ad13-bdfe92ceeffc@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Jason Wang Cc: virtio-dev@lists.oasis-open.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, wexu@redhat.com List-Id: virtualization@lists.linuxfoundation.org T24gRnJpLCBOb3YgMDksIDIwMTggYXQgMTA6MzA6NTBBTSArMDgwMCwgSmFzb24gV2FuZyB3cm90 ZToKPiAKPiBPbiAyMDE4LzExLzgg5LiL5Y2IMTE6NTYsIE1pY2hhZWwgUy4gVHNpcmtpbiB3cm90 ZToKPiA+IE9uIFRodSwgTm92IDA4LCAyMDE4IGF0IDA3OjUxOjQ4UE0gKzA4MDAsIFRpd2VpIEJp ZSB3cm90ZToKPiA+ID4gT24gVGh1LCBOb3YgMDgsIDIwMTggYXQgMDQ6MTg6MjVQTSArMDgwMCwg SmFzb24gV2FuZyB3cm90ZToKPiA+ID4gPiBPbiAyMDE4LzExLzgg5LiK5Y2IOTozOCwgVGl3ZWkg QmllIHdyb3RlOgo+ID4gPiA+ID4gPiA+ICsKPiA+ID4gPiA+ID4gPiArCWlmICh2cS0+dnEubnVt X2ZyZWUgPCBkZXNjc191c2VkKSB7Cj4gPiA+ID4gPiA+ID4gKwkJcHJfZGVidWcoIkNhbid0IGFk ZCBidWYgbGVuICVpIC0gYXZhaWwgPSAlaVxuIiwKPiA+ID4gPiA+ID4gPiArCQkJIGRlc2NzX3Vz ZWQsIHZxLT52cS5udW1fZnJlZSk7Cj4gPiA+ID4gPiA+ID4gKwkJLyogRklYTUU6IGZvciBoaXN0 b3JpY2FsIHJlYXNvbnMsIHdlIGZvcmNlIGEgbm90aWZ5IGhlcmUgaWYKPiA+ID4gPiA+ID4gPiAr CQkgKiB0aGVyZSBhcmUgb3V0Z29pbmcgcGFydHMgdG8gdGhlIGJ1ZmZlci4gIFByZXN1bWFibHkg dGhlCj4gPiA+ID4gPiA+ID4gKwkJICogaG9zdCBzaG91bGQgc2VydmljZSB0aGUgcmluZyBBU0FQ LiAqLwo+ID4gPiA+ID4gPiBJIGRvbid0IHRoaW5rIHdlIGhhdmUgYSByZWFzb24gdG8gZG8gdGhp cyBmb3IgcGFja2VkIHJpbmcuCj4gPiA+ID4gPiA+IE5vIGhpc3RvcmljYWwgYmFnZ2FnZSB0aGVy ZSwgcmlnaHQ/Cj4gPiA+ID4gPiBCYXNlZCBvbiB0aGUgb3JpZ2luYWwgY29tbWl0IGxvZywgaXQg c2VlbXMgdGhhdCB0aGUgbm90aWZ5IGhlcmUKPiA+ID4gPiA+IGlzIGp1c3QgYW4gIm9wdGltaXph dGlvbiIuIEJ1dCBJIGRvbid0IHF1aXRlIHVuZGVyc3RhbmQgd2hhdCBkb2VzCj4gPiA+ID4gPiB0 aGUgInRoZSBoZXVyaXN0aWNzIHdoaWNoIEtWTSB1c2VzIiByZWZlciB0by4gSWYgaXQncyBzYWZl IHRvIGRyb3AKPiA+ID4gPiA+IHRoaXMgaW4gcGFja2VkIHJpbmcsIEknZCBsaWtlIHRvIGRvIGl0 Lgo+ID4gPiA+IAo+ID4gPiA+IEFjY29yZGluZyB0byB0aGUgY29tbWl0IGxvZywgaXQgc2VlbXMg bGlrZSBhIHdvcmthcm91bmQgb2YgbGd1ZXN0IG5ldHdvcmtpbmcKPiA+ID4gPiBiYWNrZW5kLgo+ ID4gPiBEbyB5b3Uga25vdyB3aHkgcmVtb3ZpbmcgdGhpcyBub3RpZnkgaW4gVHggd2lsbCBicmVh ayAidGhlCj4gPiA+IGhldXJpc3RpY3Mgd2hpY2ggS1ZNIHVzZXMiPyBPciB3aGF0IGRvZXMgInRo ZSBoZXVyaXN0aWNzCj4gPiA+IHdoaWNoIEtWTSB1c2VzIiByZWZlciB0bz8KPiA+IFllcy4gUUVN VSBoYXMgYSBtb2RlIHdoZXJlIGl0IGRpc2FibGVzIG5vdGlmaWNhdGlvbnMgYW5kIHByb2Nlc3Nl cyBUWAo+ID4gcmluZyBwZXJpb2RpY2FsbHkgZnJvbSBhIHRpbWVyLiAgSXQncyBvZmYgYnkgZGVm YXVsdCBidXQgdXNlZCB0byBiZSBvbgo+ID4gYnkgZGVmYXVsdCBhIGxvbmcgdGltZSBhZ28uIElm IHJpbmcgYmVjb21lcyBmdWxsIHRoaXMgY2F1c2VzIHRyYWZmaWMKPiA+IHN0YWxscy4KPiAKPiAK PiBEbyB5b3UgbWVhbiB0eC10aW1lcj8gSWYgeWVzLCB3ZSBjYW4gc3RpbGwgZW5hYmxlIGl0IGZv ciBwYWNrZWQgcmluZwoKWWVzIHdlIGNhbiBidXQgSSBkb3VidCBhbnlvbmUgZG9lcy4KCj4gYW5k IHRoZQo+IHRpbWVyIHdpbGwgZmluYWxseSBmaXJlZCBhbmQgd2UgY2FuIGdvLgoKb24gdHggcmlu ZyBmdWxsIHdlIHByb2JhYmx5IGRvbid0IHdhbnQgdG8gd2FpdCBmb3IgdGltZXIuCkJ1dCBJIHRo aW5rIHdlIGNhbiBqdXN0IHByZXZlbnQgcWVtdSBmcm9tIHVzaW5nIHR4IHRpbWVyCndpdGggdmly dGlvIDEuCgo+IAo+ID4gQXMgYSB3b3JrLWFyb3VuZCBSdXN0eSBwdXQgaW4gdGhpcyBoYWNrIHRv IGtpY2sgb24gcmluZyBmdWxsCj4gPiBldmVuIHdpdGggbm90aWZpY2F0aW9ucyBkaXNhYmxlZC4K PiAKPiAKPiBGcm9tIHRoZSBjb21taXQgbG9nIGl0IGxvb2tzIG1vcmUgbGlrZSBhIHBlcmZvcm1h bmNlIHdvcmthcm91bmQgaW5zdGVhZCBvZiBhCj4gYnVnIGZpeC4KCml0J3MgYSBxdWFsaXR5IG9m IGltcGxlbWVudGF0aW9uIGlzc3VlLCB5ZXMuCgo+IAo+ID4gSXQncyBlYXN5IGVub3VnaCB0byBt YWtlIHN1cmUgUUVNVQo+ID4gZG9lcyBub3QgY29tYmluZSBkZXZpY2VzIHdpdGggcGFja2VkIHJp bmcgc3VwcG9ydCB3aXRoIHRoZSB0aW1lciBoYWNrLgo+ID4gQW5kIEkgYW0gZ3Vlc3NpbmcgaXQn cyBzYWZlIGVub3VnaCB0byBhbHNvIGJsb2NrIHRoYXQgb3B0aW9uIGNvbXBsZXRlbHkKPiA+IGUu Zy4gd2hlbiB2aXJ0aW8gMS4wIGlzIGVuYWJsZWQuCj4gCj4gCj4gSSBhZ3JlZS4KPiAKPiBUaGFu a3MKPiAKPiAKPiA+ID4gPiBJIGFncmVlIHRvIGRyb3AgaXQsIHdlIHNob3VsZCBub3QgaGF2ZSBz dWNoIGJ1cmRlbi4KPiA+ID4gPiAKPiA+ID4gPiBCdXQgd2Ugc2hvdWxkIG5vdGljZSB0aGF0LCB3 aXRoIHRoaXMgcmVtb3ZlZCwgdGhlIGNvbXBhcmUgYmV0d2VlbiBwYWNrZWQgdnMKPiA+ID4gPiBz cGxpdCBpcyBraW5kIG9mIHVuZmFpci4gQ29uc2lkZXIgdGhlIHJlbW92YWwgb2YgbGd1ZXN0IHN1 cHBvcnQgcmVjZW50bHksCj4gPiA+ID4gbWF5YmUgd2UgY2FuIGRyb3AgdGhpcyBmb3Igc3BsaXQg cmluZyBhcyB3ZWxsPwo+ID4gPiA+IAo+ID4gPiA+IFRoYW5rcwo+ID4gPiA+IAo+ID4gPiA+IAo+ ID4gPiA+ID4gY29tbWl0IDQ0NjUzZWFlMTQwN2Y3OWRmZjZmNTJmY2Y1OTRhZTg0Y2IxNjVlYzQK PiA+ID4gPiA+IEF1dGhvcjogUnVzdHkgUnVzc2VsbDxydXN0eUBydXN0Y29ycC5jb20uYXU+Cj4g PiA+ID4gPiBEYXRlOiAgIEZyaSBKdWwgMjUgMTI6MDY6MDQgMjAwOCAtMDUwMAo+ID4gPiA+ID4g Cj4gPiA+ID4gPiAgICAgICB2aXJ0aW86IGRvbid0IGFsd2F5cyBmb3JjZSBhIG5vdGlmaWNhdGlv biB3aGVuIHJpbmcgaXMgZnVsbAo+ID4gPiA+ID4gICAgICAgV2UgZm9yY2Ugbm90aWZpY2F0aW9u IHdoZW4gdGhlIHJpbmcgaXMgZnVsbCwgZXZlbiBpZiB0aGUgaG9zdCBoYXMKPiA+ID4gPiA+ICAg ICAgIGluZGljYXRlZCBpdCBkb2Vzbid0IHdhbnQgdG8ga25vdy4gIFRoaXMgc2VlbWVkIGxpa2Ug YSBnb29kIGlkZWEgYXQKPiA+ID4gPiA+ICAgICAgIHRoZSB0aW1lOiBpZiB3ZSBmaWxsIHRoZSB0 cmFuc21pdCByaW5nLCB3ZSBzaG91bGQgdGVsbCB0aGUgaG9zdAo+ID4gPiA+ID4gICAgICAgaW1t ZWRpYXRlbHkuCj4gPiA+ID4gPiAgICAgICBVbmZvcnR1bmF0ZWx5IHRoaXMgbG9naWMgYWxzbyBh cHBsaWVzIHRvIHRoZSByZWNlaXZpbmcgcmluZywgd2hpY2ggaXMKPiA+ID4gPiA+ICAgICAgIHJl ZmlsbGVkIGNvbnN0YW50bHkuICBXZSBzaG91bGQgaW50cm9kdWNlIHJlYWwgbm90aWZpY2F0aW9u IHRoZXNob2xkcwo+ID4gPiA+ID4gICAgICAgdG8gcmVwbGFjZSB0aGlzIGxvZ2ljLiAgTWVhbndo aWxlLCByZW1vdmluZyB0aGUgbG9naWMgYWx0b2dldGhlciBicmVha3MKPiA+ID4gPiA+ICAgICAg IHRoZSBoZXVyaXN0aWNzIHdoaWNoIEtWTSB1c2VzLCBzbyB3ZSB1c2UgYSBoYWNrOiBvbmx5IG5v dGlmeSBpZiB0aGVyZSBhcmUKPiA+ID4gPiA+ICAgICAgIG91dGdvaW5nIHBhcnRzIG9mIHRoZSBu ZXcgYnVmZmVyLgo+ID4gPiA+ID4gICAgICAgSGVyZSBhcmUgdGhlIG51bWJlciBvZiBleGl0cyB3 aXRoIGxndWVzdCdzIGNyYXBweSBuZXR3b3JrIGltcGxlbWVudGF0aW9uOgo+ID4gPiA+ID4gICAg ICAgQmVmb3JlOgo+ID4gPiA+ID4gICAgICAgICAgICAgICBuZXR3b3JrIHhtaXQgNzg1OTA1MSBy ZWN2IDIzNjQyMAo+ID4gPiA+ID4gICAgICAgQWZ0ZXI6Cj4gPiA+ID4gPiAgICAgICAgICAgICAg IG5ldHdvcmsgeG1pdCA3ODU4NjEwIHJlY3YgMTE4MTM2Cj4gPiA+ID4gPiAgICAgICBTaWduZWQt b2ZmLWJ5OiBSdXN0eSBSdXNzZWxsPHJ1c3R5QHJ1c3Rjb3JwLmNvbS5hdT4KPiA+ID4gPiA+IAo+ ID4gPiA+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvdmlydGlvL3ZpcnRpb19yaW5nLmMgYi9kcml2 ZXJzL3ZpcnRpby92aXJ0aW9fcmluZy5jCj4gPiA+ID4gPiBpbmRleCA3MmJmOGJjMDkwMTQuLjIx ZDlhNjI3NjdhZiAxMDA2NDQKPiA+ID4gPiA+IC0tLSBhL2RyaXZlcnMvdmlydGlvL3ZpcnRpb19y aW5nLmMKPiA+ID4gPiA+ICsrKyBiL2RyaXZlcnMvdmlydGlvL3ZpcnRpb19yaW5nLmMKPiA+ID4g PiA+IEBAIC04Nyw4ICs4NywxMSBAQCBzdGF0aWMgaW50IHZyaW5nX2FkZF9idWYoc3RydWN0IHZp cnRxdWV1ZSAqX3ZxLAo+ID4gPiA+ID4gICAgCWlmICh2cS0+bnVtX2ZyZWUgPCBvdXQgKyBpbikg ewo+ID4gPiA+ID4gICAgCQlwcl9kZWJ1ZygiQ2FuJ3QgYWRkIGJ1ZiBsZW4gJWkgLSBhdmFpbCA9 ICVpXG4iLAo+ID4gPiA+ID4gICAgCQkJIG91dCArIGluLCB2cS0+bnVtX2ZyZWUpOwo+ID4gPiA+ ID4gLQkJLyogV2Ugbm90aWZ5KmV2ZW4gaWYqICBWUklOR19VU0VEX0ZfTk9fTk9USUZZIGlzIHNl dCBoZXJlLiAqLwo+ID4gPiA+ID4gLQkJdnEtPm5vdGlmeSgmdnEtPnZxKTsKPiA+ID4gPiA+ICsJ CS8qIEZJWE1FOiBmb3IgaGlzdG9yaWNhbCByZWFzb25zLCB3ZSBmb3JjZSBhIG5vdGlmeSBoZXJl IGlmCj4gPiA+ID4gPiArCQkgKiB0aGVyZSBhcmUgb3V0Z29pbmcgcGFydHMgdG8gdGhlIGJ1ZmZl ci4gIFByZXN1bWFibHkgdGhlCj4gPiA+ID4gPiArCQkgKiBob3N0IHNob3VsZCBzZXJ2aWNlIHRo ZSByaW5nIEFTQVAuICovCj4gPiA+ID4gPiArCQlpZiAob3V0KQo+ID4gPiA+ID4gKwkJCXZxLT5u b3RpZnkoJnZxLT52cSk7Cj4gPiA+ID4gPiAgICAJCUVORF9VU0UodnEpOwo+ID4gPiA+ID4gICAg CQlyZXR1cm4gLUVOT1NQQzsKPiA+ID4gPiA+ICAgIAl9Cj4gPiA+ID4gPiAKPiA+ID4gPiA+IApf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpWaXJ0dWFsaXph dGlvbiBtYWlsaW5nIGxpc3QKVmlydHVhbGl6YXRpb25AbGlzdHMubGludXgtZm91bmRhdGlvbi5v cmcKaHR0cHM6Ly9saXN0cy5saW51eGZvdW5kYXRpb24ub3JnL21haWxtYW4vbGlzdGluZm8vdmly dHVhbGl6YXRpb24=