* [U-Boot] Portability of sh scripts
@ 2018-11-09 12:08 Martin Husemann
2018-11-09 12:11 ` Tom Rini
0 siblings, 1 reply; 2+ messages in thread
From: Martin Husemann @ 2018-11-09 12:08 UTC (permalink / raw)
To: u-boot
Hey folks,
I noticed that tools/imx_cntr_image.sh contains non-portable code:
if [ $f == "u-boot-dtb.bin" ]; then
This is a "bash-ism", the operator "==" is not implemented by most test(1)
or sh(1) impmlementations. Simply replacing it with "=" fixes this.
Should I send a trivial patch or do you just fix it?
Thanks,
Martin
^ permalink raw reply [flat|nested] 2+ messages in thread
* [U-Boot] Portability of sh scripts
2018-11-09 12:08 [U-Boot] Portability of sh scripts Martin Husemann
@ 2018-11-09 12:11 ` Tom Rini
0 siblings, 0 replies; 2+ messages in thread
From: Tom Rini @ 2018-11-09 12:11 UTC (permalink / raw)
To: u-boot
On Fri, Nov 09, 2018 at 01:08:42PM +0100, Martin Husemann wrote:
> Hey folks,
>
> I noticed that tools/imx_cntr_image.sh contains non-portable code:
>
> if [ $f == "u-boot-dtb.bin" ]; then
>
> This is a "bash-ism", the operator "==" is not implemented by most test(1)
> or sh(1) impmlementations. Simply replacing it with "=" fixes this.
>
> Should I send a trivial patch or do you just fix it?
Please send a patch, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181109/7a981e59/attachment.sig>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-11-09 12:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-09 12:08 [U-Boot] Portability of sh scripts Martin Husemann
2018-11-09 12:11 ` Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.