From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1gLBcy-0002aN-FC for mharc-grub-devel@gnu.org; Fri, 09 Nov 2018 13:35:32 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54211) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gLBcx-0002aD-3Q for grub-devel@gnu.org; Fri, 09 Nov 2018 13:35:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gLBcr-0003IX-Fw for grub-devel@gnu.org; Fri, 09 Nov 2018 13:35:30 -0500 Received: from userp2130.oracle.com ([156.151.31.86]:32864) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gLBcq-0002wF-CW for grub-devel@gnu.org; Fri, 09 Nov 2018 13:35:25 -0500 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id wA9IYWnO004288; Fri, 9 Nov 2018 18:35:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2018-07-02; bh=c6za/tmUo/aI77F18rGJ2EFEkRaDcCGgvPtbnK2UEAM=; b=L4D5Rt6NWMyzSKthRFlEcbLZR2g/Gz4/Ii0jqTXwz4CuatwNZyenZEUIVjjJ1Sf2fnRI ukt5qoF//dbvEYV5/YspyIbilNVwyI33TVVpKwiazx+dvBHkQCKEQeS2MsaCL2nUJawZ BRzIX3X0RLwRBX6OV5lc29wJfim9xRua+4ZJ16udSzbSNn9iojTI8KsD76k0s8hyvA15 ap153X7tlHOQd+fVPE8/YX7p/+OMd6Wa6m0+JFjDWGztkrHkwlJq5GPkH70sm5Yt+B5F V7NF8XQi8gy6ku0jtbm4OJLnrezBVHvx/5or1atp9BtMbI8a6V583o8GVhd+6b1X0JCx AA== Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by userp2130.oracle.com with ESMTP id 2nh33ugmr7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 09 Nov 2018 18:35:19 +0000 Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserv0021.oracle.com (8.14.4/8.14.4) with ESMTP id wA9IZD6m006891 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 9 Nov 2018 18:35:13 GMT Received: from abhmp0014.oracle.com (abhmp0014.oracle.com [141.146.116.20]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id wA9IZCXS002912; Fri, 9 Nov 2018 18:35:12 GMT Received: from olila.i.net-space.pl (/10.175.209.204) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 09 Nov 2018 10:35:11 -0800 Date: Fri, 9 Nov 2018 19:35:07 +0100 From: Daniel Kiper To: Juergen Gross Cc: grub-devel@gnu.org, xen-devel@lists.xen.org, phcoder@gmail.com, hans@knorrie.org Subject: Re: [PATCH v4 11/19] xen: get memory map from hypervisor for PVH Message-ID: <20181109183507.GE4363@olila.i.net-space.pl> References: <20181102123738.16395-1-jgross@suse.com> <20181102123738.16395-12-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181102123738.16395-12-jgross@suse.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9072 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=985 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1811090168 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-Received-From: 156.151.31.86 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Nov 2018 18:35:31 -0000 On Fri, Nov 02, 2018 at 01:37:30PM +0100, Juergen Gross wrote: > Retrieve the memory map from the hypervisor and normalize it to contain > no overlapping entries and to be sorted by address. > > Signed-off-by: Juergen Gross One nit pick below. Otherwise Reviewed-by: Daniel Kiper > --- > V3: use grub_e820_mmap_entry instead of own struct (Daniel Kiper) > --- > grub-core/kern/i386/xen/pvh.c | 96 ++++++++++++++++++++++++++++++++++++++++++- > 1 file changed, 95 insertions(+), 1 deletion(-) > > diff --git a/grub-core/kern/i386/xen/pvh.c b/grub-core/kern/i386/xen/pvh.c > index 7e90a4538..58e6fefd5 100644 > --- a/grub-core/kern/i386/xen/pvh.c > +++ b/grub-core/kern/i386/xen/pvh.c > @@ -23,9 +23,14 @@ > #include > #include > #include > +#include > #include > +#include > +#include > > -#define XEN_CONSOLE_PORT 0xe9 > +#define XEN_CONSOLE_PORT 0xe9 Probably this will disappear but if not please put properly aligned values in earlier patch to avoid such code shuffling. Daniel